From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: Nicholas Hanley <nicholasjhanley@gmail.com>
Cc: "Drokin, Oleg" <oleg.drokin@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Simmons <jsimmons@infradead.org>,
"Lustre Development List" <lustre-devel@lists.lustre.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: lustre: o2iblnd: use bool assignment to true/false
Date: Mon, 7 Nov 2016 21:20:30 +0000 [thread overview]
Message-ID: <96662E15-7BBE-41BB-9CEB-07BBA34AA90A@intel.com> (raw)
In-Reply-To: <20161107190138.5730-1-nicholasjhanley@gmail.com>
On Nov 7, 2016, at 12:01, Nicholas Hanley <nicholasjhanley@gmail.com> wrote:
>
> Replace 0 with false in tx_pages_mapped = 0 to be consistent with
> the rest of the lustre code.
>
> Signed-off-by: Nicholas Hanley <nicholasjhanley@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> index 13235b0..e2fc65f 100644
> --- a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> +++ b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
> @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> {
> __u64 *pages = tx->tx_pages;
> bool is_rx = (rd != tx->tx_rd);
> - bool tx_pages_mapped = 0;
> + bool tx_pages_mapped = false;
> struct kib_fmr_pool *fpo;
> int npages = 0;
> __u64 version;
> --
> 2.10.2
>
prev parent reply other threads:[~2016-11-07 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 19:01 [PATCH] staging: lustre: o2iblnd: use bool assignment to true/false Nicholas Hanley
2016-11-07 21:20 ` Dilger, Andreas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96662E15-7BBE-41BB-9CEB-07BBA34AA90A@intel.com \
--to=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=nicholasjhanley@gmail.com \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).