From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 406EAC25B08 for ; Wed, 17 Aug 2022 13:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238904AbiHQNgy (ORCPT ); Wed, 17 Aug 2022 09:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234215AbiHQNgv (ORCPT ); Wed, 17 Aug 2022 09:36:51 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D2A271987; Wed, 17 Aug 2022 06:36:50 -0700 (PDT) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1oOJDz-00041R-AG; Wed, 17 Aug 2022 15:36:47 +0200 Message-ID: <967ef480-2fac-9724-61c7-2d5e69c26ec3@leemhuis.info> Date: Wed, 17 Aug 2022 15:36:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Content-Language: en-US To: Michael Grzeschik , Oleksij Rempel Cc: "regressions@lists.linux.dev" , LKML , Vladimir Oltean , Florian Fainelli , netdev , craig@mcqueen.id.au From: Thorsten Leemhuis Subject: Bug 216320 - KSZ8794 operation broken Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1660743410;4d681711; X-HE-SMSGID: 1oOJDz-00041R-AG Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, this is your Linux kernel regression tracker. I noticed a regression report in bugzilla.kernel.org that afaics nobody acted upon since it was reported. That's why I decided to forward it by mail to those that afaics should handle this. To quote from https://bugzilla.kernel.org/show_bug.cgi?id=216320 : > After upgrading a Yocto build system from kernel 5.4 to 5.15, I found KSZ8794 switch operation was no longer functional. I got errors such as: > > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.770912] ksz8795-switch spi2.0: Unsupported interface: gmii, port: 0 > Aug 1 22:23:17 tv999996 kern.warn kernel: [ 10.777562] ksz8795-switch spi2.0 wan (uninitialized): validation of gmii with support 0000000,00000000,000062cf and advertisement 0000000,00000000,000062cf failed: -22 > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.792874] ksz8795-switch spi2.0 wan (uninitialized): failed to connect to PHY: -EINVAL > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.800978] ksz8795-switch spi2.0 wan (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 0 > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.829188] ksz8795-switch spi2.0: Unsupported interface: gmii, port: 1 > Aug 1 22:23:17 tv999996 kern.warn kernel: [ 10.835821] ksz8795-switch spi2.0 lan2 (uninitialized): validation of gmii with support 0000000,00000000,000062cf and advertisement 0000000,00000000,000062cf failed: -22 > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.851156] ksz8795-switch spi2.0 lan2 (uninitialized): failed to connect to PHY: -EINVAL > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.859358] ksz8795-switch spi2.0 lan2 (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 1 > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.892821] ksz8795-switch spi2.0: Unsupported interface: gmii, port: 2 > Aug 1 22:23:17 tv999996 kern.warn kernel: [ 10.899466] ksz8795-switch spi2.0 lan1 (uninitialized): validation of gmii with support 0000000,00000000,000062cf and advertisement 0000000,00000000,000062cf failed: -22 > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.914845] ksz8795-switch spi2.0 lan1 (uninitialized): failed to connect to PHY: -EINVAL > Aug 1 22:23:17 tv999996 kern.err kernel: [ 10.923052] ksz8795-switch spi2.0 lan1 (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 2 > > I found that if I reverted commit 2c709e0bdad4d996ec8925b9ee6d5b97458708f1, "net: dsa: microchip: ksz8795: add phylink support", then it worked properly again. The errors I saw were due to the checks in ksz8_validate() that were added in the above commit. Could somebody please take a look, especially if you're among the main recipients of this mail and not just CCed? Anyway, to ensure this is not forgotten I'll add it to the Linux kernel regression tracking bot: #regzbot introduced: 2c709e0bdad4d996ec8925b9ee6d5b97458708f1 https://bugzilla.kernel.org/show_bug.cgi?id=216320 This isn't a regression? This issue or a fix for it are already discussed somewhere else? It was fixed already? You want to clarify when the regression started to happen? Or point out I got the title or something else totally wrong? Then just reply -- ideally with also telling regzbot about it, as explained here: https://linux-regtracking.leemhuis.info/tracked-regression/ Reminder for developers: When fixing the issue, add 'Link:' tags pointing to the report in bugzilla, as the kernel's documentation calls for; above page explains why this is important for tracked regressions. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.