From: Ivan Safonov <insafonov@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, B K Karthik <bkkarthik@pesu.pes.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: replace rtw_netdev_priv define with inline function
Date: Sat, 1 Aug 2020 16:11:38 +0300 [thread overview]
Message-ID: <968d30fc-4e5f-b495-e986-b18b05e9a895@gmail.com> (raw)
In-Reply-To: <20200801095108.GA2840539@kroah.com>
On 8/1/20 12:51 PM, Greg Kroah-Hartman wrote:
> On Sat, Aug 01, 2020 at 12:47:07PM +0300, Ivan Safonov wrote:
>> The function guarantees type checking of arguments and return value.
>>
>> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
>> ---
>> drivers/staging/rtl8188eu/include/osdep_service.h | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h b/drivers/staging/rtl8188eu/include/osdep_service.h
>> index 31d897f1d21f..e0ccafdea9cd 100644
>> --- a/drivers/staging/rtl8188eu/include/osdep_service.h
>> +++ b/drivers/staging/rtl8188eu/include/osdep_service.h
>> @@ -71,8 +71,10 @@ struct rtw_netdev_priv_indicator {
>> };
>> struct net_device *rtw_alloc_etherdev_with_old_priv(void *old_priv);
>>
>> -#define rtw_netdev_priv(netdev) \
>> - (((struct rtw_netdev_priv_indicator *)netdev_priv(netdev))->priv)
>> +static inline struct adapter *rtw_netdev_priv(struct net_device *dev)
>> +{
>> + return (((struct rtw_netdev_priv_indicator *)netdev_priv(dev))->priv);
>> +}
>> void rtw_free_netdev(struct net_device *netdev);
>
> Is the cast really needed?
(struct rtw_netdev_priv_indicator *) cast needed for access to '->priv'.
The (struct adapter *) return type is a starting point for simplify
struct adapter *padapter = (struct adapter *)rtw_netdev_priv(dev);
constructions.
>
> And no blank line before the next function prototype?
In v2.
>
> And is this really needed? Type checking is already happening as this
> is a "simple" macro, right?
1. The flexibility of macros is not needed here.
2. The macro silently assigns ->priv to any pointer, while the function
indicates such a compile-time error.
Ivan Safonov.
next prev parent reply other threads:[~2020-08-01 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 9:47 [PATCH] staging: r8188eu: replace rtw_netdev_priv define with inline function Ivan Safonov
2020-08-01 9:51 ` Greg Kroah-Hartman
2020-08-01 13:11 ` Ivan Safonov [this message]
2020-08-01 13:12 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=968d30fc-4e5f-b495-e986-b18b05e9a895@gmail.com \
--to=insafonov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bkkarthik@pesu.pes.edu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).