From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbdK3Lpc (ORCPT ); Thu, 30 Nov 2017 06:45:32 -0500 Received: from mga06.intel.com ([134.134.136.31]:16093 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbdK3Lpb (ORCPT ); Thu, 30 Nov 2017 06:45:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,341,1508828400"; d="scan'208";a="13726370" Subject: Re: [PATCH] mmc: block: make function mmc_cqe_issue_type static To: Colin King , Ulf Hansson , Linus Walleij , linux-mmc@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171130113738.3851-1-colin.king@canonical.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <969757e5-79e3-c12c-259f-9461b5a40f34@intel.com> Date: Thu, 30 Nov 2017 13:45:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171130113738.3851-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/11/17 13:37, Colin King wrote: > From: Colin Ian King > > The function mmc_cqe_issue_type is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > drivers/mmc/core/queue.c:62:21: warning: symbol 'mmc_cqe_issue_type' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King Acked-by: Adrian Hunter > --- > drivers/mmc/core/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c > index d8394007bc99..5db388081789 100644 > --- a/drivers/mmc/core/queue.c > +++ b/drivers/mmc/core/queue.c > @@ -59,8 +59,8 @@ static inline bool mmc_cqe_can_dcmd(struct mmc_host *host) > return host->caps2 & MMC_CAP2_CQE_DCMD; > } > > -enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, > - struct request *req) > +static enum mmc_issue_type mmc_cqe_issue_type(struct mmc_host *host, > + struct request *req) > { > switch (req_op(req)) { > case REQ_OP_DRV_IN: >