From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C4EC47094 for ; Thu, 10 Jun 2021 15:54:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62D28613CB for ; Thu, 10 Jun 2021 15:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231835AbhFJP4O (ORCPT ); Thu, 10 Jun 2021 11:56:14 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:45435 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230413AbhFJP4N (ORCPT ); Thu, 10 Jun 2021 11:56:13 -0400 Received: from [192.168.1.155] ([95.115.39.199]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MYcy3-1lmiJv27xT-00VeCN; Thu, 10 Jun 2021 17:54:08 +0200 Subject: Re: [PATCH V3 1/3] gpio: Add virtio-gpio driver To: Viresh Kumar , Bartosz Golaszewski , Linus Walleij , "Enrico Weigelt, metux IT consult" , Viresh Kumar , "Michael S. Tsirkin" , Jason Wang Cc: Vincent Guittot , Bill Mills , =?UTF-8?Q?Alex_Benn=c3=a9e?= , stratos-dev@op-lists.linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Hajnoczi , "Stefano Garzarella --cc virtualization @ lists . linux-foundation . org" , virtualization@lists.linux-foundation.org References: <10442926ae8a65f716bfc23f32339a6b35e51d5a.1623326176.git.viresh.kumar@linaro.org> From: "Enrico Weigelt, metux IT consult" Message-ID: <96994f4c-8755-90a8-0c50-4e21c436f137@metux.net> Date: Thu, 10 Jun 2021 17:54:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <10442926ae8a65f716bfc23f32339a6b35e51d5a.1623326176.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: tl Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:TpZLghCRLTrNtNW+A1KmT6oXfMlGYLufbz1HB4G9ZrndMBLiAMA FVfl8K9eppG2BpJKNJptrV94A784Wye+RIBqfGfto9qYovYlwzDTQZBKORdm5Nb/3TK2+4n 4XYrJWRfsSoOilWq4fKT4mBK5lonv00flbjvk8KLQn9c/McKTZOWz8fND0XqCHl1eX8PW5x 86KB391zJUIxpNc8lPzxw== X-UI-Out-Filterresults: notjunk:1;V03:K0:N8ukqCZYYn8=:BSOYsJ6jT2KSyQltacOA9y agJM0fJ5GIxIEpyhyOMp+UDIQQJYGuL9AFSbYrI1hW8pmjE9d9pRf49tKmoSXSPR4+0AcCO1j uHobuj05FlEXa8eHxeOkOFMAmKNeSbK8Ke4NyQjrRulTdjc6eS3P+uFat9cXaVydtKeWzPcDH EW49OxY3dDn5U8HMIsDTI6vcDvrvlZiL8OhwXwL5cuCSDCP6xc0yyCQWMedR8mjragnGEZgYB K9YYGwdVqzQEMCq2b9IYDUmIObXUoONMzdzrTeI5fMfNQX1yJ6bwANSq86aa3pG4P0ZjxAODh fMOA4z+WG7nXbldgwoq2YirtTd/ZTAAY7k8PsskJBZ/Kf9LRyfZ0TJa39X61DzRfaMLE2u9is aUPkjGdoUWuC3LtErxd2nnUZO4Ot+sJ4e9frRUYUbKVYPYw54ZP2c4CUGVbbyaQeEark6K+xy Dbk0SnU+jiiM3zgLOcZRfdqvqSPnrreALdAYaNLfqqWQ5Tyb59gn+yPgU9/2wHtr7fb7FUUI5 m8P3VXKNCbDR02ZLLUpNPk= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.06.21 14:16, Viresh Kumar wrote: > From: "Enrico Weigelt, metux IT consult" > > This patch adds a new driver for Virtio based GPIO devices. > > This allows a guest VM running Linux to access GPIO device provided by > the host. It supports all basic operations for now, except interrupts > for the GPIO lines. What exactly did you change here from my original driver ? Your already changed the spec havily (w/o consulting me first), so I guess this driver hasn't so much in common w/ my original design. Note that I made my original design decisions for good reaons (see virtio-dev list). It already support async notifications (IOW: irqs), had an easy upgrade path for future additions, etc. Note #2: it's already implemented and running in the field (different kernels, different hypervisors, ...) - it just lacked the going through virtio comitte's formal specification process, which blocked mainlining. Is there anything fundamentally wrong w/ my original design, why you invented a completely new one ? --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287