From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B796C433EF for ; Thu, 7 Oct 2021 07:08:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AD94611C1 for ; Thu, 7 Oct 2021 07:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240309AbhJGHKV (ORCPT ); Thu, 7 Oct 2021 03:10:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233691AbhJGHKQ (ORCPT ); Thu, 7 Oct 2021 03:10:16 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAEF8C061746 for ; Thu, 7 Oct 2021 00:08:22 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id E4EB322234; Thu, 7 Oct 2021 09:08:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1633590499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UFkVEvCjAWNe1QtX4/ziCIztrpKNnKkz4actHzZezx8=; b=aKYH/nVwGDBvOfZBOVnT/4CPDNcJAjCrkss/MEKFfo5D91kH5o8NzBK19NbygfDvyetIgE 9sC5gFj7rWjfscWxkfICQstMZCbryJpSLEVV40cvKKHuVGDnfO9ZJTeVa+/D4zNLrB/z+v UVN3+u1Jf3G7P0G+yUurU0gBdIk6FrQ= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 07 Oct 2021 09:08:18 +0200 From: Michael Walle To: Matthias Schiffer Cc: Tudor Ambarus , Pratyush Yadav , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: (EXT) Re: [PATCH 1/2] mtd: spi-nor: micron-st: sync flags of mt25ql02g and mt25qu02g with other mt25q In-Reply-To: <3258026683c916a3a42e98ba76628228cddacb23.camel@ew.tq-group.com> References: <3258026683c916a3a42e98ba76628228cddacb23.camel@ew.tq-group.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <969e9169b77bb314aaa2e97789c76c00@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2021-10-06 14:32, schrieb Matthias Schiffer: > On Tue, 2021-07-27 at 09:09 +0200, Michael Walle wrote: >> Am 2021-07-23 13:27, schrieb Matthias Schiffer: >> > All mt25q variants have the same features. >> > >> > Unlike the smaller variants, no n25q with 2G exists, so we don't need >> > to >> > match on the extended ID to distinguish n25q and mt25q series for these >> > models. >> >> But why shouldn't we? What if there will be another flash with >> the same first three id bytes? > > How do you suggest we proceed here? At the moment there are entries > matching on 0x20b[ab]22 (ignoring the extended ID) with the name > mt25q[lu]02g. > > Should I change these entries to match on on the extended ID > 0x20b[ab]22 / 0x104400 instead when I add the bits for the features > specific to the variant, removing support for other 0x20b[ab]22 > variants that may or may not actually exist? Keeping both entries (with > and without extended ID match) would preserve compatiblity with such > variants, but this approach seems problematic to me as well, as I can't > even give a name to the more generic entries (and there is no natural > extension of the n25q naming scheme to a 2G variant). Mh, what do you think of adding three entries and make the last one, the one with the short id, as a fallback so to speak. This should retrain backwards compatibility, right? It should probably have a comment because the order will matter then. -michael