From: Pierre Morel <pmorel@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>, Jason Wang <jasowang@redhat.com>
Cc: linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
frankja@linux.ibm.com, mst@redhat.com, cohuck@redhat.com,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] s390: protvirt: virtio: Refuse device without IOMMU
Date: Mon, 15 Jun 2020 13:49:54 +0200 [thread overview]
Message-ID: <96a236da-7165-b59b-e013-919554fb1ac4@linux.ibm.com> (raw)
In-Reply-To: <20200615123725.13f6a8de.pasic@linux.ibm.com>
On 2020-06-15 12:37, Halil Pasic wrote:
> On Mon, 15 Jun 2020 11:01:55 +0800
> Jason Wang <jasowang@redhat.com> wrote:
>
>>> hum, in between I found another way which seems to me much better:
>>>
>>> We already have the force_dma_unencrypted() function available which
>>> AFAIU is what we want for encrypted memory protection and is already
>>> used by power and x86 SEV/SME in a way that seems AFAIU compatible
>>> with our problem.
>>>
>>> Even DMA and IOMMU are different things, I think they should be used
>>> together in our case.
>>>
>>> What do you think?
>>>
>>> The patch would then be something like:
>>>
>>> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
>>> index a977e32a88f2..53476d5bbe35 100644
>>> --- a/drivers/virtio/virtio.c
>>> +++ b/drivers/virtio/virtio.c
>>> @@ -4,6 +4,7 @@
>>> #include <linux/virtio_config.h>
>>> #include <linux/module.h>
>>> #include <linux/idr.h>
>>> +#include <linux/dma-direct.h>
>>> #include <uapi/linux/virtio_ids.h>
>>>
>>> /* Unique numbering for virtio devices. */
>>> @@ -179,6 +180,10 @@ int virtio_finalize_features(struct virtio_device
>>> *dev)
>>> if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1))
>>> return 0;
>>>
>>> + if (force_dma_unencrypted(&dev->dev) &&
>>> + !virtio_has_feature(dev, VIRTIO_F_IOMMU_PLATFORM))
>>> + return -EIO;
>>> +
>>> virtio_add_status(dev, VIRTIO_CONFIG_S_FEATURES_OK);
>>> status = dev->config->get_status(dev);
>>> if (!(status & VIRTIO_CONFIG_S_FEATURES_OK)) {
>>
>>
>> I think this can work but need to listen from Michael
>
> I don't think Christoph Hellwig will like force_dma_unencrypted()
> in virtio code:
> https://lkml.org/lkml/2020/2/20/630
>
> Regards,
> Halil
>
OK, then back to the first idea.
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2020-06-15 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 13:11 [PATCH] s390: protvirt: virtio: Refuse device without IOMMU Pierre Morel
2020-06-10 13:24 ` Cornelia Huck
2020-06-10 14:37 ` Pierre Morel
2020-06-10 14:53 ` Cornelia Huck
2020-06-10 15:27 ` Pierre Morel
2020-06-10 17:24 ` Halil Pasic
2020-06-11 3:10 ` Jason Wang
2020-06-12 9:21 ` Pierre Morel
2020-06-12 11:38 ` Pierre Morel
2020-06-15 3:01 ` Jason Wang
2020-06-15 10:37 ` Halil Pasic
2020-06-15 11:49 ` Pierre Morel [this message]
2020-06-15 11:50 ` Pierre Morel
2020-06-12 13:45 ` Mauricio Tavares
2020-06-12 15:15 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a236da-7165-b59b-e013-919554fb1ac4@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).