From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751145AbeAOU7n convert rfc822-to-8bit (ORCPT + 1 other); Mon, 15 Jan 2018 15:59:43 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:37081 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750779AbeAOU7m (ORCPT ); Mon, 15 Jan 2018 15:59:42 -0500 From: Loic PALLARDY To: Bjorn Andersson CC: "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , "benjamin.gaignard@linaro.org" Subject: RE: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout by name for carveout allocation Thread-Topic: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout by name for carveout allocation Thread-Index: AQHTafrk86JKX00a1UuIrmMup9VbRKNCVdMAgDNdK1A= Date: Mon, 15 Jan 2018 20:59:39 +0000 Message-ID: <96a72c95bd414095a94681f41637680c@SFHDAG7NODE2.st.com> References: <1512060411-729-1-git-send-email-loic.pallardy@st.com> <1512060411-729-15-git-send-email-loic.pallardy@st.com> <20171214053456.GO17344@builder> In-Reply-To: <20171214053456.GO17344@builder> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.45] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-15_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Thursday, December 14, 2017 6:35 AM > To: Loic PALLARDY > Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; Arnaud POULIQUEN ; > benjamin.gaignard@linaro.org > Subject: Re: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout > by name for carveout allocation > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > + /* By name */ > > + mem = rproc_find_carveout_by_name(rproc, rsc->name); > > + if (mem) { > > + /* > > + * Update resource table with registered carevout > information > > + */ > > + rsc->len = mem->len; > > You should validate that len, da and pa are compatible. Yes you're right, complete definition must be checked Regards, Loic > > > + rsc->da = mem->da; > > + rsc->pa = rproc_va_to_pa(mem->va); > > + /* no need to register as already match one for one */ > > + return 0; > > + } > > Regards, > Bjorn