From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97FBC2D0A8 for ; Mon, 28 Sep 2020 17:26:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A133208D5 for ; Mon, 28 Sep 2020 17:26:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=pensando.io header.i=@pensando.io header.b="0/6i+Lzw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbgI1R0R (ORCPT ); Mon, 28 Sep 2020 13:26:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbgI1R0Q (ORCPT ); Mon, 28 Sep 2020 13:26:16 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E0A2C0613D0 for ; Mon, 28 Sep 2020 10:26:16 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id k8so1676912pfk.2 for ; Mon, 28 Sep 2020 10:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=xu75CUkAEe8YKESDX+6RMXTyhfVPWONUsVk2klTLLIw=; b=0/6i+LzwyathOMbvG6oG2ll/0evYhsEXpg9MB8BFBLC+1GFyqK6z7LlJJBxzxFdfbJ 05TEF7DdGGpuvCMyi2NZv1Q92KQL0cR+D9CHNZcApVdI271h571JbWXG7v8ceUFtVFtf iwjyPFqYKOGDgEmB8LpvoaUN93/ZIPIYVvLAUawMj6Y4rR+hfMhita75OZvkqLyaAvUf xvE+pK94Tr93FIKvvY4r5qpOHmvw3WITNJyYhNThNqO4q29c3wTZYVBQe7Tq8UTIL6k4 0ZHjkrbMpMyKmBmkJEdjYVDtZTHnR2/b6Pa/4fNUCUmKUcc1eo5AP/szp3Nr9ULAH1LL Gszg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=xu75CUkAEe8YKESDX+6RMXTyhfVPWONUsVk2klTLLIw=; b=kLBWc4W3blS8aA+8zM/oB2Z3hLo2PQXrKhgYhk2X3ZdSmiYN/LK0upXfH1YEKk+Bla m+3lB1cKiEWQc5RaALHV3DL+l765JlrXcwLiGe3ARoddOTFpjC1+K/sUJlPj7Ca2WRkh YKOwFJrSB5G9nLQFv8hw/4IAlqWPYx8x8uNBNUsbO3syqsjGRv1/Vj4gxIHxC7eJu0M8 PITqFQ/e2/VZyXH8XviwOFuRlKb3lIYqlBRLJoTfXSKSIGHSPLIA5rCqgMOGSoX4c15E 3tXDvotd8GBAe+mfuznYaCYJM9uXMMPEcM5PDFzv12AD1SwH1FWJrmozzPaiG2/+aCU/ e4qA== X-Gm-Message-State: AOAM533BEZLPUw6ttfIGE11pMoLzjehCk7T3y5sosAi3WDuZoVNiIDy5 8Y+uOLr6aZAi4+xy2NMRlWNlvQ== X-Google-Smtp-Source: ABdhPJzwfjXkCsxEu3XfK2aVP501w1BXp/1/rfPP3H13WpeMSgLae7v91sNjQ8w4DmdYg1Jo2bc1PA== X-Received: by 2002:a63:595a:: with SMTP id j26mr130244pgm.406.1601313975665; Mon, 28 Sep 2020 10:26:15 -0700 (PDT) Received: from Shannons-MacBook-Pro.local (static-50-53-47-17.bvtn.or.frontiernet.net. [50.53.47.17]) by smtp.gmail.com with ESMTPSA id j18sm1986127pgm.30.2020.09.28.10.26.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2020 10:26:15 -0700 (PDT) Subject: Re: [patch 12/35] net: ionic: Remove WARN_ON(in_interrupt()). To: Thomas Gleixner , LKML Cc: Peter Zijlstra , Linus Torvalds , Paul McKenney , Matthew Wilcox , Sebastian Andrzej Siewior , Pensando Drivers , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Jonathan Corbet , Mauro Carvalho Chehab , linux-doc@vger.kernel.org, Luc Van Oostenryck , Jay Cliburn , Chris Snook , Vishal Kulkarni , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, Andrew Lunn , Heiner Kallweit , Russell King , Thomas Bogendoerfer , Solarflare linux maintainers , Edward Cree , Martin Habets , Jon Mason , Daniel Drake , Ulrich Kunitz , Kalle Valo , linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, Greg Kroah-Hartman , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Stanislav Yakovlev , Stanislaw Gruszka , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Jouni Malinen , Amitkumar Karwar , Ganapathi Bhat , Xinming Hu , libertas-dev@lists.infradead.org, Pascal Terjan , Ping-Ke Shih References: <20200927194846.045411263@linutronix.de> <20200927194921.026798214@linutronix.de> From: Shannon Nelson Message-ID: <96baeba9-eb5f-1462-2dcc-ecb9793727a1@pensando.io> Date: Mon, 28 Sep 2020 10:26:10 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200927194921.026798214@linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/27/20 12:48 PM, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > in_interrupt() is ill defined and does not provide what the name > suggests. The usage especially in driver code is deprecated and a tree wide > effort to clean up and consolidate the (ab)usage of in_interrupt() and > related checks is happening. > > In this case the check covers only parts of the contexts in which these > functions cannot be called. It fails to detect preemption or interrupt > disabled invocations. > > As the functions which are invoked from ionic_adminq_post() and > ionic_dev_cmd_wait() contain a broad variety of checks (always enabled or > debug option dependent) which cover all invalid conditions already, there > is no point in having inconsistent warnings in those drivers. > > Just remove them. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Shannon Nelson > Cc: Pensando Drivers > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org Thanks. Acked-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic_main.c | 4 ---- > 1 file changed, 4 deletions(-) > > --- a/drivers/net/ethernet/pensando/ionic/ionic_main.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_main.c > @@ -248,8 +248,6 @@ static int ionic_adminq_post(struct ioni > struct ionic_queue *adminq; > int err = 0; > > - WARN_ON(in_interrupt()); > - > if (!lif->adminqcq) > return -EIO; > > @@ -346,8 +344,6 @@ int ionic_dev_cmd_wait(struct ionic *ion > int done; > int err; > > - WARN_ON(in_interrupt()); > - > /* Wait for dev cmd to complete, retrying if we get EAGAIN, > * but don't wait any longer than max_seconds. > */ >