linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Mike Rapoport <rppt@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Remove default DISCONTIGMEM_MANUAL
Date: Wed, 17 Mar 2021 14:22:42 +0100	[thread overview]
Message-ID: <96c306db-ac18-cf35-76fa-0e122c01bc0f@redhat.com> (raw)
In-Reply-To: <20210312141208.3465520-1-geert@linux-m68k.org>

On 12.03.21 15:12, Geert Uytterhoeven wrote:
> Commit 214496cb18700fd7 ("ia64: make SPARSEMEM default and disable
> DISCONTIGMEM") removed the last enabler of ARCH_DISCONTIGMEM_DEFAULT,
> hence the memory model can no longer default to DISCONTIGMEM_MANUAL.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> DISCONTIGMEM_MANUAL depends on ARCH_DISCONTIGMEM_ENABLE, which in turns
> depends on BROKEN, so probably all discontig memory support can be
> removed, too?
> ---
>   mm/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 24c045b24b95069b..579254f10fb1bac6 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -9,7 +9,6 @@ config SELECT_MEMORY_MODEL
>   choice
>   	prompt "Memory model"
>   	depends on SELECT_MEMORY_MODEL
> -	default DISCONTIGMEM_MANUAL if ARCH_DISCONTIGMEM_DEFAULT
>   	default SPARSEMEM_MANUAL if ARCH_SPARSEMEM_DEFAULT
>   	default FLATMEM_MANUAL
>   	help
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb


      parent reply	other threads:[~2021-03-17 13:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 14:12 [PATCH] mm: Remove default DISCONTIGMEM_MANUAL Geert Uytterhoeven
2021-03-12 19:48 ` Mike Rapoport
2021-03-17 13:22 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96c306db-ac18-cf35-76fa-0e122c01bc0f@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).