From: <Codrin.Ciubotariu@microchip.com>
To: <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <geert@linux-m68k.org>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC
Date: Wed, 13 Oct 2021 08:15:46 +0000 [thread overview]
Message-ID: <96c810cb-f7e3-d9ff-9713-7ec007ebb599@microchip.com> (raw)
In-Reply-To: <20211003030357.32456-1-rdunlap@infradead.org>
On 03.10.2021 06:03, Randy Dunlap wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.
>
> This means that SND_ATMEL_SOC_PDC can depend on HAS_DMA || COMPIE_TEST.
>
> Fixes: 6c5c659dfe3f ("ASoC: atmel: ATMEL drivers don't need HAS_DMA")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: alsa-devel@alsa-project.org
> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> ---
> sound/soc/atmel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20211001.orig/sound/soc/atmel/Kconfig
> +++ linux-next-20211001/sound/soc/atmel/Kconfig
> @@ -11,6 +11,7 @@ if SND_ATMEL_SOC
>
> config SND_ATMEL_SOC_PDC
> bool
> + depends on HAS_DMA || COMPILE_TEST
SND_ATMEL_SOC_PDC compiles fine without HAS_DMA, so I don't understand
the need for this...
next prev parent reply other threads:[~2021-10-13 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 3:03 [PATCH] ASoC: atmel: add COMPILE_TEST for SND_ATMEL_SOC_PDC Randy Dunlap
2021-10-04 7:14 ` Geert Uytterhoeven
2021-10-13 8:15 ` Codrin.Ciubotariu [this message]
2021-10-13 8:40 ` Geert Uytterhoeven
2021-10-13 9:33 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96c810cb-f7e3-d9ff-9713-7ec007ebb599@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).