linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Aditya Pakki <pakki001@umn.edu>, netdev@vger.kernel.org
Cc: Kangjie Lu <kjlu@umn.edu>,
	"David S. Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register
Date: Tue, 17 Dec 2019 22:27:09 +0100	[thread overview]
Message-ID: <96cddfde-f0d9-4186-9e23-fe4285637c0f@web.de> (raw)
In-Reply-To: <20191217210620.29775-1-pakki001@umn.edu>

> The three callers of hdlcdrv_register all pass valid pointers and
> do not fail. The patch eliminates the unnecessary BUG_ON assertion.

I suggest to replace the wording “The patch eliminates” by “Thus delete”
to make it imperative as desired.

Will the tag “Fixes” be added to the final change description?


> ---
>  drivers/net/hamradio/hdlcdrv.c | 2 --

Please replace these triple dashes by a blank line.

Regards,
Markus

  reply	other threads:[~2019-12-17 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 21:06 [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register Aditya Pakki
2019-12-17 21:27 ` Markus Elfring [this message]
2019-12-20  1:34 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96cddfde-f0d9-4186-9e23-fe4285637c0f@web.de \
    --to=markus.elfring@web.de \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kjlu@umn.edu \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pakki001@umn.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).