From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932168AbdCFPWj (ORCPT ); Mon, 6 Mar 2017 10:22:39 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:53896 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753153AbdCFPWO (ORCPT ); Mon, 6 Mar 2017 10:22:14 -0500 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] zram: set physical queue limits to avoid array out of bounds accesses To: Johannes Thumshirn , Minchan Kim , Nitin Gupta References: <20170306102335.9180-1-jthumshirn@suse.de> CC: Christoph Hellwig , Sergey Senozhatsky , Hannes Reinecke , , Linux Block Layer Mailinglist , Linux Kernel Mailinglist From: Jens Axboe Message-ID: <96ed9003-6299-b303-a901-d040a8cfe03f@fb.com> Date: Mon, 6 Mar 2017 08:21:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170306102335.9180-1-jthumshirn@suse.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: MWHPR09CA0030.namprd09.prod.outlook.com (10.173.46.144) To DM5PR15MB1195.namprd15.prod.outlook.com (10.173.209.13) X-MS-Office365-Filtering-Correlation-Id: e6672442-c71d-4f16-40a5-08d464a46e9c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;3:/VvCNaftdDWmsbM0vjEJNc6h0MH4Aatt2Xb1ePc100CBTDSBCdo32jtuydlTd3fMT3MpmYUj+2XQAMcukQMQTupMPjX+JQRBF6yGcdgsGwlhSDZyOTu2/kIDfNWGCDJFc/y2bfr4kvY6SQE6LqR3WAOMhJrAMiTS6jlTqz6aGix0fSVvVW6fiFFq6tYpNN24M1tXq4fobz9EaeJO2Pi7p/HD944mXSmUK/NgcrU3GZPABKYvolXpTK1AkE34QsttuqWkNLQ57wRiCsObUTMHcQ==;25:rWTzN6V89Gc3hVjDHGjQnY8TmghpaziETbdf77GO0mPGeoB+Ixhx0Fzg98HdsxFJ1Y5qwnbVOZMyL72Rrmqaa/gzTAigEIdqA2rIvfwI7jvzByWVxyIC/xDOiB54ExnV0GeRh18ErYavDstUHNucN0QrNkqYIczLNjbqpAzhOgd9Uxf8l22WovcQri1Wzzm8Bw95E0mHcBOcwyAUkuwoR8PqYSU34cUqNKqAfVrb49xrjR3VqX51LCN8FNebJqgloQocCvLXZWqOTKzAwbPehMhghvySElHdhXKlDoHSBAk5HMsbNGXdWILotDklhwFP5vYL6yiSAhSnmzdsUqJdlX7i6ul8RZpuuH3gBsR1PsWFzOFmzaFfg8OJZqhflEp+Dx3CELYjIqyUuCqEQ+412CXQ6bUn2ws48P4h0rh4l7CiSxq9cKhLQVbpIp/V2sXdhH2tXnZFEe/X1HJMtG65sg== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;31:lihsX4NKylVTiBMbl6JvPSV0+e/gMch3c8+DukGxGLPmjAyNlMEtF2jbbl8nC3OuG+4TkrZLfVFPdloaMBvLxZR9JABAW9oQCQTM+RkN/HhPRsPbrL0f7fgT76JVKcxkhn0XE8QeOZbpU6RDcD2o6lie/U2XnVUZHzTNKSp2noKnwrSxLN4iU1O0yAe5RLo4m5igsiidQEi+lGZthAWirJ8OFp8j7t43X9OUp9s0fbJOy+E4HpAFHXbSxu6LdiIwAHyPVvuxhBrih7Rsdphnow==;20:TGurCWuTywE5PHKwKX/FhimymVVP5JyQGEN6XF/Yeucl/WoC48QbvkoY7KKgtINPBU0p7ffWRB6fxQpMEqLO6vBICfl64bGlYTqnJArMZK9UjUhAvpfX3/HLEwiOQNPwE5ENTqm5rcOvDaNm2Y5n/FO0JY+Hr1k8bSykvR2g66WlkzxZWg9V+x+HEJ9xC5Hogk3+JTA2Wr0rWv0M+2QGPT4lYJin2Xm4+HAK04MpcEF3ypz5qO3yGKMwAskAfkcFr423/+VphAttEJmCW4t8JMuUPqS8A9AL20ThYBVfPr46zNUlLSjmq3Y1glK+/LWirjDHaWJsdKqkQjuOnoDF8dryXYADS7clSWm/w2aks/wZyuvebwnYgO65oHrzn0+GToaIOZnXtSu8aVmAk65pT29sJQttw/FnBCs1MG6w4LBIXISNjsJ2CrfO1BHa1c6sapnIhOcw5lvZ1MSsjqYVWTW9/R6qB+nFIvbtHIRh+tLR7CTz0BUql7iAKJsckXPs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123558025)(20161123562025)(20161123555025)(6072148);SRVR:DM5PR15MB1195;BCL:0;PCL:0;RULEID:;SRVR:DM5PR15MB1195; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;4:azQibS85UI0QZsR/8wgi1TL2MdcAatMBDIwZpmuoZIUQwafAX7+eox6C9BNjqe0y+FhjRMZfn/jZ884NfPD8+dLv36HythZwaHZtO1tF10VUaQBoFo4bM3bs/8FcPCW7HtO1z4xiuCsfZdTSGMEYHuWq4qWCM08JIl0mBWxIH+lxStucIEZClTtw1oETdd77vycQ5HWhJ2EZJvoJKRhD70+Ptv/pEe+pSKJTGHP578v/tmSbe+oEhdL4PO1xUz2TTrsQr8aFSSNgDiShAqqJelrW1WjPk3Q873vW9W+AESj5GkwA7BFBiZd+1JHRqqPlCrg181znFIpkxs+KglsKj7Lmm3o9NvW3PstnMmiw/fZePHg5xy3is9NPD51io0ol5pTiFao7eqjXDlJ0Q1VXG9E7wxRkddbn0O/b1Ya5fE6++1AC3bb0HZP4JPAuqn65zHNRpaTKuuzQ/+r9fdM3w33RVOLKm+Ort1QQc3j2Oh1hZg2at7zsGm+rC2Z1qNaVsjpG3zxbEXDTMHd0TWRtxUfXllIc7uBfvu7/+Uq+9OWHCheXq/ELl1ktxIGGqJytzX6zeUXcUsvdDskDNui9rVyLWS93V3EkuMAnngebjEs= X-Forefront-PRVS: 0238AEEDB0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(39450400003)(39830400002)(39410400002)(24454002)(377454003)(65806001)(65956001)(31686004)(54356999)(7736002)(305945005)(42186005)(64126003)(6246003)(66066001)(53936002)(50466002)(53546006)(47776003)(76176999)(50986999)(92566002)(23746002)(38730400002)(36756003)(81166006)(8676002)(2906002)(3846002)(6116002)(4001350100001)(117156001)(33646002)(77096006)(25786008)(31696002)(6486002)(86362001)(54906002)(90366009)(189998001)(2950100002)(230700001)(6666003)(5660300001)(83506001)(65826007)(4326008)(5890100001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1195;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM5PR15MB1195;23:/eWNZmfdvLyPpH440wnJuobVutemCBRJZKYDF?= =?Windows-1252?Q?yqP5w9HAWmzkpcR67+yHCaKEUvWugXsCmVwsZkW3j1LUmRgZZB55ULA2?= =?Windows-1252?Q?XxixrG4bgNKAH2LLKQYtN4tOn82YehulOXLl/3DqL3Mi+UdL6fyDyNXM?= =?Windows-1252?Q?XG/3Mu6cYN4E5EkmsTZODF3zhvEqCCL+dtqMOvOA7we5j+VUCvNe1cby?= =?Windows-1252?Q?LeE2DXczbfKT2ahr98XoxOW7/COKPy6wFKm/8HrjWFLVmkPf0OKcvnsm?= =?Windows-1252?Q?+tkkOgA1nl0XjnxYP9v+kUjIpMcoWn7tgiJEXzgNsqPQscrtj8EnNCD1?= =?Windows-1252?Q?MCEoj/5Fv8aTZXqRPzexyrkq/Te4rfGsyGG2SlWbb4mM8tDjPFtHFs5v?= =?Windows-1252?Q?e0oS3aWRAzKceSUs2aURAdkkQ6GP+H0DuDO5/1k8lbZvhLTU+M6zxTac?= =?Windows-1252?Q?bjJcE8LliD6zo7yL64eo9RbCuIqV9JRcHZMca6qUFQ3vtZU3fCM3sxXF?= =?Windows-1252?Q?X8a/hCvPzA/Q1OhS0GvPHYv7twCYa8yThCpdlNv0R2r+ZAsjKyTViXer?= =?Windows-1252?Q?3te2jsikcG0BR0BoFByAOoTgBtcoRmedKQNRFUcc86Wdxmo3JO6uLPj8?= =?Windows-1252?Q?+S1nncOjODAPNz0c5V7kTrgIDiFN7YI05HR2cKbYh2zOj1PPwIVKJRGg?= =?Windows-1252?Q?SQfYILN3P36H/g2/NdZ2nA11e+ek05gmt2GaCcX+2C0LakgoqDtoQIQU?= =?Windows-1252?Q?YqVQ3l7HXOtOpdip9bnH85mjpwdBKQfzpmBrmq5jPW82IMSaO/+YZb5X?= =?Windows-1252?Q?CWeNmThMnZAZqQ7Dc6VG0fblOh7laHrO8nkTnmHeFbASXfjh/RUQ/HmA?= =?Windows-1252?Q?E28VYMfaEEV36ZYajsFHX4BWzdylISLCvRJryrSCePBYc3q9tnda//1l?= =?Windows-1252?Q?0CGC8aCNLL66J/dzE6ABZv3sgYamx0wHObu0SJPg/19MpVG/e8dLBkwL?= =?Windows-1252?Q?r5SyUJQ8qTZeP+Xg0FT4CaBawAJ5GgdU1uPOstef37hV1j3emii6aY02?= =?Windows-1252?Q?/yDGZ4RTMfmJw7rKmdbRJJEeSM0FJHyi8i9UVS7JBSoRVPxjOwBMK4lv?= =?Windows-1252?Q?MQohLiEHFt8j1N6tP6Txr24GqERIms5XXIIl1tLUQ2iJgTRwUFdo+UZL?= =?Windows-1252?Q?zRKaIg3T/U691GZ0BzesmWZGj3Q75GfjbI96kDH4mz14PMabe5XBG/Cw?= =?Windows-1252?Q?2jl3O57ghyA2CxSvjnqWTD+I7Febp9ZeZRqY1r2eTapXBM5tFnXaMDs4?= =?Windows-1252?Q?cpF17TQ42CSwoajw9GgsX/zUDKL5SFe4/r2tmt+OotYbf4LJAdkInul9?= =?Windows-1252?Q?Av8PYFitWswVN9k+LRCR7tDJTPm6pRXBQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;6:gJMzrsOaUM+1+/1JkxwQkRmMgG35u9/D2eoQk3jzlINCkdS1viVmcjLkUIhNOqkYW4hRNpCDjB69e8ESTFL4F5YJYikqFo3TlQ+CmnvtwQVI3HdWlqAO8ivES7v2HA7fwmeotb2LOosWecfnotgKSoJs4g0btGXTdloy6Ne2u2auY60Pdy84Ae08WXscTxN5AtS2QKdPmANT0JMUrhR0DqRaFg6Of2nd8et6WrUQkVdRCV9LNx01QNK22S3820DVEUqMpT0nz+1wlNE3RlMuYle1Q3AFc6egsqfljUAjKjunHeTxBd/Y1cHGNXy12GMkT0JDUOstFRrhGmp7DjC0O2P9LaN2EAN++t3OHh9h+LbnQOfCqHUqQi2jFy029gFykEEYH9Z3xmWAzBjp08R6IA==;5:jrjRXBTEpIL8dY9im0NAflJ4QMvyPk92oego9+ePc0V2/9MemY/d0DcC9sfJW8B6ZZi3clGeOSo3gBjKKMiPx06f5JJ2JfpRCCCxWqAhsg1Ju46HEm+YnZIci9oevK69+aMYps66/l3yPwU3XphGuA==;24:HkcmLt/Oujw3xF/HhASWFxE0W1GzTFxW5zJ9NZXtXIDFEzsRWHgT1TuqWC5ndUJQ9vWV4Wwi7zl8S0Uk647F3K1mACHh3Y8DzKHRrlVs+bk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1195;7:/IffPDW11KOrgMiiQz+UgCCJc2JBs79a2Ij1NaLMtSBZnK81s8wqJcll2xeMJLK/+4ogdgY5+X2NHhZpMwdWKKIALhvvktVco3PZhb5HZWSJFQPL3E5hdkcDEzh38O3PzYMcJwVVCfTs5xpCOCrw2IUYzZKtraHkk0Di+myZqgEKyAuE/VSwbnuPB94YqJ6YKziFjqXKHAZDjRWhUreR7jGtra8krwJFrdIeMrjVhNQV0HI+U8QqhvKxAhgsvUEFhAyGd9GsCFKwMBVm6AG91rCcYVtfeHvyGN9EZznzp4+WOxh0+RTJWXTSG5SDsvaUstjErVZWzQ4YxXQDeyPgKw==;20:TWR1EBctqnqKOvLb/ZGFMsx4wbaRh+1GIu5C8PmIJ04UCo+yPdnSZeuOLaL8LtjtrOX55L7pFR5d97DweikCGLyWVK0q4sQ1y0kCvHk566au/t9C8hM2g2sP5HQ0QwSCkIE8LbDI4PSS/K4GIL5efz2nMdcE43mYIpqfq2WScbU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2017 15:21:14.4838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1195 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-06_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2017 03:23 AM, Johannes Thumshirn wrote: > zram can handle at most SECTORS_PER_PAGE sectors in a bio's bvec. When using > the NVMe over Fabrics loopback target which potentially sends a huge bulk of > pages attached to the bio's bvec this results in a kernel panic because of > array out of bounds accesses in zram_decompress_page(). Applied, thanks. -- Jens Axboe