From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757397AbdDRQYY (ORCPT ); Tue, 18 Apr 2017 12:24:24 -0400 Received: from mail-bn3nam01on0049.outbound.protection.outlook.com ([104.47.33.49]:35264 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753841AbdDRQYO (ORCPT ); Tue, 18 Apr 2017 12:24:14 -0400 Authentication-Results: queued.net; dkim=none (message not signed) header.d=none;queued.net; dmarc=none action=none header.from=ADLINKtech.com; From: Jens Rottmann Subject: Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/ To: Thomas Gleixner , David Howells References: <149141141298.29162.5612793122429261720.stgit@warthog.procyon.org.uk> <149141145858.29162.13072730133817038218.stgit@warthog.procyon.org.uk> CC: LKML , , , Daniel Lezcano , , , Andres Salomon Message-ID: <96f4b1b3-636b-51c1-53d4-c3c3cd330dce@ADLINKtech.com> Date: Tue, 18 Apr 2017 18:24:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [5.158.151.28] X-ClientProxiedBy: AM5PR0701CA0015.eurprd07.prod.outlook.com (10.168.161.25) To BY2PR0501MB2054.namprd05.prod.outlook.com (10.163.197.29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 483ef7b7-bd90-437a-a975-08d486775918 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BY2PR0501MB2054; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0501MB2054;3:2vjA7Fku5f6kjAhvLkBF+uCX9D0XwMwb/jA/ftTn7H+SO5P38ZWlS59wCQ5+S1zsbisoJY2qksX8+X2WBnqz3kP7ST/PIOkSLUeJ884Y/G2uJmT9yRMVeZCWweKSiXF/98z9RMcqqQg05EP1+FE91S+geaXqy07oRgrqUbZp56Ki3DojEJu+hEqZ2A1yGxrdM8WpzoHbgkTquoS9LwzFxS6BOS0DorLITx+wd3uNAo0oCUlqCmkEcU+9NiUK43I4INFc3aFrV3iLZCKgjQUPPehPKcxx2ZRquqU7EXOfF88F0xcvN02Bfl9+Dsc6Gpu35ZGTfOUMxri52SYv6bj62A==;25:Ve7v5U/O1JB8tQTj6qWCnVEOgQ/Lup9QIwM6KiqlL4ba5U1Vnu2bpgij59HDkJoJfL5bJZoqiWQljfUim7MGye8LT6kweO+sk+ecz7Di3pzbgP9y8d8GHkcbW/USkjhn9hKgSvpycG1Sh1T9A1uBDAgpPjyngCQUrzT8kHJ6ZeUZZeZ6cBGWWwEvIbeS9Vhg8gmqHhggzp9U79FDOTGcnf0ADNmykfR1WvwCatKUtmVuKrHo5sr3aOFZcTu08ntSvbOx5Ihg1G5AjiVEcYmjxRWnQvFklA4X7KOtP2FClpZbsZurnb3zDsWAKpfcQ8divmKy649g7mV9yousvRyCQfFSf8zWx05Mtcf7MyFc6F50DS82UeaGhraJDKtmiMx0LqjSYmfSYoS3+XEiIMDokWxP35vlKMocDpTktWIedaHOMzBNKWWRf766Tk5QjcCCtysFm5MeBwP2Uga0uOoQxxlDWm8MMuwcefi86cHNaUc= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0501MB2054;31:JuVqexM9OptqpEk5WqnodqnZA4dD4ftr/c4fMzJPQ81h6gHYn6z968D9Bc24xB1fveW8GF7Zkm+JkNmaSwvHQHcRdbS5AC3wIOf1ak/vGXjuokK2Uve9y8xF102QFHDJmeM10pi7SUw+81y/S3pMwQad/pF9r1fwbf33jrcXxoz+FSxGQI3NnTMIHDzD8xqN4cUn+f/5fz6BYs/nI45nutO+dyl6PeED8pT2P5GV6Xm7XnewlHc+hFgd78Qu6BDndL0wgsia6YTSC7YTKNak0EQa10sM+7myalVaMFYXy9g=;20:oJY1zQ5K0thUnY8Z99FJBz024OEVZcUBgSB1mFJUlY/W5foe3bQ5gojETQGwqcK5n1m/pSvH5Wkf6VCf2u0oFiYF6R7p6NQg+rbfruVMKKfMYlAXKoAjCqquCsDkG23Ag52TPM6NSF9DBuvFqeGFDl4WI+IAVg/hZR5tdQ825mLfY2Wsh+57x2QoR9Uk6HSgdYHcv6lpy/f7HAbPcgXUuFjkXmcNc760/j4+gmatmcpEdmGGSWIO3C9NvSwdmqvSeY/mxkB2TcY7gSRsGLE89fbEzVpzcKChFKcxAN02asYJRPc8fUPEUw3kFJlE/aOkBX8FHshm1C65HWzXVSXiExS98jCltpH8MYJxz6o4wkaZ+xRgD34W/uMG0C7VKsWXCLcJI3HwRkvJJPEZIu3W3V2F0WhvQWazouFkpk7pLPCb/EMxpgJLohqXWElhIG9wSsSlE/Lp59TuXluptUJw+V0tHdXOue7l5Q7lR9AIsrP4jjK4heIeSYGN0SGg0bTcO5Ea/66vVYdkXq5f6wPnIzrxDaWQpcXO+KyFnf40Pnk/wKlayTVfcF31gIccPnW8GgE29aY8qQtRmjhjc6pLyCZSfehPCt2gkYKdZn9Nw34= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:BY2PR0501MB2054;BCL:0;PCL:0;RULEID:;SRVR:BY2PR0501MB2054; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0501MB2054;4:q6BFgd3pW34vjfSGULwVPPRJLH3nEEU//Z17VMWeKVxrbe344cXiJFu3anow8RezEwqY6ss8plItCUfGp3bFVLVb2R9MW7I5qRivewofSj+NcYhAnQqJxrDW0ale0nZO/zgM9Nh5EgaClSQGgEdrlOqEIg2/qSs7JeWZdoi4hKn3TMx/IJ7EZe0R6M9IGctWZlD9xJm2BB2ORZIYZnxPzbLaxEUwMuG7cn5oTqyzkAsdiojmJw3a4ue9op6NFeDqv+DtMiQam958s7tBCMH8uTI9XqYKBPakbjiqvmD2oPI12T6NQvk7YLSb5pklFF5p3NRE9hqkPLK9qKGeBMbZsKdL4dNgEFvbVtH3Ha3nYgb5qt71ituyPmdv9/DHcmofC+TyB3xnmCNCoD1AutWK6cUrklppTsINO0RN9XYi4/JvKUysei4/4SGoHqBXPWPnou0/J6sJF13bZFGyfza7TFDI5kf+nhoPtxIaVVWNWUPh/CIswQJ9ArLNNypwocWn/Pj6JuFZz8Epy1KkwlFd+lpoA0j2Vxx/iwetvZ6O0qRxh6DtCssD4YoW98CNt8HD7zN2yqyDxTrvDKXtdTSpri7zDGPfoUr+aZLnLuStoWxrEG7SINaYhKgIFpxt6yoBhiF2o+O8NR3OQ15VhpJRqrx0+9L3z8yWmtpBuyfK+GSGG63SOfmXzPYFvZsa1ntaq6eqjTQnrNeD9X7fQjs80X0WhUZn5NTSM7hf3erlC+4= X-Forefront-PRVS: 028166BF91 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39840400002)(39450400003)(39410400002)(39400400002)(24454002)(76176999)(77096006)(53936002)(6246003)(25786009)(53546009)(54906002)(90366009)(6486002)(6666003)(38730400002)(31686004)(117156002)(50986999)(54356999)(4001350100001)(71446004)(64126003)(23676002)(50466002)(189998001)(66066001)(36756003)(42186005)(5660300001)(305945005)(83506001)(31696002)(33646002)(2906002)(2950100002)(229853002)(4326008)(81166006)(8676002)(86362001)(230700001)(47776003)(3846002)(6116002)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0501MB2054;H:[192.168.49.181];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjA1MDFNQjIwNTQ7MjM6RTFDRUxSRWRvbnY1SWJuWUlIeEl2NFZK?= =?utf-8?B?WkJHbXdLSEE3SU1RRXlBMnJqREJ1c0hxd2VtVC9jQTJwMzAyWnRpVVp6Y0tZ?= =?utf-8?B?OEFsSVdpd3kxS0lGOVNsT1Mxd2R2eDF5blVrWUxISHFBeUFySVJtZW1aUEph?= =?utf-8?B?TXdwSUdOWGN1SmV3ejU0a1FTeFduNXNXYmM2MVhlUzBpNFhxNkQyOXhIRlIv?= =?utf-8?B?cU83QU9sSkhZZU52OWNjeWVCZzZqTDJObzNBUjZiNWZQU1dFbjVJRWpBdFNy?= =?utf-8?B?UU1VU0JKcU1OUkE0Zmp0cHRFbUpla0hyQUxxOGVJY0U5K0YxT2M4Z1hCdmJr?= =?utf-8?B?aHBhU2oyMUwvMkJnNWlBUkVrT2JObEZKTHRHUVRLYWZZU0dLdkJQU1MvOXps?= =?utf-8?B?UnBDajdoQVVSZHhCRE9MT0ZQcm5RVFRjYnVDUWxuV1NkNU1PMEM0VEJIb2ZG?= =?utf-8?B?UUU4cE1NY2ZYQXFkWGRBcHNFdkFsOXZWQXcwWU5RVXFOalRsUFFMWlpYTDQw?= =?utf-8?B?ZGR2dmJQNSs2RUtuTjRPVkFFWURFU0cwQUtVdS9KNEpVc29FL2RWNHZqNTc2?= =?utf-8?B?SzNiQ1pZVEFtQUV4WW9DRGdQTUxYYkk4b29vZ1QxeFVnbTJlWmtiM1EzQ1kr?= =?utf-8?B?QUdHRHg0eHZXK2V6blQyTU4wVXF1MmZLOE9SZGJHYUlqdmRMSUhwK3p1d0Rl?= =?utf-8?B?NkN0bTYxanFGR3dUcGVOSEkzOHNERW1IeFByOVNVbVc3c1dHdTUyeEZZejQr?= =?utf-8?B?TDBTaytjOEE2d3k2Z3J5ZEI1eW9FdVhyRW1zQzcydVBRNFIyMk9ZbDJXazMy?= =?utf-8?B?NHBVc2d2YXRJd1Z0cTV1cXBnTW1nVEFjZVhWSW1IeG9lcHUyMHZhTlFnRnV2?= =?utf-8?B?VHp2S2VDaWh2NnhjMi9NcDRqSElxUFJxT3FRbFVFaEtrQ0NqdjdpU1U3bzZO?= =?utf-8?B?MHJHb1VVSjJCQkgxUTlOTjJyMTB3R256TE5KYXlkbi91a3Fva1EvOGxpNm8z?= =?utf-8?B?SEFRV3Rhb1VQKzFQaFBDUWNMdDZ1Rm1teFhxUzdCSGFwTzZEZWZaUFNZL0ZT?= =?utf-8?B?STc5MU0weEplUGRtemJyQ0pXQW1BcjNYNjhUbHlPd0R3UFZxUjRNbkQyRWcz?= =?utf-8?B?cjVhRk5ad2pwbG1QalJOM1pvV05uOTVMeHNkc0FHNHNidGdaUm9LMDZuUjZZ?= =?utf-8?B?U09RdTJVQk1rNGoxVzY0RkNYanRFRzd1dzBmNTg0cVFBMFJ2ZndXbTVzMFpH?= =?utf-8?B?UzN3UDZGVVNCTWkyK1Z1cDFSNHVBek1zb3pqZXhUMFU0NlR6aVpnbENBdElu?= =?utf-8?B?S0tITCswN3NON0owYTBwN2ZMbmdDcEVKaEpkUmdyc2JRYldIS1Mwdk1NZExv?= =?utf-8?B?L01QMW5QdGtlNEFObDhZMEMvSWM2SjVzU01INnBNMkVoaHAzTVFxQzQvTGhQ?= =?utf-8?B?VDZPK0lVQ2tKWWJJK0tTMmtSN1hDNmZwandrMEFQWkI2WFAxRW02RnEya0M2?= =?utf-8?B?dmNFc1YyclN6aVdjVDRibGs1MEsvalNnTHNJV0xyRy8wVkhKRE51MVMzOXRF?= =?utf-8?B?Z2RZeUdBMFZZbEN1ZVBZa056N0g3RENvdDVFWERxSWplUHFvejVTdnp0b2dj?= =?utf-8?Q?rORUl96eELUgvKE1vZ0Rmn?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0501MB2054;6:QG0HbLoBy6ljU7kb8zSc2oDjaOyPIJgpOY6Va3iudCRs5HZ+uuPpARYZvX8FWWElcCQC/T8EIFC00g2ChIdEaWD/2b7DAVBPVrE3w9SOnczb0dTrj0OOeeAIkpUgggtDG7PnHLExpu07D9Od0W/8/dJViAy/hMaXprmecIfGfN4Iar+j2v/kzcMi0g5qJ1gbWP8GL4oYtNsEdX3DuzYEKXFuAwDsKS8Y0nW9sSKpwSm1fiOOztuXqBUv/Jfpe0GWrjeydUoQjuigkRALa3RJUAaUwR/N9t70nlErK+ZOZ1r49mo6ChfI+oL7NzXO3J5nmsgQK33t/1YHMPbqLOIb05ODwsuYCshsLL2ifeir+bM1Y+m4SCCGPMfWKnJVFmJ4iTpqEkbBV0A8fPN4cO7i9Ly41js3ccrprNz4kRcxdEeRYqcDYqa3VMZMBhZOJQkrFud0jLceZrt2v/n5xkWyriWn/cu098U8FBagVrRxnQV/DDhU65BDBQLqcpQQal+Q3YvwS24vHdxY/VNfwqhM4A==;5:tPR3jUIUA1KLQE9wY3NAwTIdgBcJWSAgddWlPvmFVsVRmyJJ744Ta9sUtjm22W85JNcbDVpPPSNVanND+epRh1HnrhbFni0s9p59NEkZ7c6Q8vk/Z0cDqTwP4mzOSQKCFtUezaK/NiBF1enarR1g8lCO4y55e8SbYadH0dDz2Ac=;24:vMU9CNeGcVKXwzUauPraDc7qmf1Q+tF0MQICWgyWzrRSZMOZ4VvLqJZln37t/69VrMlTA93XyBMQ9HVZVTeS1AMXhagDjCrvj/R4/4YIYpE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR0501MB2054;7:jcuqCtV2WL6gCb8xf2LbCygLbBMqjvzMfBjQRqmv8Td+MctOD7BHdn7Q/55Hfye2p/d5x0QflRq4Od6qOAocNUJVfdCW+iltkNVVBJ02CX8gQayLoamrI2HaV7wK9t6adxNj8TEgorBtL8OtwtLFc1G4Br+Jma4IsEjKafjXKQRL4HymvibNs409XCpxFQUpv3dxsxn0Hpjvt6ehJBZ34NkZwwLb7UkjQ0ZNJsP+Eu5bzHJHM+CZLrGD+LmXGMlhcjKu9Zu+ceIlyUDpyAVmTNdGBukiiFfPn6wjayAmBpd/T93IY85ROuxbrc4VLESD4IVhVGrmcryzXE7YCRWq6w== X-OriginatorOrg: adlinktech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2017 16:24:10.2335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0501MB2054 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/14/2017 20:25, Thomas Gleixner wrote: >> static int timer_irq; >> -module_param_named(irq, timer_irq, int, 0644); >> +module_param_hw_named(irq, timer_irq, int, irq, 0644); >> MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks."); > > I'm not sure about this. AFAIR the parameter is required to work on > anything else than some arbitrary hardware which has it mapped to 0. Parameter defaults to 0, which means: 1. autodetect (=keep IRQ BIOS has set up) 2. if that fails use CONFIG_CS5535_MFGPT_DEFAULT_IRQ (see drivers/misc/cs5535-mfgpt.c: cs5535_mfgpt_set_irq()) Autodetect works fine for our (ex-LiPPERT, now ADLINK) COTS boards: Linux auto-uses IRQ chosen in BIOS Setup. Wouldn't know about other companies, of course, but (2.) means parameter can be avoided via make menuconfig. On 04/15/2017 00:59, David Howells wrote: > Should it then be set through in-kernel platform initialisation > since the AMD Geode is an embedded chip? Don't know what each and every of our COTS customers is doing, but I'm not aware of anyone having written a platform driver. AFAIK many are running pretty standard distros, e.g. Debian. I happen to have booted Slackware with a vanilla kernel only a few hours ago. Cheers, Jens