From: Matthias Brugger <matthias.bgg@gmail.com>
To: Armando Miraglia <arma2ff0@gmail.com>, Stefan Roese <sr@denx.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Neil Brown <neil@brown.name>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Sankalp Negi <sankalpnegi2310@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c
Date: Thu, 14 Mar 2019 14:14:34 +0100 [thread overview]
Message-ID: <96fb1765-971b-2329-bccd-88e0517f6f23@gmail.com> (raw)
In-Reply-To: <CAOcbMd3tfFiVjvPE+mvCjP22-a6oY2LJRig05PJPRAL4DvpCMA@mail.gmail.com>
On 14/03/2019 12:37, Armando Miraglia wrote:
> Absolutely!
Please don't top post :)
>
> Cheers,
> A.
>
> On Thu, Mar 14, 2019 at 12:36 PM Stefan Roese <sr@denx.de> wrote:
[...]
>>
>> Would it be possible for you to wait a bit with this minor cleanup?
>> As I'm preparing a patch to move this driver out of staging right
>> now. You can definitely follow-up with your cleanup, once this move
>> is done. Otherwise the move might be delayed even more.
>>
Hm but shouldn't style issues be a criteria for not accepting a move out of
staging? I think so. You could add Armandos patch in your series or rebase your
series against Greg's tree, once he took the clean-up. Normally Greg is
incredibly fast :)
Regards,
Matthias
next prev parent reply other threads:[~2019-03-14 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 12:24 [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c Armando Miraglia
2019-03-13 12:28 ` Matthias Brugger
2019-03-13 12:31 ` Armando Miraglia
2019-03-13 16:34 ` Chuanhong Guo
2019-03-13 16:46 ` Matthias Brugger
2019-03-13 16:54 ` Stefan Roese
2019-03-13 22:14 ` NeilBrown
2019-03-14 2:26 ` Chuanhong Guo
2019-03-14 2:36 ` NeilBrown
2019-03-13 12:34 ` Dan Carpenter
2019-03-13 16:47 ` Matthias Brugger
2019-03-14 11:13 ` Armando Miraglia
2019-03-14 11:27 ` Dan Carpenter
2019-03-14 14:07 ` Jean Delvare
2019-03-14 20:50 ` Joe Perches
2019-03-14 11:36 ` Stefan Roese
2019-03-14 11:37 ` Armando Miraglia
2019-03-14 13:14 ` Matthias Brugger [this message]
2019-03-14 13:24 ` Stefan Roese
2019-03-14 17:01 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96fb1765-971b-2329-bccd-88e0517f6f23@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arma2ff0@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=neil@brown.name \
--cc=sankalpnegi2310@gmail.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).