From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760066AbYG1Vnp (ORCPT ); Mon, 28 Jul 2008 17:43:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755292AbYG1Vnh (ORCPT ); Mon, 28 Jul 2008 17:43:37 -0400 Received: from relay04.mail-hub.dodo.com.au ([123.2.6.239]:40790 "EHLO relay04.mail-hub.dodo.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752961AbYG1Vnh (ORCPT ); Mon, 28 Jul 2008 17:43:37 -0400 From: Grant Coady To: "Robert P. J. Day" Cc: Randy Dunlap , Calvin Walton , Linux Kernel Mailing List , Andrew Morton Subject: Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediately unselectable. Date: Tue, 29 Jul 2008 07:43:09 +1000 Organization: http://bugsplatter.mine.nu/ Reply-To: Grant Coady Message-ID: <96fs84tsi8ie67bhmnqkb8js2jnv1o4ouo@4ax.com> References: <20080726094718.b617c1e7.randy.dunlap@oracle.com> <1217214689.22927.3.camel@zem.phub.net.cable.rogers.com> <20080728103731.7bafd577.randy.dunlap@oracle.com> In-Reply-To: X-Mailer: Forte Agent 2.0/32.652 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Jul 2008 14:42:47 -0400 (EDT), "Robert P. J. Day" wrote: >On Mon, 28 Jul 2008, Randy Dunlap wrote: > >> > yes, it's nitpicking but, as it's laid out right now, it's >> > unnecessarily confusing and inconsistent. but i don't know if >> > there's a trivial fix for it. >> >> Yes, I'd call MSDOS partitions basic, not Advanced, and then put all >> others under an Advanced menu that can be toggled on/off easily with >> menuconfig. >> >> Not quite trivial, but not messy either. >> >> Patch below. Comments? > >... patch snipped ... > > i suspect that's as good as it's going to get, but it's unfortunate >that it adds yet another level of submenu under "Partition types." >personally, i was pondering a top level submenu entry of "Advanced >partition types" in which the (non-advanced) MSDOS partition support >was yanked out of there *entirely*. > > it strikes me that, at least on x86, MSDOS partition support is so >fundamental that it should take work for someone to turn it *off*. >perhaps simply have it on by default, and force someone to go under >"Configure standard kernel features (for small systems)" >(CONFIG_EMBEDDED) to make it go away? > > seriously, how often is someone going to build a kernel for x86 and >not need MSDOS partition support? just curious. I've been compiling msdos support as modules for ages, and I have one x86 machine here that hasn't referenced an msdos filesystem for over four years ;) Grant.