linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Jim Mattson" <jmattson@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending
Date: Fri, 24 Aug 2018 13:37:42 -0700	[thread overview]
Message-ID: <97047d0e-cfbb-8c23-a0d3-62bcb92a56c4@oracle.com> (raw)
In-Reply-To: <20180823162424.13282-1-vkuznets@redhat.com>



On 08/23/2018 09:24 AM, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>   arch/x86/kvm/vmx.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
>   	    check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
>   		return -EINVAL;
>   
> -	if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> -		vmx->nested.nested_run_pending = 1;
> -
>   	vmx->nested.dirty_vmcs12 = true;
>   	ret = enter_vmx_non_root_mode(vcpu, NULL);
>   	if (ret)
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>

      parent reply	other threads:[~2018-08-24 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 16:24 [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Vitaly Kuznetsov
2018-08-23 16:26 ` Paolo Bonzini
2018-08-23 20:50   ` Jim Mattson
2018-08-23 16:38 ` Eduardo Valentin
2018-08-24 20:37 ` Krish Sadhukhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97047d0e-cfbb-8c23-a0d3-62bcb92a56c4@oracle.com \
    --to=krish.sadhukhan@oracle.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).