From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90058C0044C for ; Wed, 7 Nov 2018 22:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AA6220882 for ; Wed, 7 Nov 2018 22:23:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AA6220882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbeKHH4P (ORCPT ); Thu, 8 Nov 2018 02:56:15 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36598 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbeKHH4O (ORCPT ); Thu, 8 Nov 2018 02:56:14 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wA7ME6A7083965 for ; Wed, 7 Nov 2018 17:23:48 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2nm5h5fqdv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 07 Nov 2018 17:23:48 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Nov 2018 22:23:46 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 7 Nov 2018 22:23:43 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id wA7MNfOI53936312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 7 Nov 2018 22:23:41 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6196C42045; Wed, 7 Nov 2018 22:23:41 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C753A42041; Wed, 7 Nov 2018 22:23:40 +0000 (GMT) Received: from [9.145.168.249] (unknown [9.145.168.249]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 7 Nov 2018 22:23:40 +0000 (GMT) Reply-To: pmorel@linux.ibm.com Subject: Re: [PATCH v1 4/7] vfio: ap: AP Queue Interrupt Control VFIO ioctl calls To: Cornelia Huck Cc: borntraeger@de.ibm.com, alex.williamson@redhat.com, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, frankja@linux.ibm.com, akrowiak@linux.ibm.com, pasic@linux.ibm.com, david@redhat.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, freude@linux.ibm.com, mimu@linux.ibm.com References: <1541009577-29656-1-git-send-email-pmorel@linux.ibm.com> <1541009577-29656-5-git-send-email-pmorel@linux.ibm.com> <20181107104624.36707cca.cohuck@redhat.com> From: Pierre Morel Date: Wed, 7 Nov 2018 23:23:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181107104624.36707cca.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18110722-0028-0000-0000-0000031665CF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18110722-0029-0000-0000-000023D2B5E0 Message-Id: <97094e1c-f74c-7b90-8439-5177301d3189@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-11-07_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1811070197 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2018 10:46, Cornelia Huck wrote: > On Wed, 31 Oct 2018 19:12:54 +0100 > Pierre Morel wrote: > >> This is the implementation of the VFIO ioctl calls to handle >> the AQIC interception and use GISA to handle interrupts. >> >> Signed-off-by: Pierre Morel >> --- >> drivers/s390/crypto/vfio_ap_ops.c | 95 +++++++++++++++++++++++++++++++ >> 1 file changed, 95 insertions(+) >> >> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c >> index 272ef427dcc0..f68102163bf4 100644 >> --- a/drivers/s390/crypto/vfio_ap_ops.c >> +++ b/drivers/s390/crypto/vfio_ap_ops.c >> @@ -895,12 +895,107 @@ static int vfio_ap_mdev_get_device_info(unsigned long arg) >> return copy_to_user((void __user *)arg, &info, minsz); >> } >> >> +static int ap_ioctl_setirq(struct ap_matrix_mdev *matrix_mdev, >> + struct vfio_ap_aqic *parm) >> +{ >> + struct aqic_gisa aqic_gisa = reg2aqic(0); >> + struct kvm_s390_gisa *gisa = matrix_mdev->kvm->arch.gisa; >> + struct ap_status ap_status = reg2status(0); >> + unsigned long p; >> + int ret = -1; >> + int apqn; >> + uint32_t gd; >> + >> + apqn = (int)(parm->cmd & 0xffff); > > It seems you always use cmd & 0xffff only. What if there is other stuff > in the remaining bits of cmd? Do you plan to ignore it in any case, or > should you actively check that there is nothing in it? > I do not think that the ioctl interface should reflect the hardware interface. The ioctl interface ignores the remaining bits. We ignore the FC because we obviously want to make a AQIC FC=3 We ignore the T bit. But we receive the information from the intercepting software, i.e. QEMU which should I think do the checks before using the ioctl interface. It seemed easier to me to pass the complete registers and to ignore some bits in them. In case we get any change in the future But we could also only pass the APQN -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany