From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248DDC2D0BF for ; Mon, 16 Dec 2019 13:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED3E6206CB for ; Mon, 16 Dec 2019 13:25:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fCNqMrJZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727894AbfLPNZd (ORCPT ); Mon, 16 Dec 2019 08:25:33 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:39916 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727841AbfLPNZc (ORCPT ); Mon, 16 Dec 2019 08:25:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576502730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uRdDoSIR5AtO5m9cdoh24W2ysjI5Q/CXritZrr/9PAw=; b=fCNqMrJZPdP3HYb3HZu+81uAQyJNJFZAxZgK37lz0VdRCzdWH7+NIRFPKLCOIqi9q9aeCz 5ORbtduwya1f4bArXrYzFnZHa9o7AYsPWkss/u39zZqxzDpMgB9TYCF4tKsTmGsVAYJXZa ycEYBzpEhToe6k2OPFzwdxy5819SyGY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-8jD3R3vlOoy4Ge0Luq8-sg-1; Mon, 16 Dec 2019 08:25:28 -0500 X-MC-Unique: 8jD3R3vlOoy4Ge0Luq8-sg-1 Received: by mail-wm1-f69.google.com with SMTP id q26so1017786wmq.8 for ; Mon, 16 Dec 2019 05:25:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uRdDoSIR5AtO5m9cdoh24W2ysjI5Q/CXritZrr/9PAw=; b=dLP/JoRnSRw8Y58DtvARCxB23YK8RuPCJCa2HFAg+3YnMOcqcKQ70hZQ5rCb0e9phB SPaENs2kOcdVfmpcTBK9yEloKTqnccU7fc63Qjoq6+lj1PeRF3HlqREL3cYKS+AeoiJB tCBaqNHoN4Hfot//DPkAQWfZWmkXBI4fJh23NoC4gn1OxVqs2CHP6UtcHjqwof2hzset A0XrRjN8DGxz+QSzjwzeUnDeWbAI1YhqF3HumLXj5b1qg8q3e7zeARE3eOEHQebZTA0o AxGDSlSvLQReTpaNJMryxI1k7OM5I6yVaQWGRB89Wi8Ic9UlD60nUSO43w+3FJWEl6+b czaA== X-Gm-Message-State: APjAAAVcuFY6fp/dU1qTBkrhAQ1CxlKlPzAtGcVuWDvpVZf7n/2GOZot R7vA1ixLckERGJ3PVEU09vdYT+IAh5/Dkd8Sn1gPBrf68UNBYQ7kKxBqRnqetq/mlGOH2d4/Gk1 hSeAYwEKDSWjcEFfuJGpZ0qIa X-Received: by 2002:a5d:62d0:: with SMTP id o16mr29618644wrv.197.1576502727647; Mon, 16 Dec 2019 05:25:27 -0800 (PST) X-Google-Smtp-Source: APXvYqw4OV/uMjHjWFkzOaNCoPh9pj0FgIpenm2MmRU4IcHuC2XwF2EWIH1IgvkhnbCC8jhwu7H/vw== X-Received: by 2002:a5d:62d0:: with SMTP id o16mr29618624wrv.197.1576502727472; Mon, 16 Dec 2019 05:25:27 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id m3sm21622971wrs.53.2019.12.16.05.25.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 05:25:26 -0800 (PST) Subject: Re: [PATCH 0/5] drm/i915/dsi: Control panel and backlight enable GPIOs from VBT To: Linus Walleij Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Lee Jones , intel-gfx , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" References: <20191215163810.52356-1-hdegoede@redhat.com> <1474a983-3e22-d59b-255a-edd3a41f0967@redhat.com> From: Hans de Goede Message-ID: <970de91d-5678-1771-3816-bdff8e7e336f@redhat.com> Date: Mon, 16 Dec 2019 14:25:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 16-12-2019 13:16, Linus Walleij wrote: > On Mon, Dec 16, 2019 at 12:11 PM Hans de Goede wrote: > >> Ugh, taking one last look at the "pinctrl: Export pinctrl_unregister_mappings" >> patch it is no good, sorry. > > Ooops! > >> Linus, can you please drop this from your -next ? > > Sure, done. > >> So I see 2 options: >> 1) Add an orig_map member to maps_node and use that in the comparison, >> this is IMHO somewhat ugly >> >> 2) Add a new pinctrl_register_mappings_no_dup helper and document in >> pinctrl_unregister_mappings kdoc that it can only be used together >> with the no_dup variant. >> >> I believe that 2 is by far the best option. Linus do you agree or >> do you have any other suggestions? > > What about (3) look for all calls to pinctrl_register_mappings() > in the kernel. > > Hey it is 2 places in total: > arch/arm/mach-u300/core.c: pinctrl_register_mappings(u300_pinmux_map, > drivers/pinctrl/cirrus/pinctrl-madera-core.c: ret = > pinctrl_register_mappings(pdata->gpio_configs, > > Delete __initdata from the u300 table, the other one seems > safe. Fold this into your patch. > > Go with the original idea. That indeed sounds like a cleaner solution I will prepare a new version of the patch (and this series for the i915 CI) with this approach. Thanks & Regards, Hans