From: Samuel Holland <samuel@sholland.org>
To: Bin Liu <b-liu@ti.com>, Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH] soc: sunxi: Fix missing dependency on REGMAP_MMIO
Date: Mon, 1 Apr 2019 17:04:56 -0500 [thread overview]
Message-ID: <971c2594-91e0-0567-78fd-979442040209@sholland.org> (raw)
In-Reply-To: <20190401152943.GI25852@uda0271908>
On 4/1/19 10:29 AM, 'Bin Liu' via linux-sunxi wrote:
> On Fri, Mar 01, 2019 at 03:43:48PM +0100, Maxime Ripard wrote:
>> On Thu, Feb 28, 2019 at 08:20:44PM -0600, Samuel Holland wrote:
>>> When enabling ARCH_SUNXI from allnoconfig, SUNXI_SRAM is enabled, but
>>> not REGMAP_MMIO, so the kernel fails to link with an undefined reference
>>> to __devm_regmap_init_mmio_clk. Select REGMAP_MMIO, as suggested in
>>> drivers/base/regmap/Kconfig.
>>>
>>> This creates the following dependency loop:
>>>
>>> drivers/of/Kconfig:68: symbol OF_IRQ depends on IRQ_DOMAIN
>>> kernel/irq/Kconfig:63: symbol IRQ_DOMAIN is selected by REGMAP
>>> drivers/base/regmap/Kconfig:7: symbol REGMAP default is visible depending on REGMAP_MMIO
>>> drivers/base/regmap/Kconfig:39: symbol REGMAP_MMIO is selected by SUNXI_SRAM
>>> drivers/soc/sunxi/Kconfig:4: symbol SUNXI_SRAM is selected by USB_MUSB_SUNXI
>>> drivers/usb/musb/Kconfig:63: symbol USB_MUSB_SUNXI depends on GENERIC_PHY
>>> drivers/phy/Kconfig:7: symbol GENERIC_PHY is selected by PHY_BCM_NS_USB3
>>> drivers/phy/broadcom/Kconfig:29: symbol PHY_BCM_NS_USB3 depends on MDIO_BUS
>>> drivers/net/phy/Kconfig:12: symbol MDIO_BUS default is visible depending on PHYLIB
>>> drivers/net/phy/Kconfig:181: symbol PHYLIB is selected by ARC_EMAC_CORE
>>> drivers/net/ethernet/arc/Kconfig:18: symbol ARC_EMAC_CORE is selected by ARC_EMAC
>>> drivers/net/ethernet/arc/Kconfig:24: symbol ARC_EMAC depends on OF_IRQ
>>>
>>> To fix the circular dependency, make USB_MUSB_SUNXI select GENERIC_PHY
>>> instead of depending on it. This matches the use of GENERIC_PHY by all
>>> but two other drivers.
>
> Should this go to stable tree as well? Is a 'Fixes' tag for it?
Yes, I just sent v2 with these tags (although I forgot Maxime's Ack).
>>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>>
>> I assume it would go through the USB tree.
>>
>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Cheers,
Samuel
prev parent reply other threads:[~2019-04-01 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 2:20 [PATCH] soc: sunxi: Fix missing dependency on REGMAP_MMIO Samuel Holland
2019-03-01 14:43 ` Maxime Ripard
2019-04-01 15:29 ` Bin Liu
2019-04-01 22:04 ` Samuel Holland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=971c2594-91e0-0567-78fd-979442040209@sholland.org \
--to=samuel@sholland.org \
--cc=b-liu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).