From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lukasz Luba <l.luba@partner.samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: b.zolnierkie@samsung.com, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, m.szyprowski@samsung.com,
s.nawrocki@samsung.com, joel@joelfernandes.org,
chris.diamand@arm.com, mka@chromium.org, rostedt@goodmis.org,
mingo@redhat.com
Subject: Re: [PATCH v3 7/7] drivers: devfreq: add tracing for scheduling work
Date: Thu, 14 Feb 2019 13:57:54 +0900 [thread overview]
Message-ID: <971cee25-cb3c-97b0-087e-97551dc066ad@samsung.com> (raw)
In-Reply-To: <1550010238-24002-8-git-send-email-l.luba@partner.samsung.com>
Hi Lukasz,
On 19. 2. 13. 오전 7:23, Lukasz Luba wrote:
> This patch add basic tracing of the devfreq workqueue and delayed work.
> It aims to capture changes of the polling intervals and device state.
>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
> drivers/devfreq/devfreq.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 29e99ce..c1d0d8c 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -29,6 +29,9 @@
> #include <linux/of.h>
> #include "governor.h"
>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/devfreq.h>
> +
> /* The ~30% load threshold used for load calculation (due to fixed point
> * arithmetic) */
> #define LOAD_THRESHOLD_IN_DEVICE_USAGE (300)
> @@ -418,6 +421,7 @@ static void devfreq_monitor(struct work_struct *work)
> struct devfreq *devfreq = container_of(work,
> struct devfreq, work.work);
> unsigned int polling_ms;
> + const char *df_name = dev_name(&devfreq->dev);
nit: You can use 'dev_name(&devfreq->dev)' directly
without defining the separate df_name.
>
> mutex_lock(&devfreq->lock);
> polling_ms = devfreq_get_polling_delay(devfreq);
> @@ -429,6 +433,10 @@ static void devfreq_monitor(struct work_struct *work)
> schedule_delayed_work(&devfreq->work,
> msecs_to_jiffies(polling_ms));
> mutex_unlock(&devfreq->lock);
> +
> + trace_devfreq_monitor(df_name, devfreq->previous_freq, polling_ms,
> + devfreq->last_status.busy_time,
> + devfreq->last_status.total_time);
Regardless of type of work,
I think that trace point is necessary for devfreq framework.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> }
>
> /**
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-02-14 4:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190212222422eucas1p1624203db4db3e495035820dea542e23a@eucas1p1.samsung.com>
2019-02-12 22:23 ` [PATCH v3 0/7] drivers: devfreq: fix and optimize workqueue mechanism Lukasz Luba
[not found] ` <CGME20190212222430eucas1p1ad7992e29d224790c1e20ef7442e62fe@eucas1p1.samsung.com>
2019-02-12 22:23 ` [PATCH v3 1/7] drivers: devfreq: change deferred work into delayed Lukasz Luba
2019-02-14 4:10 ` Chanwoo Choi
[not found] ` <CGME20190212222431eucas1p1697607e6536a90283cf7dad37fa74dbb@eucas1p1.samsung.com>
2019-02-12 22:23 ` [PATCH v3 2/7] drivers: devfreq: change devfreq workqueue mechanism Lukasz Luba
2019-02-14 4:11 ` Chanwoo Choi
[not found] ` <CGME20190212222433eucas1p264602d67a916c644c7eb5012932fc17a@eucas1p2.samsung.com>
2019-02-12 22:23 ` [PATCH v3 3/7] Kconfig: drivers: devfreq: add default idle polling Lukasz Luba
[not found] ` <CGME20190212222434eucas1p134dcdce827df19704c698fd6452b0a06@eucas1p1.samsung.com>
2019-02-12 22:23 ` [PATCH v3 4/7] include: devfreq: add polling_idle_ms to 'profile' Lukasz Luba
2019-02-14 4:51 ` Chanwoo Choi
[not found] ` <CGME20190212222436eucas1p21eebc80796406787a2ebf9a84ee5b868@eucas1p2.samsung.com>
2019-02-12 22:23 ` [PATCH v3 5/7] drivers: devfreq: add longer polling interval in idle Lukasz Luba
[not found] ` <CGME20190212222437eucas1p198db6fca1f1ba3056d93c57327dd48ed@eucas1p1.samsung.com>
2019-02-12 22:23 ` [PATCH v3 6/7] trace: events: add devfreq trace event file Lukasz Luba
2019-02-12 23:14 ` Steven Rostedt
2019-02-13 13:35 ` Lukasz Luba
2019-02-14 5:01 ` Chanwoo Choi
2019-02-13 13:56 ` Steven Rostedt
2019-02-13 14:37 ` Lukasz Luba
[not found] ` <CGME20190212222438eucas1p27e020c2b36f2e5a2188e4df6fb18488b@eucas1p2.samsung.com>
2019-02-12 22:23 ` [PATCH v3 7/7] drivers: devfreq: add tracing for scheduling work Lukasz Luba
2019-02-14 4:57 ` Chanwoo Choi [this message]
2019-02-13 0:18 ` [PATCH v3 0/7] drivers: devfreq: fix and optimize workqueue mechanism Chanwoo Choi
2019-02-13 11:14 ` Lukasz Luba
2019-02-13 14:52 ` Lukasz Luba
2019-02-14 0:41 ` Chanwoo Choi
[not found] ` <CGME20190212222436eucas1p21eebc80796406787a2ebf9a84ee5b868@epcms1p3>
2019-02-18 4:33 ` [PATCH v3 5/7] drivers: devfreq: add longer polling interval in idle MyungJoo Ham
2019-02-19 8:33 ` Lukasz Luba
[not found] ` <CGME20190212222436eucas1p21eebc80796406787a2ebf9a84ee5b868@epcms1p7>
2019-02-21 5:56 ` MyungJoo Ham
2019-02-22 16:03 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=971cee25-cb3c-97b0-087e-97551dc066ad@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=chris.diamand@arm.com \
--cc=joel@joelfernandes.org \
--cc=kyungmin.park@samsung.com \
--cc=l.luba@partner.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=rostedt@goodmis.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).