From: Ralph Campbell <rcampbell@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org,
"Jérôme Glisse" <jglisse@redhat.com>,
"Jason Gunthorpe" <jgg@mellanox.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/4] mm/hmm: make full use of walk_page_range()
Date: Thu, 12 Sep 2019 10:16:51 -0700 [thread overview]
Message-ID: <973b7159-513f-0776-668d-8ba1adf87f1c@nvidia.com> (raw)
In-Reply-To: <20190912082613.GA14368@lst.de>
On 9/12/19 1:26 AM, Christoph Hellwig wrote:
>> +static int hmm_pfns_fill(unsigned long addr,
>> + unsigned long end,
>> + struct hmm_range *range,
>> + enum hmm_pfn_value_e value)
>
> Nit: can we use the space a little more efficient, e.g.:
>
> static int hmm_pfns_fill(unsigned long addr, unsigned long end,
> struct hmm_range *range, enum hmm_pfn_value_e value)
>
>> +static int hmm_vma_walk_test(unsigned long start,
>> + unsigned long end,
>> + struct mm_walk *walk)
>
> Same here.
>
>> + if (!(vma->vm_flags & VM_READ)) {
>> + (void) hmm_pfns_fill(start, end, range, HMM_PFN_NONE);
>
> There should be no need for the void cast here.
>
OK. I'll post a v2 with the these changes.
Thanks for the reviews.
next prev parent reply other threads:[~2019-09-12 17:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 22:28 [PATCH 0/4] HMM tests and minor fixes Ralph Campbell
2019-09-11 22:28 ` [PATCH 1/4] mm/hmm: make full use of walk_page_range() Ralph Campbell
2019-09-12 8:26 ` Christoph Hellwig
2019-09-12 17:16 ` Ralph Campbell [this message]
2019-09-11 22:28 ` [PATCH 2/4] mm/hmm: allow snapshot of the special zero page Ralph Campbell
2019-09-12 8:26 ` Christoph Hellwig
2019-09-12 17:08 ` Ralph Campbell
2019-09-11 22:28 ` [PATCH 3/4] mm/hmm: allow hmm_range_fault() of mmap(PROT_NONE) Ralph Campbell
2019-09-11 22:28 ` [PATCH 4/4] mm/hmm/test: add self tests for HMM Ralph Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=973b7159-513f-0776-668d-8ba1adf87f1c@nvidia.com \
--to=rcampbell@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).