From: Michal Suchanek <msuchanek@suse.de>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Michal Suchanek <msuchanek@suse.de>,
Gerd Hoffmann <kraxel@redhat.com>,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
linux-mmc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] mmc: bcm2835: reset host on timeout
Date: Wed, 14 Feb 2018 15:38:57 +0100 [thread overview]
Message-ID: <97593d6e1a41af1baff61f7d9e6e68a450fc9da6.1518619058.git.msuchanek@suse.de> (raw)
The bcm2835 mmc host tends to lock up for unknown reason so reset it on
timeout. The upper mmc block layer tries retransimitting with single
blocks which tends to work out after a long wait.
This is better than giving up and leaving the machine broken for no
obvious reason.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
drivers/mmc/host/bcm2835.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 229dc18f0581..ce05fe72f865 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -286,6 +286,7 @@ static void bcm2835_reset(struct mmc_host *mmc)
if (host->dma_chan)
dmaengine_terminate_sync(host->dma_chan);
+ host->dma_chan = NULL;
bcm2835_reset_internal(host);
}
@@ -837,6 +838,8 @@ static void bcm2835_timeout(struct work_struct *work)
dev_err(dev, "timeout waiting for hardware interrupt.\n");
bcm2835_dumpregs(host);
+ bcm2835_reset(host->mmc);
+
if (host->data) {
host->data->error = -ETIMEDOUT;
bcm2835_finish_data(host);
--
2.13.6
next reply other threads:[~2018-02-14 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 14:38 Michal Suchanek [this message]
2018-02-14 14:38 ` [PATCH 2/2] mmc: bcm2835: print some informational messages during reset Michal Suchanek
2018-02-14 16:50 ` Florian Fainelli
2018-02-14 16:50 ` Florian Fainelli
2018-02-14 19:47 ` Michal Suchánek
2018-02-15 18:22 ` Stefan Wahren
2018-03-04 15:46 ` Michal Suchánek
2018-02-14 14:58 ` [PATCH 1/2] mmc: bcm2835: reset host on timeout Stefan Wahren
2018-02-14 15:36 ` Michal Suchánek
2018-02-14 15:58 ` Michal Suchánek
2018-02-14 16:49 ` Stefan Wahren
2018-02-14 19:24 ` Michal Suchánek
2018-02-14 20:30 ` Stefan Wahren
2018-03-04 15:57 ` Michal Suchánek
2018-03-04 18:11 ` Stefan Wahren
2018-03-04 18:44 ` Michal Suchánek
2018-03-03 13:58 ` Stefan Wahren
2018-03-04 16:04 ` Michal Suchánek
2018-03-04 16:36 ` Michal Suchánek
2018-03-04 18:15 ` Stefan Wahren
2018-03-06 19:21 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97593d6e1a41af1baff61f7d9e6e68a450fc9da6.1518619058.git.msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=Julia.Lawall@lip6.fr \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=garsilva@embeddedor.com \
--cc=kraxel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).