linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "yukuai (C)" <yukuai3@huawei.com>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	<cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>
Subject: Re: [PATCH RFC 9/9] block, bfq: decrease 'num_groups_with_pending_reqs' earlier
Date: Fri, 17 Dec 2021 10:53:13 +0800	[thread overview]
Message-ID: <97642e8d-b93c-c229-d13e-76517d5e654f@huawei.com> (raw)
In-Reply-To: <B5C2B1F6-4DF9-4657-AFF4-D53DD04A65DC@linaro.org>

在 2021/12/17 0:34, Paolo Valente 写道:
> 
> 
>> Il giorno 11 dic 2021, alle ore 03:10, yukuai (C) <yukuai3@huawei.com> ha scritto:
>>
>> 在 2021/12/10 18:21, Paolo Valente 写道:
>>>> Il giorno 27 nov 2021, alle ore 11:11, Yu Kuai<yukuai3@huawei.com>  ha scritto:
>>>>
>>>> Currently 'num_groups_with_pending_reqs' won't be decreased when
>>>> the group doesn't have any pending requests, while any child group
>>>> have any pending requests. The decrement is delayed to when all the
>>>> child groups doesn't have any pending requests.
>>>>
>>>> For example:
>>>> 1) t1 issue sync io on root group, t2 and t3 issue sync io on the same
>>>> child group. num_groups_with_pending_reqs is 2 now.
>>>> 2) t1 stopped, num_groups_with_pending_reqs is still 2. io from t2 and
>>>> t3 still can't be handled concurrently.
>>>>
>>>> Fix the problem by decreasing 'num_groups_with_pending_reqs'
>>>> immediately upon the deactivation of last entity of the group.
>>>>
>>> I don't understand this patch clearly.
>>> I understand your proposal not to count a group as with pending requests, in case no child process of the group has IO, but only its child groups have pending requests.
>>> So, entities here are only queues for this patch?
>>> If they are only queues, I think it is still incorrect to remove the group from the count of groups with pending IO when all its child queues are deactivated, because there may still be unfinished IO for those queues.
>>
>> Hi, Paolo
>>
>> bfq_weights_tree_remove() will be called when all requests are completed
>> in bfq_queue, thus I recored how many queues have pending requests
>> through weights tree insertion and removal.(Details in patch 7)
>>
>> Thus when calling bfq_weights_tree_remove() for bfqq, I can check if
>> there are no queues have pending requests for parent bfqg:
>>
>> if (!bfqg->num_entities_with_pending_reqs && -> no queues with pending reqs
>>     entity->in_groups_with_pending_reqs) {   -> the group is counted
>>
> 
> Ok, I got confused because you use the term deactivation.  Yet you
> seem to decrement the counter at the right time.  Maybe fix that term,
> in commit messages and comments.

Ok, I'll fix that term, and thanks for taking time reviewing these
patches,
> 
> Thanks,
> Paolo
> 
>> Thanks,
>> Kuai
>>> Am I missing something?
>>> Thanks,
>>> Paolo
> 
> .
> 

  reply	other threads:[~2021-12-17  2:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-27 10:11 [PATCH RFC 0/9] support concurrent sync io for bfq on a specail occasion Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 1/9] block, bfq: add new apis to iterate bfq entities Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 2/9] block, bfq: apply news apis where root group is not expected Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 3/9] block, bfq: handle the case when for_each_entity() access root group Yu Kuai
2021-12-10 10:06   ` Paolo Valente
2021-11-27 10:11 ` [PATCH RFC 4/9] block, bfq: count root group into 'num_groups_with_pending_reqs' Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 5/9] block, bfq: do not idle if only one cgroup is activated Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 6/9] block, bfq: only count group that the bfq_queue belongs to Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 7/9] block, bfq: record how many queues have pending requests in bfq_group Yu Kuai
2021-11-27 10:11 ` [PATCH RFC 8/9] block, bfq: move forward __bfq_weights_tree_remove() Yu Kuai
2021-12-10 10:00   ` Paolo Valente
2021-12-11  2:18     ` yukuai (C)
2021-11-27 10:11 ` [PATCH RFC 9/9] block, bfq: decrease 'num_groups_with_pending_reqs' earlier Yu Kuai
2021-12-10 10:21   ` Paolo Valente
2021-12-11  2:10     ` yukuai (C)
2021-12-16 16:34       ` Paolo Valente
2021-12-17  2:53         ` yukuai (C) [this message]
2021-12-10  8:20 ` [PATCH RFC 0/9] support concurrent sync io for bfq on a specail occasion yukuai (C)
2021-12-10  9:20 ` Paolo Valente
2021-12-10  9:50   ` yukuai (C)
2021-12-10 10:23     ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97642e8d-b93c-c229-d13e-76517d5e654f@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).