From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932334AbcIRQuj (ORCPT ); Sun, 18 Sep 2016 12:50:39 -0400 Received: from mout.web.de ([217.72.192.78]:65252 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcIRQuc (ORCPT ); Sun, 18 Sep 2016 12:50:32 -0400 Subject: [PATCH 1/5] drm/amdgpu: Use kmalloc_array() in amdgpu_debugfs_gca_config_read() To: dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Chunming Zhou , David Airlie , Monk Liu , Tom St Denis References: <566ABCD9.1060404@users.sourceforge.net> <8d614254-1cba-0379-cf84-52ad9bd9f3a7@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <976bba66-8e9b-d5ee-a266-d291986e63d7@users.sourceforge.net> Date: Sun, 18 Sep 2016 18:50:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <8d614254-1cba-0379-cf84-52ad9bd9f3a7@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NF+HUN9sIHi01OCx3h8Hwv+U9vszUyFJMrwURy7vgsqkruhgVvf LQHieU89bJxTmXLoU1oC7kKdK3y6m0qlguDviE9H1vlOAJv/O+HJtZMRtCdt0GEzLBxcXMk Q+6+7PefAbSszE99HoHPkhR1hqJP/vKjEEvv5zKWHagSw9pd75t7ZiIytqNzgUIuFEyJXtP nHudLi5UNHAtE5Df0fX5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:CwQbVw91P6w=:/GrkoLtZMxGQsNm2P7uPon rnqE7CSTatofe0ObpNgE7i0a5I0Ujfh3NxgadzJ3jVwD5ZAEorHCIaaSwgF9jbPFqTRo+teuQ odWcicaiIsaD9/gF2Rv2lqb9pCvO+XiV2fI8Iuv2qmsaIg7iErhv3UMkUqeu7ZteXn9krGSYN oyWRYwhGYY+RWDo2b1wHMusPYMaWxKrM+OD+CmOxxmrdyBNCHPLZIjYMFeyzLDx+QUZF3L8Jc NcUTzU8hYADzeUoBuoPBs/li85RaDxLyzC14RvMTRIM0dzlAxbDrnRE2+u9CubIVmKhm/MyUs janC7jOooygdJi1u4GTN1Un3Alcr7AhvZYtQurIap/aKaKuvqaCzSPozXCgOTamANue7n8KNF ZoS96WlL3KDC/tYMabQSMLkLdqu7NlxXTGswy0Hd3zvGjm05my0jrL1PUKRZE1P3RrdNoeLL0 /cYzGqIXZDFCrOmzU9Nl4jNbcmO3JX/WaEhahLIWW2sUH4Wj0HmMWUztZcSS1oVYv7ndIbQoZ HVV3c5xLzZuPzJM7E3Tgw58d+2g/F9UfwlbWBQ8MT6GTdxvcJhmqSMngrOwkCvOzN//95REnM PD7kJF7xjZgyy/oYj3+W8V2eM+AOxQtxjdSkfMvJp2yjJ8Hxx3DqLQf5EUHLJ58U28HOdKkfb cQ9vcIegPAw7S0eTtuJSLtJQr7xFiGGkZM6m03UWqIMVvBO2pNk+PchJ/mHeWy+vyWcIBuFM3 MLwV9H3mQR+aVUYiPc6nEmQANyk3m41HM5tG/NuIlK85b3UhUA0w+7/EuM7ouVRKrruR/tp5Q yOg2G3z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 18 Sep 2016 17:00:52 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index df7ab245..2709ebd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2438,7 +2438,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf, if (size & 0x3 || *pos & 0x3) return -EINVAL; - config = kmalloc(256 * sizeof(*config), GFP_KERNEL); + config = kmalloc_array(256, sizeof(*config), GFP_KERNEL); if (!config) return -ENOMEM; -- 2.10.0