From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, vinod.koul@linaro.org,
lgirdwood@gmail.com, Curtis Malainey <cujomalainey@google.com>,
plai@codeaurora.org, linux-kernel@vger.kernel.org,
Ajit Pandey <ajitp@codeaurora.org>,
tiwai@suse.com, Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Matthias Reichl <hias@horus.com>,
Rohit kumar <rohitkr@codeaurora.org>,
asishb@codeaurora.org, srinivas.kandagatla@linaro.org,
Curtis Malainey <cujomalainey@chromium.org>,
Dylan Reid <dgreid@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component
Date: Thu, 24 Jan 2019 13:07:17 -0600 [thread overview]
Message-ID: <976ec85a-7b21-6c58-90cc-a3d104f9505a@linux.intel.com> (raw)
In-Reply-To: <20190124184412.GH5641@sirena.org.uk>
>> changes are legitimate. To move forward, maybe it's not worth spending too
>> much time on a grand unification of string theory, there are simpler
>> solutions: the Intel machine drivers already do get the platform driver name
>> as an platform_data argument, so we could modify the dailinks platform names
>> before even registering the card. I tested with the attached
> Yes, that would be much better - it's vastly more idiomatic. The
> general idea is that a machine driver should know what it's expecting to
> find before it starts probing.
Thanks for the feedback, will send a formal patch with the helper and
machine driver changes after I test more with the legacy drivers. Do you
have a preference for one patch that deals with multiple machines
drivers in one shot, or individual patches? The latter are nicer for
backports (e.g. for Chrome), the former nicer for maintainers...
The goal of reusing machine drivers as is isn't really achievable
anyways, it looks like we are going to have additional changes, e.g. if
we want to avoid the calls to snd_pcm_suspend as suggested by Takashi,
we'll have to add a reference to snd_soc_pm_ops that's only used for
SOF, the Atom/SST driver does things in different ways mostly due to
historical reasons.
-Pierre
next prev parent reply other threads:[~2019-01-24 19:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:14 [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component Rohit kumar
2019-01-11 15:44 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-11 21:49 ` Pierre-Louis Bossart
2019-01-12 6:07 ` Rohit kumar
2019-01-14 15:40 ` Liam Girdwood
2019-01-15 0:06 ` Mark Brown
2019-01-15 3:08 ` Pierre-Louis Bossart
2019-01-15 19:35 ` Pierre-Louis Bossart
2019-01-15 21:07 ` Mark Brown
2019-01-15 21:11 ` Matthias Reichl
2019-01-15 21:16 ` Pierre-Louis Bossart
2019-01-15 21:41 ` Mark Brown
2019-01-15 21:48 ` Matthias Reichl
2019-01-18 23:02 ` Pierre-Louis Bossart
[not found] ` <CAOReqxjhZAzOpr-bGcV6uxPsOEid--Ym2Y0YZMHkybgZSePvtQ@mail.gmail.com>
2019-01-19 1:15 ` Curtis Malainey
2019-01-21 18:30 ` Mark Brown
2019-01-22 20:11 ` Pierre-Louis Bossart
2019-01-23 1:36 ` Curtis Malainey
2019-01-23 2:01 ` Pierre-Louis Bossart
2019-01-24 18:44 ` Mark Brown
2019-01-24 19:07 ` Pierre-Louis Bossart [this message]
2019-01-24 19:26 ` Mark Brown
2019-01-25 1:32 ` Curtis Malainey
2019-01-21 19:17 ` Mark Brown
2019-01-14 23:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=976ec85a-7b21-6c58-90cc-a3d104f9505a@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=asishb@codeaurora.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@chromium.org \
--cc=cujomalainey@google.com \
--cc=dgreid@google.com \
--cc=hias@horus.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=rohkumar@qti.qualcomm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).