Re: [PATCH v2] fpga: stratix10-soc: fix NULL vs IS_ERR() checking

From: Tom Rix <trix@redhat.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: hao.wu@intel.com, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, mdf@kernel.org, yilun.xu@intel.com
Subject: Re: [PATCH v2] fpga: stratix10-soc: fix NULL vs IS_ERR() checking
Date: Sat, 11 Dec 2021 06:57:51 -0800	[thread overview]
Message-ID: <97789bcc-0e5b-a822-854f-15d0fbe47844@redhat.com> (raw)
In-Reply-To: <20211211145038.31612-1-linmq006@gmail.com>

On 12/11/21 6:50 AM, Miaoqian Lin wrote:
> The stratix10_svc_allocate_memory function does not return NULL. It
> returns ERR_PTR(-ENOMEM). Use IS_ERR check the return value.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>   drivers/fpga/stratix10-soc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 047fd7f23706..91212bab5871 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
>   	/* Allocate buffers from the service layer's pool. */
>   	for (i = 0; i < NUM_SVC_BUFS; i++) {
>   		kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
> -		if (!kbuf) {
> +		if (IS_ERR(kbuf)) {
>   			s10_free_buffers(mgr);
> -			ret = -ENOMEM;
> +			ret = PTR_ERR(kbuf);

Thanks!

Reviewed-by: Tom Rix <trix@redhat.com>

>   			goto init_done;
>   		}
>   