From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: "Lucas Stach" <l.stach@pengutronix.de>,
"Russell King" <linux@arm.linux.org.uk>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Petr Štetiar" <ynezz@true.cz>,
"Fabio Estevam" <festevam@gmail.com>,
"Kumar Gala" <galak@codeaurora.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Stefan Agner" <stefan@agner.ch>,
"Joshua Clayton" <stillcompiling@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Shawn Guo" <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Mon, 29 Aug 2016 16:28:50 +0300 [thread overview]
Message-ID: <97a3d506-35a0-2a15-18ef-2719c0596cc1@mentor.com> (raw)
In-Reply-To: <1454688741-4238-2-git-send-email-marcel.ziswiler@toradex.com>
Hi Marcel,
On 02/05/2016 06:12 PM, Marcel Ziswiler wrote:
> From: Petr Štetiar <ynezz@true.cz>
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
> Reviewed-by: Stefan Agner <stefan@agner.ch>
> ---
>
because the change is in mainline now below is kind of out of date
information, but you may find it helpful.
[snip]
> - fixed HDMI DDC (requires GPIO-based bitbanging I2C to be enabled)
This is not needed.
[snip]
> + /* DDC_I2C: I2C2_SDA/SCL on MXM3 205/207 */
> + i2cddc: i2c@0 {
> + compatible = "i2c-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c_ddc>;
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> + &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> + >;
> + i2c-gpio,delay-us = <2>; /* ~100 kHz */
> + status = "disabled";
> + };
> +
This is not needed.
[snip]
> + pinctrl_i2c_ddc: gpioi2cddcgrp {
> + fsl,pins = <
> + /* DDC bitbang */
> + MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0
> + MX6QDL_PAD_EIM_D16__GPIO3_IO16 0x1b0b0
> + >;
> + };
> +
Practically you don't need this overcomplicated GPIO-based bitbanging
to emulate I2C, because the DW HDMI controller has a reduced I2C
controller on board, you may take a look at its support published here:
http://www.spinics.net/lists/dri-devel/msg116308.html
To utilize it the pads should be set to HDMI function instead of
I2C or GPIO.
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2016-08-29 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 16:12 [PATCH v5 0/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM/Ixora carrier board Marcel Ziswiler
2016-02-05 16:12 ` [PATCH v5 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Marcel Ziswiler
2016-08-29 13:28 ` Vladimir Zapolskiy [this message]
2016-08-29 20:54 ` Stefan Agner
2016-09-16 13:28 ` Marcel Ziswiler
2016-02-05 16:12 ` [PATCH v5 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Marcel Ziswiler
2016-02-14 6:54 ` [PATCH v5 0/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM/Ixora " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a3d506-35a0-2a15-18ef-2719c0596cc1@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=stillcompiling@gmail.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).