From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 000C1C433ED
	for <linux-kernel@archiver.kernel.org>; Fri, 14 May 2021 16:17:18 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id BF66F613F1
	for <linux-kernel@archiver.kernel.org>; Fri, 14 May 2021 16:17:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232859AbhENQS2 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 14 May 2021 12:18:28 -0400
Received: from foss.arm.com ([217.140.110.172]:52058 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233418AbhENQSP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 May 2021 12:18:15 -0400
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
        by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B6AD1764;
        Fri, 14 May 2021 09:17:04 -0700 (PDT)
Received: from [192.168.178.6] (unknown [172.31.20.19])
        by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 302443F73B;
        Fri, 14 May 2021 09:17:02 -0700 (PDT)
Subject: Re: [PATCH 3/3] arm64, topology: enable use of
 init_cpu_capacity_cppc()
To:     Ionela Voinescu <ionela.voinescu@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Valentin Schneider <valentin.schneider@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
References: <20210514095339.12979-1-ionela.voinescu@arm.com>
 <20210514095339.12979-4-ionela.voinescu@arm.com>
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <97b515ea-3daa-5252-ca6b-1acacb0e5ade@arm.com>
Date:   Fri, 14 May 2021 18:17:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210514095339.12979-4-ionela.voinescu@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14/05/2021 11:53, Ionela Voinescu wrote:

[...]

> +#ifdef CONFIG_ACPI_CPPC_LIB
> +#define arch_init_invariance_cppc init_cpu_capacity_cppc
> +#endif

The prefix `topology_` was meant to indicate that those functions come
from drivers/base/arch_topology.c. You probably refrained from it since

topology_init_cpu_capacity_cppc()

is a pretty long function name ... Still more consistent though.

[...]