From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C47A5CA9EC6 for ; Wed, 30 Oct 2019 10:41:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CE3D204FD for ; Wed, 30 Oct 2019 10:41:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726792AbfJ3KlM (ORCPT ); Wed, 30 Oct 2019 06:41:12 -0400 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:43133 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbfJ3KlM (ORCPT ); Wed, 30 Oct 2019 06:41:12 -0400 Received: from [172.20.50.122] ([91.217.168.176]) by smtp-cloud9.xs4all.net with ESMTPA id PlPWiZFXDsBskPlPZiLt31; Wed, 30 Oct 2019 11:41:09 +0100 Subject: Re: [PATCH v3] dt-bindings: media: Convert stm32 dcmi bindings to json-schema To: Benjamin Gaignard , mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, alexandre.torgue@st.com, yannick.fertre@st.com, philippe.cornu@st.com, hugues.fruchet@st.com Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191014092021.24020-1-benjamin.gaignard@st.com> <20191014092021.24020-2-benjamin.gaignard@st.com> From: Hans Verkuil Message-ID: <97b5168e-d8dc-7b1c-d2b8-0f9f32f50b82@xs4all.nl> Date: Wed, 30 Oct 2019 11:41:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191014092021.24020-2-benjamin.gaignard@st.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfGp9a3NRY0Ggs+fdGrrHavZL63Z181GPyoPphlsnKFFsVi7P2VlV3KElK1+SrSOMZuqJMorZLW0GVG5kuKoPGCcB6hxOyAZ/R3qOUP54Z/UnBEp4XeQT u1gu82U6Ru/UQoa0rwz5vS8iAt+isUg32iTul5XwMc1vhtIMz/ks+ao4JYMmYXnok1occTrRDXL3/QF7zc3TQiRUD8KHbby7xxVLjaRTGJ3IuZ3WK28/lElS orNEgi2GKSsjEkef/HmurO/C9VzNzbQh5ttU/4jhtx0DpjAxJRSy7ZHyOkhpSrcattS1e0TuoLaBwP4Ez0ZPMTmsUoy3OrE3rsVjH92eC4+U5MfYhwz+M1dz J5uU9XG0sBvf+V+9/dASBepwhhPjfZ5bwTjQsDwUOZ5gbIKAGNJq7IkFgcSBxGa+4mbRg6IEfjcTDPTTySqFm7TiotWFMU4jZ+ZJ7PO+IklAKeIDoEwLhYzC P9sJhBM+lwy65TFke4d0N8lk6cCe7nhA2tloyO2WUxaNJQJwYpaAuChNN8Qrhs6AA4HSi1R32ltShhfAoZzWAMBc7jpowo8zM1REjnBpFR6O/4zkMIxEpnPm ByDNPKR5wIUWwyKPi2Jrjt80A2M7rxQEvdZ9FvxFqNF0YUVebjjBKavAC+3Om41peNI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/19 11:20 AM, Benjamin Gaignard wrote: > Convert the STM32 dcmi binding to DT schema format using json-schema It looks like the MAINTAINERS entry isn't updated. Can you post a separate patch for that? Hans > > Signed-off-by: Benjamin Gaignard > --- > changes in v3: > -use (GPL-2.0-only OR BSD-2-Clause) license > > changes in v2: > - use BSD-2-Clause license > - remove useless dma descriptions > - fix clock property > - add additionalProperties: false > - fix reset indentation > > .../devicetree/bindings/media/st,stm32-dcmi.txt | 45 ----------- > .../devicetree/bindings/media/st,stm32-dcmi.yaml | 86 ++++++++++++++++++++++ > 2 files changed, 86 insertions(+), 45 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.txt > create mode 100644 Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt b/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt > deleted file mode 100644 > index 3122ded82eb4..000000000000 > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.txt > +++ /dev/null > @@ -1,45 +0,0 @@ > -STMicroelectronics STM32 Digital Camera Memory Interface (DCMI) > - > -Required properties: > -- compatible: "st,stm32-dcmi" > -- reg: physical base address and length of the registers set for the device > -- interrupts: should contain IRQ line for the DCMI > -- resets: reference to a reset controller, > - see Documentation/devicetree/bindings/reset/st,stm32-rcc.txt > -- clocks: list of clock specifiers, corresponding to entries in > - the clock-names property > -- clock-names: must contain "mclk", which is the DCMI peripherial clock > -- pinctrl: the pincontrol settings to configure muxing properly > - for pins that connect to DCMI device. > - See Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml. > -- dmas: phandle to DMA controller node, > - see Documentation/devicetree/bindings/dma/stm32-dma.txt > -- dma-names: must contain "tx", which is the transmit channel from DCMI to DMA > - > -DCMI supports a single port node with parallel bus. It should contain one > -'port' child node with child 'endpoint' node. Please refer to the bindings > -defined in Documentation/devicetree/bindings/media/video-interfaces.txt. > - > -Example: > - > - dcmi: dcmi@50050000 { > - compatible = "st,stm32-dcmi"; > - reg = <0x50050000 0x400>; > - interrupts = <78>; > - resets = <&rcc STM32F4_AHB2_RESET(DCMI)>; > - clocks = <&rcc 0 STM32F4_AHB2_CLOCK(DCMI)>; > - clock-names = "mclk"; > - pinctrl-names = "default"; > - pinctrl-0 = <&dcmi_pins>; > - dmas = <&dma2 1 1 0x414 0x3>; > - dma-names = "tx"; > - port { > - dcmi_0: endpoint { > - remote-endpoint = <...>; > - bus-width = <8>; > - hsync-active = <0>; > - vsync-active = <0>; > - pclk-sample = <1>; > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > new file mode 100644 > index 000000000000..3fe778cb5cc3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > @@ -0,0 +1,86 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/st,stm32-dcmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: STMicroelectronics STM32 Digital Camera Memory Interface (DCMI) binding > + > +maintainers: > + - Hugues Fruchet > + > +properties: > + compatible: > + const: st,stm32-dcmi > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: mclk > + > + dmas: > + maxItems: 1 > + > + dma-names: > + items: > + - const: tx > + > + resets: > + maxItems: 1 > + > + port: > + type: object > + description: > + DCMI supports a single port node with parallel bus. It should contain > + one 'port' child node with child 'endpoint' node. Please refer to the > + bindings defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + - dmas > + - dma-names > + - port > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + dcmi: dcmi@4c006000 { > + compatible = "st,stm32-dcmi"; > + reg = <0x4c006000 0x400>; > + interrupts = ; > + resets = <&rcc CAMITF_R>; > + clocks = <&rcc DCMI>; > + clock-names = "mclk"; > + dmas = <&dmamux1 75 0x400 0x0d>; > + dma-names = "tx"; > + > + port { > + dcmi_0: endpoint { > + remote-endpoint = <&ov5640_0>; > + bus-width = <8>; > + hsync-active = <0>; > + vsync-active = <0>; > + pclk-sample = <1>; > + }; > + }; > + }; > + > +... >