Re: [PATCH v6 05/13] module: Move latched RB-tree support to a separate file

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 18/02/2022 à 22:25, Aaron Tomlin a écrit :
> No functional change.
> 
> This patch migrates module latched RB-tree support
> (e.g. see __module_address()) from core module code
> into kernel/module/tree_lookup.c.
> 
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> ---
>   kernel/module/Makefile      |   3 +
>   kernel/module/internal.h    |  33 +++++++++
>   kernel/module/main.c        | 130 ++----------------------------------
>   kernel/module/tree_lookup.c | 109 ++++++++++++++++++++++++++++++
>   4 files changed, 149 insertions(+), 126 deletions(-)
>   create mode 100644 kernel/module/tree_lookup.c


   CC      kernel/module/main.o
kernel/module/main.c:3723:6: warning: no previous prototype for 
'module_layout' [-Wmissing-prototypes]
  3723 | void module_layout(struct module *mod,
       |      ^~~~~~~~~~~~~
   CC      kernel/module/strict_rwx.o
In file included from kernel/module/strict_rwx.c:12:
kernel/module/internal.h:140:13: warning: 'mod_tree_remove' defined but 
not used [-Wunused-function]
   140 | static void mod_tree_remove(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
kernel/module/internal.h:139:13: warning: 'mod_tree_remove_init' defined 
but not used [-Wunused-function]
   139 | static void mod_tree_remove_init(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~~~~~~
kernel/module/internal.h:138:13: warning: 'mod_tree_insert' defined but 
not used [-Wunused-function]
   138 | static void mod_tree_insert(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
   CC      kernel/module/kallsyms.o
In file included from kernel/module/kallsyms.c:12:
kernel/module/internal.h:140:13: warning: 'mod_tree_remove' defined but 
not used [-Wunused-function]
   140 | static void mod_tree_remove(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
kernel/module/internal.h:139:13: warning: 'mod_tree_remove_init' defined 
but not used [-Wunused-function]
   139 | static void mod_tree_remove_init(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~~~~~~
kernel/module/internal.h:138:13: warning: 'mod_tree_insert' defined but 
not used [-Wunused-function]
   138 | static void mod_tree_insert(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
   CC      kernel/module/procfs.o
In file included from kernel/module/procfs.c:13:
kernel/module/internal.h:140:13: warning: 'mod_tree_remove' defined but 
not used [-Wunused-function]
   140 | static void mod_tree_remove(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~
kernel/module/internal.h:139:13: warning: 'mod_tree_remove_init' defined 
but not used [-Wunused-function]
   139 | static void mod_tree_remove_init(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~~~~~~
kernel/module/internal.h:138:13: warning: 'mod_tree_insert' defined but 
not used [-Wunused-function]
   138 | static void mod_tree_insert(struct module *mod) { }
       |             ^~~~~~~~~~~~~~~


Christophe