From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: ubizjak@gmail.com, Zeng Guang <guang.zeng@intel.com>
Subject: Re: [PATCH] KVM: selftests: Enhance handling WRMSR ICR register in x2APIC mode
Date: Fri, 24 Jun 2022 17:46:30 +0200 [thread overview]
Message-ID: <980f6261-60b2-586d-a480-acadffeacb0b@redhat.com> (raw)
In-Reply-To: <20220624154535.2736289-1-pbonzini@redhat.com>
Oops, sent patch from wrong branch.
Paolo
On 6/24/22 17:45, Paolo Bonzini wrote:
> From: Zeng Guang <guang.zeng@intel.com>
>
> Hardware would directly write x2APIC ICR register instead of software
> emulation in some circumstances, e.g when Intel IPI virtualization is
> enabled. This behavior requires normal reserved bits checking to ensure
> them input as zero, otherwise it will cause #GP. So we need mask out
> those reserved bits from the data written to vICR register.
>
> Remove Delivery Status bit emulation in test case as this flag
> is invalid and not needed in x2APIC mode. KVM may ignore clearing
> it during interrupt dispatch which will lead to fake test failure.
>
> Opportunistically correct vector number for test sending IPI to
> non-existent vCPUs.
>
> Signed-off-by: Zeng Guang <guang.zeng@intel.com>
> Message-Id: <20220623094511.26066-1-guang.zeng@intel.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .../selftests/kvm/x86_64/xapic_state_test.c | 20 ++++++++++++++++---
> 1 file changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/xapic_state_test.c b/tools/testing/selftests/kvm/x86_64/xapic_state_test.c
> index 5c5dc7bbb4e2..87531623064f 100644
> --- a/tools/testing/selftests/kvm/x86_64/xapic_state_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/xapic_state_test.c
> @@ -71,13 +71,27 @@ static void ____test_icr(struct xapic_vcpu *x, uint64_t val)
> vcpu_ioctl(vcpu, KVM_GET_LAPIC, &xapic);
> icr = (u64)(*((u32 *)&xapic.regs[APIC_ICR])) |
> (u64)(*((u32 *)&xapic.regs[APIC_ICR2])) << 32;
> - if (!x->is_x2apic)
> + if (!x->is_x2apic) {
> val &= (-1u | (0xffull << (32 + 24)));
> - ASSERT_EQ(icr, val & ~APIC_ICR_BUSY);
> + ASSERT_EQ(icr, val & ~APIC_ICR_BUSY);
> + } else {
> + ASSERT_EQ(icr & ~APIC_ICR_BUSY, val & ~APIC_ICR_BUSY);
> + }
> }
>
> +#define X2APIC_RSVED_BITS_MASK (GENMASK_ULL(31,20) | \
> + GENMASK_ULL(17,16) | \
> + GENMASK_ULL(13,13))
> +
> static void __test_icr(struct xapic_vcpu *x, uint64_t val)
> {
> + if (x->is_x2apic) {
> + /* Hardware writing vICR register requires reserved bits 31:20,
> + * 17:16 and 13 kept as zero to avoid #GP exception. Data value
> + * written to vICR should mask out those bits above.
> + */
> + val &= ~X2APIC_RSVED_BITS_MASK;
> + }
> ____test_icr(x, val | APIC_ICR_BUSY);
> ____test_icr(x, val & ~(u64)APIC_ICR_BUSY);
> }
> @@ -102,7 +116,7 @@ static void test_icr(struct xapic_vcpu *x)
> icr = APIC_INT_ASSERT | 0xff;
> for (i = vcpu->id + 1; i < 0xff; i++) {
> for (j = 0; j < 8; j++)
> - __test_icr(x, i << (32 + 24) | APIC_INT_ASSERT | (j << 8));
> + __test_icr(x, i << (32 + 24) | icr | (j << 8));
> }
>
> /* And again with a shorthand destination for all types of IPIs. */
prev parent reply other threads:[~2022-06-24 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 15:45 [PATCH] KVM: selftests: Enhance handling WRMSR ICR register in x2APIC mode Paolo Bonzini
2022-06-24 15:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=980f6261-60b2-586d-a480-acadffeacb0b@redhat.com \
--to=pbonzini@redhat.com \
--cc=guang.zeng@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).