From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, khilman@baylibre.com
Cc: linux.amoon@gmail.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ottuzzi@gmail.com
Subject: Re: [PATCH 1/2] ARM: dts: meson8b: add the nvmem cell with the board's MAC address
Date: Mon, 29 Jul 2019 09:11:43 +0200 [thread overview]
Message-ID: <9814939f-8580-c8f6-5c2f-7e64db60e6ae@baylibre.com> (raw)
In-Reply-To: <20190727194647.15355-2-martin.blumenstingl@googlemail.com>
Hi Martin,
On 27/07/2019 21:46, Martin Blumenstingl wrote:
> Amlogic's BSP kernel defines that all boards with a MAC address stored
> in the eFuse have it at offset 0x1b4. It is up to the board to
> decide whether to use this MAC address or not:
> - Odroid-C1 uses the MAC address from the eFuse
> - EC-100 seems to read the MAC address from eMMC
>
> Add the nvmem cell which describes the Ethernet MAC address. Don't
> assign it to the Ethernet controller, because depending on the board the
> actual MAC address may be read from somewhere else.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> arch/arm/boot/dts/meson8b.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index 30fca9bb4bbe..c7de58b71d08 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -402,6 +402,10 @@
> clocks = <&clkc CLKID_EFUSE>;
> clock-names = "core";
>
> + ethernet_mac_address: mac@1b4 {
> + reg = <0x1b4 0x6>;
> + };
Is this a fixed position for all boards ? if not, I'll suggest moving
it to the odroid-c1 dt until you have more users.
Neil
> +
> temperature_calib: calib@1f4 {
> /* only the upper two bytes are relevant */
> reg = <0x1f4 0x4>;
>
next prev parent reply other threads:[~2019-07-29 7:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 19:46 [PATCH 0/2] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Martin Blumenstingl
2019-07-27 19:46 ` [PATCH 1/2] ARM: dts: meson8b: add the nvmem cell with the board's MAC address Martin Blumenstingl
2019-07-29 7:11 ` Neil Armstrong [this message]
2019-07-29 21:45 ` Martin Blumenstingl
2019-08-05 19:16 ` Martin Blumenstingl
2019-07-27 19:46 ` [PATCH 2/2] ARM: dts: meson8b: odroidc1: use the MAC address stored in the eFuse Martin Blumenstingl
2019-08-05 21:23 ` [PATCH 0/2] ARM: dts: meson8b: persistent MAC address for Odroid-C1 Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9814939f-8580-c8f6-5c2f-7e64db60e6ae@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=ottuzzi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).