From: Trond Myklebust <trondmy@hammerspace.com>
To: "legion@kernel.org" <legion@kernel.org>,
"ebiederm@xmission.com" <ebiederm@xmission.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"sargun@sargun.me" <sargun@sargun.me>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>
Subject: Re: [PATCH] Fix user namespace leak
Date: Fri, 15 Oct 2021 21:19:46 +0000 [thread overview]
Message-ID: <981ccefced19e68cd55908572de45fb5dc29fe34.camel@hammerspace.com> (raw)
In-Reply-To: <87o87qxsay.fsf@disp2133>
On Fri, 2021-10-15 at 09:43 -0500, Eric W. Biederman wrote:
> Alexey Gladkov <legion@kernel.org> writes:
>
> > Fixes: 61ca2c4afd9d ("NFS: Only reference user namespace from
> > nfs4idmap struct instead of cred")
> > Signed-off-by: Alexey Gladkov <legion@kernel.org>
>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> nfs folks do you want to pick this up?
It is in my testing branch,
>
> > ---
> > fs/nfs/nfs4idmap.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfs/nfs4idmap.c b/fs/nfs/nfs4idmap.c
> > index 8d8aba305ecc..f331866dd418 100644
> > --- a/fs/nfs/nfs4idmap.c
> > +++ b/fs/nfs/nfs4idmap.c
> > @@ -487,7 +487,7 @@ nfs_idmap_new(struct nfs_client *clp)
> > err_destroy_pipe:
> > rpc_destroy_pipe_data(idmap->idmap_pipe);
> > err:
> > - get_user_ns(idmap->user_ns);
> > + put_user_ns(idmap->user_ns);
> > kfree(idmap);
> > return error;
> > }
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2021-10-15 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 16:02 [PATCH] Fix user namespace leak Alexey Gladkov
2021-10-15 14:43 ` Eric W. Biederman
2021-10-15 21:19 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981ccefced19e68cd55908572de45fb5dc29fe34.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna.schumaker@netapp.com \
--cc=ebiederm@xmission.com \
--cc=legion@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).