From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Amit Nischal <anischal@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings
Date: Sun, 8 Apr 2018 15:41:33 +0530 [thread overview]
Message-ID: <98232fda-7952-b19f-7dcd-b22c45e5041a@codeaurora.org> (raw)
In-Reply-To: <152297042791.143116.12493897848354753009@swboyd.mtv.corp.google.com>
Thanks Stephen for the review.
On 4/6/2018 4:50 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2018-03-28 23:17:53)
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmh.txt b/Documentation/devicetree/bindings/clock/qcom,rpmh.txt
>> new file mode 100644
>> index 0000000..8222c88
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmh.txt
>
> Can the file name be qcom,rpmh-clk?
>
Sure will update the file name.
>> @@ -0,0 +1,22 @@
>> +Qualcomm Technologies, Inc. RPMh Clocks
>> +-------------------------------------------------------
>> +
>> +Resource Power Manager Hardened (RPMh) manages shared resources on
>> +some Qualcomm Technologies Inc. SoCs. It accepts clock requests from
>> +other hardware subsystems via RSC to control clocks.
>> +
>> +Required properties :
>> +- compatible : shall contain "qcom,rpmh-clk-sdm845"
>> +
>> +- #clock-cells : must contain 1
>> +
>> +Example :
>> +
>> +#include <dt-bindings/clock/qcom,rpmh.h>
>> +
>> + &apps_rsc {
>
>> + clock_rpmh: qcom,rpmhclk {
>
> Should say clock-controller for node name.
>
Would fix it in the next patch.
>> + compatible = "qcom,rpmh-clk-sdm845";
>> + #clock-cells = <1>;
>
> Is this tabbed out correctly?
>
Will fix the tabs in the next patch.
>> + };
>> + };
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
prev parent reply other threads:[~2018-04-08 10:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 6:17 [PATCH 0/2] Add QCOM RPMh Clock driver Taniya Das
2018-03-29 6:17 ` [PATCH 1/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver Taniya Das
2018-03-29 21:49 ` Evan Green
2018-04-02 10:33 ` Taniya Das
2018-04-03 17:55 ` Evan Green
2018-04-05 23:17 ` Stephen Boyd
2018-04-10 17:05 ` Evan Green
2018-03-29 6:17 ` [PATCH 2/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings Taniya Das
2018-04-05 23:20 ` Stephen Boyd
2018-04-08 10:11 ` Taniya Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98232fda-7952-b19f-7dcd-b22c45e5041a@codeaurora.org \
--to=tdas@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=anischal@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=okukatla@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).