From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754455AbcK1HdE (ORCPT ); Mon, 28 Nov 2016 02:33:04 -0500 Received: from mail-co1nam03on0058.outbound.protection.outlook.com ([104.47.40.58]:1104 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754291AbcK1Hc4 (ORCPT ); Mon, 28 Nov 2016 02:32:56 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; laposte.net; dkim=none (message not signed) header.d=none;laposte.net; dmarc=bestguesspass action=none header.from=xilinx.com; X-IncomingTopHeaderMarker: OriginalChecksum:;UpperCasedChecksum:;SizeAsReceived:2043;Count:20 Subject: Re: Adding a .platform_init callback to sdhci_arasan_ops To: Sebastian Frias , Douglas Anderson , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Jerry Huang , Ulf Hansson , Adrian Hunter References: CC: Linux ARM , LKML , Linus Walleij , Mason , P L Sai Krishna From: Michal Simek Message-ID: <982d633b-e9c4-0f10-052b-e324f094d0f5@xilinx.com> Date: Mon, 28 Nov 2016 08:32:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22724.006 X-TM-AS-User-Approved-Sender: Yes;Yes X-IncomingHeaderCount: 20 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(189002)(24454002)(6666003)(7846002)(2950100002)(106466001)(83506001)(230700001)(8676002)(4001430100002)(356003)(8666005)(8936002)(81166006)(189998001)(65806001)(305945005)(81156014)(65956001)(47776003)(63266004)(9786002)(36386004)(229853002)(23676002)(77096006)(86362001)(39450400002)(39410400001)(39380400001)(76176999)(31696002)(33646002)(92566002)(107886002)(626004)(50466002)(39400400001)(38730400001)(4326007)(2906002)(31686004)(54356999)(5660300001)(64126003)(65826007)(4001350100001)(5001770100001)(50986999)(36756003)(7059030)(142923001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR02MB2385;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1NAM02FT053;1:hvHI1LUW+TZ81nvPcHTJVu4vyqvhZXEAP5uadFdcVy0yBDB7OgomtSs2vzVlkbalawFe9GQm8dDouLNyNmb2O21b+gbgjI+8H7nkVRh8HPT5ELPIdJ6dl0xxJa01thRc3CUWrHgbo4wA4FECqeUsZPqVjLw6qZ5ICZmSgvIn5SiQpBTyVPiCFSzbgpGRXvRl6kemVSgzzomYAoL+6gBPdfrConzXPaKyYuDr4VnBez3CZAxNGmAr1cmLUyE8qlZlXzGO5naMf2PDrYIk1REHifUOlDbCvS7/kE2+ekUcFckxhUPSCwThlXi7jv5LFoKapkkMPHsGP32c3evqrv+CK5t7d6NIDj99sPUfnT04qOOjFC0ANz7eUpd9Pav1H+yGz36WC9U3IpzzsQuC1YWRyN0rlu2/UqD+n9FqrZFi1Wi+N6GcK2oF1KDiKULutNW2DbgV56zonE2CBdWcFzWYiCTUm+xrTtOlneXGHNiJ27u7eJKmdulFCN8shjO+elQS5stmCpvQ7dqh0g+PudBYuG/n0b5R16S0njcXvdvBB/1iHFh4z7CWvwxxI9xkXxbu0VNKjpRwympQ+nvimx0aSe8l654SmXbTHfG1W4VgdPxHyrQI5OiUgCMReZC3KvOA X-MS-Office365-Filtering-Correlation-Id: 53fb76cd-8604-468f-2a3a-08d41760c2db X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BN6PR02MB2385; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2385;3:V3VwjiXf1lQkx09eWSDAjP0sX9cHtjVi0J2MG6S6jo5nCWgzDecCGyxQbtz1LzJk66ROKDnCUjv93YyfU4ZCF0rQZTN8yGUE73HFGknogpohY69pABMarGFtHhghgDH+nBGYroWXAZpfTBokrYK8TFs5+ZxfZblxkMkfM4KAN5F5YotDWtzRH+TJtKT48dVZIMHQhK5wzcsMEVZOo7CFsok6aObFKFiTCMWQauGAiIAIsFFMb5e8dtXwm7QQFaNCy2lTvCqL7EXG+6ikSMnuEzVT0ksX7vHSBTUy/Y5y6lP3w+YNqvIsIFIjKDPji3UJw+KGlSMJuJ0OuQGVBDOFlMGR6CPz9zBq3mqeqUeu3OTw7Um/zwPBrxE0x6NueoB7Alhm/UC/MegRaKdJGD6XIw== X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2385;25:emqYSq/JljFRNimTI+E3TwP6jKfidL48oFEH4Yd5GOzR5xwldbVWG604k9+nZAePIWulHKQT5mdrM1O6vk/gdZGUnZ21US0k1TxeaD99ZVRbUijo7y3az4L808boXwMU2s3hRwnjdyJ8q11J+Gc2i1GjrWWrVPFsredo8C4/nVLQG9z1SGuN9VzoWIvGFRVRc3+x9ZvIxbzHAV1cCNHtdT7RX9LWIdZH7jXkEDzlFp8dT2Y2MK2IrksUlz/lREmPH2eadJf7YGCJHq3pyNKyHJw0wa4cPdeZtwcpgi4BELBdkyFSJt79gI2mce6kU+cxvP4/LLsmV7M3oCEioDHAhYfc3jF0ngFfYoxWo5o7TGWqQiDIUmM8jeR9SA/bO2NdoACVKtQCOHgh9BbXfJr/DIDvLHKKAFfU23IiV0wKpv048CvBSb8qyhGX1LDkWmA5URlCT4QZobIHEUsm9KryiEjCJgMxqPp7Rzo+DA41NG0i3QD31buYF+mmvfSzwiPngrOqdyKIhElIXpA1Ml6XbZzFSlvE8dK8zUNRdVBoOXgF/Fc+6oX/m/UDPKfw3XtqJkQl3mulAgQWOaUg3kY7lGx3QuQ0a6uwB4KPDarKyymP1aY9GHW5WaFypwxXK+/k/cubuAnHxXvWAFKvsbGQMcnsn5v/2SN4mKQxFKL+w4PoFvGS5cRMaA9OrxMKkZNEpqOlXMOtUiJR4C9ckBeGmgGP8GztUW+cr6gadSW7kY+k3HfNS46q8gG7RhXE43UVtebVZz6AnFWwjHv9wkckgg7kL2nfwy+8KIAnOW2vYr0nlgbFeJHk7DmR1oV6IRwZ X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2385;31:trnddEtqW3eOR2baOo5pvhOUE97B4Me8in5B8+ZFhvPEMiMTYq4UGef7QnIMQ16AqWAtPO2bZx7p0dqkrwqmv4QOe5dMFK5r0Abwn/bZt7NyCbe83O1d0MZL3C97vg/fE+s015lAnEZa7tNSHXp5EgJc39taXu+flvKsFNpehgaH9QGi3w2w94yufcKcNqw/5snYPSE2Q+o7+gAZJrNi2QJvjLc9/7AyUBPUm0lCvGV1IKo4UR1pX0w56EElgaWlcNel/xBWSmYdHhtuGVT7oNVpHB4BPgm9RTom/rzQjxE=;20:nBCMIowsvkjkF/Mzzfh3fM3QLJAAmXQcZXDYpbT/kECwDUlrr599BOeCoZFzOpeOFo6/k+aKs+uqtg3/KmdGrSLyqBP8LpICPCNV+GPwRJ0TgOVwFbG5SoeXXu+CWuJbhyT4ZamfJ75ECkJwZTTGgK2ejXPD4lAjCvkJENf/jJL2nyNetJycJCZuTDx8h0H0/DFyr9dpLbymUcYVOMcWKs75n7o+BELKXzl+Ax9I39i1KWWXJ1Oy/vvcJ0ATQNSY5pCD+PHW4We994sOc19LpPyzDxb6reqkEGxqBYx819KO//uVmkwSrERfCfmTZM9ypmos+lEiTMveoz18gYYsZIYxnIj8RvmOBJhuiQycVkMkNURfGPjHqBEP6bnrhGh8QKg11uq6wSWEd4mYybRIn2Yb/I/Ieu62FjT4E60Rt02UD6FDBH4SkWky5xG0TUInSwIUgMDfziJ3uewgZvuthgx3n5FkdmjXXre33ViQV1d0T1MSaQcNe+ykiILi5Qhf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040361)(6045199)(601004)(2401047)(13015025)(13017025)(13023025)(13024025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(6061324)(20161123560025)(20161123555025)(20161123564025)(20161123562025);SRVR:BN6PR02MB2385;BCL:0;PCL:0;RULEID:;SRVR:BN6PR02MB2385; X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2385;4:DsH9U28gchkVejWbAlW9dua7uAa9IRNmukfVYJuw07rGLM5Pj761fb4ry3b9pSex49DyLM1lmHSMTmTLvJirdOffuvlxRshIiZaQ/12Y6/Vp4BkUK8/0D1wtoKXPMbd9te5+1PlbGbfxOjf46e9ol4wDr/5rGyBejuhKymUg7Wtv/9aegneRPwOW1+vhKQzLzyZuFmwHWtGRN+EImS7GkkjDM4ycLPrcQym1YBf7yUcNH0O7zPl2pRTtLBqCriG2X7i9QtibDLoR80dAYq0mPg3C/C04LDnb25OVOZz8zoagx7LZvFIl+KlcmNknBvP92fy0J+bxa9HES+0gUYA1Y46jttuX+SrbvjRRS66cY7Mve3yY0ZW7Sj/dEe6X5fybkEhr58mcMKzutdn9+X7SS0RtDr4OFgfJDg4vRCE+stGW0gyp0u0lNikQUlb+HAPY92pydPssbPf4PVr/Gru8CPIHH6N0cCMIIBElO/Rw2S6rjydpZ+YK6QtAmupHxA2V8LV3hX1DYu1qM2g5yRV62bCZ+Hg9VqrwNuUlOLrS0D6KULjQv43ANnuaBrtSYsDyylk0J1nkcvksu9KTaAuWvoPAMh+1R8AqoVzQSQqHor+plxm58Xv7Cg+emkr7EudkwH55AJzuFh4mIIQAjvZlqDA85wjhPqtNEGeA2q1/F4TB90OxB4QpgTNgW6K9NGYgj9fOt0fNGZX/CdkqGeNbJ4uf8jpPyke7tLOOsuf7d28= X-Forefront-PRVS: 01401330D1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAyTUIyMzg1OzIzOkNuanJFUHBBUzZ5emlNbU9BQW5xeG5UcjdG?= =?utf-8?B?QTZ3UE5Yd3RVOVVpWmJQN3F0OWlPUEQrd3kwUlZkTHdEUmZDaDMxdldrWUZh?= =?utf-8?B?VmVUVTdRNGFPOStSNWZKTVFvb0c4cldUMUQ3aXFhOEh0TFlna0I5b2xqbm1G?= =?utf-8?B?eU1NaEJ0eXZqSVBOcW04MkRNWGJTMExqbUJ4MTdtQmJQSngrenNhZWxhV0xs?= =?utf-8?B?cnE3VVRuUElxblcyTGJIeFloTndsQXoxd0p0V2UrZ2ZwN29oMXYyU3J1QzNO?= =?utf-8?B?bVlXRlc3cmx4U0h5ekpOb3YzM2JzdjhkQitwc1hEbm94ODZIVW1VUTNuczM2?= =?utf-8?B?NHQyS0w3YVd0cGxLZk1qcllYVG4rNkxYL3VWY0VsZkQxZ25ibk90eU8zeVRr?= =?utf-8?B?THpPbE9ySDBaTzY4cFgxZU4rZHZpQlF4U0pOaUQ1VnlZVTVwbFh6clVQZTFj?= =?utf-8?B?dWZjWXgyQTkrZ0xuVytiT1pYY3Q1OUlxcHl4R2xtd1BXSjhVM3FSYmkzMDlv?= =?utf-8?B?WXZ3RUVzZDBrb2EwMVZvbEVnSHFRa2V0MXJUY1ZIUUptVWJHVkt6ZlMzdVV2?= =?utf-8?B?blNKYjB0ZTZQWTRsc29kdzkwKysyL2RwRlhHU1dnbmFqN0xjcnZPV1c4ZHRR?= =?utf-8?B?d1g2L2JybWVaSUs0cm5OWE9jWUtsb3YxMUNsMHYrV2NrUUpWUTVSWWEzR3Y0?= =?utf-8?B?dXBGa085WTdtRmpCVFFxVFVaMktsalBFQVRjWWxMTjl0YVlFSmY3Y3U4ZXFv?= =?utf-8?B?OG96dUJnTmhrbzdzN1g5cndIY1pZaVhLU2F1WlhOUWo0WDloTEV6aW9BdStp?= =?utf-8?B?U0pxTHZKaG4rY2Y0Z0FnRkg2UVJaMnVWclo5b2xLVGpqSFZCMVg0d0tvYWda?= =?utf-8?B?SGQwMEk4am9mcnBRM2Y2c3FodzFvcmlhSGRwT3VGRDMwbnZkRmg2VFA4Y1RX?= =?utf-8?B?SkZaNTVnM0tScGRib1F5NlFrQS9LN0RIeEdRL2xrWHBjNy9xb1BGa1VjTEEz?= =?utf-8?B?VGtKeVdudXFxenoxa2xVU2xCblVNRzJaRFllM3J6cnNrcE5jK3JVNkdzL3hB?= =?utf-8?B?T2NVdEk1Smo2VFdSTVArdjlYcUwxL2krR01HT2x2VFI0ZG5DcmNLbHlKMklO?= =?utf-8?B?eHJiaWd2QmZmQURmdEFOUzRoM0FNUUhVK1d1YjJpMXhGbmxiUlhWV2hDNnNT?= =?utf-8?B?ZklCNjM5MjhZeE1vUEd3MEQxdzMzR1lxWURhN0IyS05BbzhKOTZ1bzErQjUw?= =?utf-8?B?Tm4xTWNJRzE0NFBXOU00ODh2eWFIRzk1UVFUdnZnN3ViOTRHVEhWNm1oVW8w?= =?utf-8?B?VFF4NGVsOFJOcHk4V05kRFRHOUxhbTFlaWdkVUJITytDRzNtWEdOQlVTcWdM?= =?utf-8?B?NDdxZUZoQWJNb3RvQVIrWWdZNFRBa2c0b1F1c2cyY2dEOTk5WFluQVBQQ0Zv?= =?utf-8?B?Z0N5R0NwbjZuSWxKS1dlNTdPVGl3TUU5M3NoTmpoT2lkQnVWbEVJUVhFaHMr?= =?utf-8?B?UGo5ajBnSy9UeWRpUWl6Q1Q3NzhsSmEzY2tOMlFya3lvOU03dnhodXd3TUVQ?= =?utf-8?B?MS9SaTIrQWhGb3k4NnQwa21GYXE2cWZ4cHFHdHpsemEvKzdGUVo5M3BlNzJh?= =?utf-8?B?Z0ovTEhSaXZmOWcrMDJlWkRVS2FtRkpwTmRUK1RVcUJZai94d05nL2xzbldn?= =?utf-8?B?dXd6eG1LZXg1UjFKWk01VlZWSG02YW9pWHJ4dW1oVFlacXlHWTM0MWVLMDRK?= =?utf-8?B?SnNTS0d5bDVVb3ArV0FzSi9kRkUzSjNRRHJOWnRJTWc5aytDaHQyZzAxSlgr?= =?utf-8?B?SUpSeUxjT3ZZcHZxT1dmNnJxTWVhaDVOSFZnT1dIRGRqRGVibnBvNENya1dx?= =?utf-8?Q?yJHakcRU5CROOv0hL7EZU+pXd1YYejpJ?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2385;6:g/f9vMejdjVm+wVtsr+wRfv24KnxXfCLRDVwN45XZcYLh+cl9sCkWEgp7mILew4rsEzdMffJveLOQLtWzzglXwKSZJLNjy0MYZlbEiCbNx1hXIAZ0o8SXiEOwVYFSD14aO9tVLcTwr3cLD8smYrbHibq9FsUP0pcvTWjigh83SlLAavmznWVqMrgI5RlcYc7u7PyYRsizjCwzWcsXa9Hs+sTq1M81KYuuosUTtsVyWQfSCiYv6TDF0YROJrQsnnTDWEvKVWldZjNEip5Q44uXPETmSfwLLtXkbVLlVc7XiGFY1GTbfDvLQKJa7Ulo7eeKtgnEKbegyolR7yGDqXD22u/wtfUsKGtnYPCJiRhqJ82MLPMCgtTONMs56ixQR1xjtCfQbEzmSnV9bOz5b/7SfciLrWY79+QncZwnUpy6ZukngLD6kbbz6ydmzF3tDFG1flrcRe3jGxMz0O11nsEOC8UCE1sCEu+o5k6zUppqhfEArzSB9tJW5r82YIfoliT;5:ZIHqiFMOnAkuH7TMrjQE77+eZA8XRoj88Q3n6o4p+7pgf5APMdnxMSt8tB7LVRca2N9EtVNVNvaajXBrduZ+paOJ6AON+XCbNkOp+EJtKTGK91v84CriPcgfPzMd0fFNHuZGy2PVeev2rVXGcerlRtMeQJ1snu5SiMAqvv/kLAs=;24:UOBnQ3nTNrOHOtmyj4SAePHLfmciHL+1bwiD1Mm8MZ9nWeKfiZeqD84texf6sudxLiKNpbTsSVp0YIwKN/p40dUvoYkPHsx/pKFZg50ORCk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR02MB2385;7:H2IrEiCM1G6byVfYYCqiMwZF5yC+6P5qUpLvzeFdz6gnjAhbToNsZbPt2/AjxS00rYg8xXtsiGGPLdRU5mfAHa/+E3Lga59PEQ4TTKIxrvcEM0/lrGnxbIPOl+ZEpTncB5XjUjsKbusrLCVO3EKQ3BF9ryd2c+dA4K0d9STXkj9uuWdWcJKCQfLBMX4kRLdyp1P3g7GP178NHkpTqUWKxPKmuNfUMWU6GOANnxAri59Of68OBENKoJZ5HiEF8jgAY0iTD9n31wvCxIDkIohJwgyOEqYml5h7DXo0j7vclnPqJXsv5qwpeTO0qH0CdeHjsedLe6gNtQOOCk8Wgg9PdRtKriwaauiL+LyIjm8OPBrKdnH/WFN7eg2i2313jtMjHPJS89YUDGZMSPgPWmU5STwrI2cmCc48aUWiuHJ/yUFaHGQ4rBMEEUnb3v2sjY8JM/elVizRLP99VKrElhyZgQ== X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2016 07:32:51.5931 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2385 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Sai for Xilinx perspective. On 25.11.2016 16:24, Sebastian Frias wrote: > Hi, > > When using the Arasan SDHCI HW IP, there is a set of parameters called > "Hardware initialized registers" > > (Table 7, Section "Pin Signals", page 56 of Arasan "SD3.0/SDIO3.0/eMMC4.4 > AHB Host Controller", revision 6.0 document) > > In some platforms those signals are connected to registers that need to > be programmed at some point for proper driver/HW initialisation. > > I found that the 'struct sdhci_ops' contains a '.platform_init' callback > that is called from within 'sdhci_pltfm_init', and that seems a good > candidate for a place to program those registers (*). > > Do you agree? > > Best regards, > > Sebastian > > > (*): This has been prototyped on 4.7 as working properly. > However, upstream commit: > > commit 3ea4666e8d429223fbb39c1dccee7599ef7657d5 > Author: Douglas Anderson > Date: Mon Jun 20 10:56:47 2016 -0700 > > mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399 > ... > > could affect this solution because of the way the 'sdhci_arasan_of_match' > struct is used after that commit. >