linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sridhar Pitchai <Sridhar.Pitchai@microsoft.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
	Jake Oshins <jakeo@microsoft.com>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>
Subject: Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
Date: Thu, 12 Apr 2018 15:13:55 +0000	[thread overview]
Message-ID: <9832EE81-01B3-44AB-8B3D-EEA32AED07E0@microsoft.com> (raw)
In-Reply-To: <20180412132003.GC145698@bhelgaas-glaptop.roam.corp.google.com>

    >> I am still not happy with this patch.
    >> 
    >> -  You do not explain at all the dependency on commit 0c195567a8f6 and
    >>    you should because that's fundamental, if that patch is not present
    >>    this revert breaks the kernel as per previous discussions[1].
    >> -  You are sending this patch to all stable kernels that contain the
    >>    commit you are fixing - some that may not contain the commit above
    >>    (that was merged in v4.14), you are breaking those kernels, if not
    >>    explain me why please
    
    >If there's a dependency on 0c195567a8f6, I totally agree that
    >needs to be cleared up.  I was assuming that turned out to be
    >irrelevant.
That is right. There is no dependency on 0c195567a8f6. We just need
to revert 4a9b0933bdfc.

Thanks
Sridhar Pitchai
 

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-04-12 15:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12  2:44 [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain" Sridhar Pitchai
2018-04-12  9:17 ` Lorenzo Pieralisi
2018-04-12 13:20   ` Bjorn Helgaas
2018-04-12 15:13     ` Sridhar Pitchai [this message]
2018-04-12 15:46       ` Haiyang Zhang
2018-04-12 15:56         ` Sridhar Pitchai
2018-04-12 16:13           ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9832EE81-01B3-44AB-8B3D-EEA32AED07E0@microsoft.com \
    --to=sridhar.pitchai@microsoft.com \
    --cc=Michael.H.Kelley@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=helgaas@kernel.org \
    --cc=jakeo@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).