From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sam Protsenko <semen.protsenko@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Jaewon Kim <jaewon02.kim@samsung.com>,
Chanho Park <chanho61.park@samsung.com>,
David Virag <virag.david003@gmail.com>,
Youngmin Nam <youngmin.nam@samsung.com>,
Wolfram Sang <wsa@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 3/8] dt-bindings: i2c: exynos5: Add bus clock
Date: Mon, 6 Dec 2021 09:27:33 +0100 [thread overview]
Message-ID: <98414edc-18fa-c759-9c73-490078d8c93c@canonical.com> (raw)
In-Reply-To: <20211204215820.17378-4-semen.protsenko@linaro.org>
On 04/12/2021 22:58, Sam Protsenko wrote:
> In new Exynos SoCs (like Exynos850) where HSI2C is implemented as a
> part of USIv2 block, there are two clocks provided to HSI2C controller:
> - PCLK: bus clock (APB), provides access to register interface
> - IPCLK: operating IP-core clock; SCL is derived from this one
>
> Both clocks have to be asserted for HSI2C to be functional in that case.
>
> Modify bindings doc to allow specifying bus clock in addition to
> already described operating clock.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> Changes in v2:
> - Added 'clock-names' property to 'required:' in case of ExynosAutoV9
> - Added example for two clocks case
>
> .../devicetree/bindings/i2c/i2c-exynos5.yaml | 59 +++++++++++++++++--
> 1 file changed, 53 insertions(+), 6 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-12-06 8:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 21:58 [PATCH v2 RESEND 0/8] i2c: exynos5: Add support for modern Exynos SoCs Sam Protsenko
2021-12-04 21:58 ` [PATCH v2 RESEND 1/8] dt-bindings: i2c: exynos5: Convert to dtschema Sam Protsenko
2021-12-09 9:11 ` Wolfram Sang
2021-12-04 21:58 ` [PATCH v2 RESEND 2/8] dt-bindings: i2c: exynos5: Add exynosautov9-hsi2c compatible Sam Protsenko
2021-12-06 21:03 ` Rob Herring
2021-12-09 9:11 ` Wolfram Sang
2021-12-04 21:58 ` [PATCH v2 RESEND 3/8] dt-bindings: i2c: exynos5: Add bus clock Sam Protsenko
2021-12-06 8:27 ` Krzysztof Kozlowski [this message]
2021-12-09 9:11 ` Wolfram Sang
2021-12-04 21:58 ` [PATCH v2 RESEND 4/8] i2c: exynos5: Add support for ExynosAutoV9 SoC Sam Protsenko
2021-12-09 9:11 ` Wolfram Sang
2021-12-04 21:58 ` [PATCH v2 RESEND 5/8] i2c: exynos5: Add bus clock support Sam Protsenko
2021-12-09 9:11 ` Wolfram Sang
2021-12-09 14:07 ` Sam Protsenko
2021-12-04 21:58 ` [PATCH v2 RESEND 6/8] i2c: exynos5: Mention Exynos850 and ExynosAutoV9 in Kconfig Sam Protsenko
2021-12-09 13:34 ` Sam Protsenko
2021-12-09 14:42 ` Wolfram Sang
2021-12-09 18:52 ` Wolfram Sang
2021-12-04 21:58 ` [PATCH v2 RESEND 7/8] arm: dts: exynos: Rename hsi2c nodes to i2c for Exynos5260 Sam Protsenko
2021-12-06 8:30 ` (subset) " Krzysztof Kozlowski
2021-12-09 14:48 ` Wolfram Sang
2021-12-09 15:22 ` Sam Protsenko
2021-12-09 18:26 ` Krzysztof Kozlowski
2021-12-09 18:52 ` Wolfram Sang
2021-12-04 21:58 ` [PATCH v2 RESEND 8/8] arm64: dts: exynos: Rename hsi2c nodes to i2c for Exynos5433 and Exynos7 Sam Protsenko
2021-12-06 8:30 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98414edc-18fa-c759-9c73-490078d8c93c@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=arnd@arndb.de \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=virag.david003@gmail.com \
--cc=wsa@kernel.org \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).