From: Joe Perches <joe@perches.com>
To: Guru Das Srinagesh <gurus@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>
Cc: devicetree@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] mfd: Introduce QTI I2C PMIC controller
Date: Thu, 30 Apr 2020 18:18:18 -0700 [thread overview]
Message-ID: <9844969151d1641a0bc68c1378b554d66cc0fcf9.camel@perches.com> (raw)
In-Reply-To: <20200501011319.GA28441@codeaurora.org>
On Thu, 2020-04-30 at 18:13 -0700, Guru Das Srinagesh wrote:
> On Wed, Apr 29, 2020 at 08:50:10AM +0100, Lee Jones wrote:
> > On Tue, 28 Apr 2020, Guru Das Srinagesh wrote:
> > > The Qualcomm Technologies, Inc. I2C PMIC Controller is used by
> > > multi-function PMIC devices which communicate over the I2C bus. The
> > > controller enumerates all child nodes as platform devices, and
> > > instantiates a regmap interface for them to communicate over the I2C
> > > bus.
[]
> > > diff --git a/drivers/mfd/qcom-i2c-pmic.c b/drivers/mfd/qcom-i2c-pmic.c
[]
> > Please don't role your own debug helpers.
> >
> > The ones the kernel provides are suitably proficient.
>
> Sure. Would this be acceptable instead, with the custom string replaced by a
> macro that the kernel provides?
>
> #define pr_fmt(fmt) "%s: %s: " fmt, KBUILD_MODNAME, __func__
trivia:
It's almost always smaller object code to use
the KBUILD_MODNAME as a fixed string instead of
as a printf argument.
#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__
next prev parent reply other threads:[~2020-05-01 1:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 0:30 [PATCH v1 0/2] Introduce QTI I2C PMIC controller Guru Das Srinagesh
2020-04-29 0:30 ` [PATCH v1 1/2] dt-bindings: mfd: Document " Guru Das Srinagesh
2020-04-29 7:51 ` Lee Jones
2020-04-29 21:01 ` Rob Herring
2020-04-29 0:30 ` [PATCH v1 2/2] mfd: Introduce " Guru Das Srinagesh
2020-04-29 7:50 ` Lee Jones
2020-05-01 1:13 ` Guru Das Srinagesh
2020-05-01 1:18 ` Joe Perches [this message]
2020-05-01 1:28 ` Guru Das Srinagesh
2020-05-15 10:45 ` Lee Jones
2020-05-19 18:57 ` Guru Das Srinagesh
2020-05-20 6:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9844969151d1641a0bc68c1378b554d66cc0fcf9.camel@perches.com \
--to=joe@perches.com \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=gurus@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).