From: "Arnd Bergmann" <arnd@arndb.de>
To: "Serge Semin" <fancer.lancer@gmail.com>,
"Anders Roxell" <anders.roxell@linaro.org>
Cc: "Niklas Cassel" <Niklas.Cassel@wdc.com>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
"Praneeth Bajjuri" <praneeth@ti.com>,
"Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
"open list" <linux-kernel@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Carlos Hernandez" <ceh@ti.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>
Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag
Date: Mon, 05 Dec 2022 11:08:22 +0100 [thread overview]
Message-ID: <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com> (raw)
In-Reply-To: <20221205011105.4do4trbytq4bfw5b@mobilestation>
On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote:
> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote:
>>
>> for (i = 0; i < hpriv->n_clks; i++) {
>> - if (!strcmp(hpriv->clks[i].id, con_id))
>> + if (hpriv->clks && hpriv->clks[i].id &&
>> + !strcmp(hpriv->clks[i].id, con_id))
>> return hpriv->clks[i].clk;
>> }
>
> Indeed I should have taken into account that devm_clk_bulk_get_all()
> can get unnamed clocks too. But checking the hpriv->clks pointer for
> being not null is redundant, since the ahci_platform_get_resources()
> procedure makes sure that the array is always allocated. At the very
> least you shouldn't check the pointer in the loop, but can make sure
> that the clks array is available before it.
Do you think this is otherwise the correct fix then? Any chance we
can still get a version of it into 6.1?
Arnd
next prev parent reply other threads:[~2022-12-05 10:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 7:24 TI: X15 the connected SSD is not detected on Linux next 20221006 tag Naresh Kamboju
2022-10-13 7:11 ` Damien Le Moal
2022-10-13 12:39 ` Naresh Kamboju
2022-10-13 22:07 ` Anders Roxell
2022-10-14 0:22 ` Damien Le Moal
2022-10-14 7:31 ` Arnd Bergmann
2022-10-14 7:53 ` Damien Le Moal
2022-10-14 9:22 ` Anders Roxell
2022-10-14 9:37 ` Arnd Bergmann
2022-10-14 9:47 ` Damien Le Moal
2022-10-14 14:06 ` Serge Semin
2022-10-17 7:43 ` Anders Roxell
2022-10-17 15:52 ` Serge Semin
2022-11-30 9:40 ` Naresh Kamboju
2022-11-30 10:03 ` Niklas Cassel
2022-12-01 11:48 ` Anders Roxell
2022-12-05 1:11 ` Serge Semin
2022-12-05 10:08 ` Arnd Bergmann [this message]
2022-12-05 13:24 ` Damien Le Moal
2022-12-06 8:46 ` Serge Semin
2022-12-06 9:12 ` Damien Le Moal
2022-12-06 21:04 ` Serge Semin
2022-12-01 13:02 ` TI: X15 the connected SSD is not detected on Linux next 20221006 tag #forregzbot Thorsten Leemhuis
2022-12-07 5:40 ` Thorsten Leemhuis
2022-10-14 13:38 ` TI: X15 the connected SSD is not detected on Linux next 20221006 tag Serge Semin
2022-10-14 13:36 ` Serge Semin
2022-10-14 0:17 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98670e23-6553-4788-8662-9403c480af82@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Niklas.Cassel@wdc.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=anders.roxell@linaro.org \
--cc=ceh@ti.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=fancer.lancer@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=lukas.bulwahn@gmail.com \
--cc=naresh.kamboju@linaro.org \
--cc=praneeth@ti.com \
--cc=regressions@lists.linux.dev \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).