linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/4] SDHCI and SMEM updates for sdx65.
@ 2022-05-02  8:37 Rohit Agarwal
  2022-05-02  8:37 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Rohit Agarwal @ 2022-05-02  8:37 UTC (permalink / raw)
  To: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	ulf.hansson, agross, bjorn.andersson, adrian.hunter,
	bhupesh.sharma
  Cc: linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm, Rohit Agarwal

Hello,

This series adds some patches addressing comments from Bjorn and Ulf.
The patches are from the  original series "SDX65 devicetree updates" that
were needed some changes.

Thanks,
Rohit.

Rohit Agarwal (4):
  dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible
  mmc: host/sdhci-msm: Add compatible string check for sdx65
  dt-bindings: arm-smmu: Add binding for SDX65 SMMU
  ARM: dts: qcom: sdx65: Add Shared memory manager support

 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml  | 1 +
 arch/arm/boot/dts/qcom-sdx65.dtsi                     | 4 +++-
 drivers/mmc/host/sdhci-msm.c                          | 1 +
 4 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible
  2022-05-02  8:37 [PATCH 0/4] SDHCI and SMEM updates for sdx65 Rohit Agarwal
@ 2022-05-02  8:37 ` Rohit Agarwal
  2022-05-02 17:04   ` Rob Herring
  2022-05-04 10:37   ` Ulf Hansson
  2022-05-02  8:37 ` [PATCH 2/4] mmc: host/sdhci-msm: Add compatible string check for sdx65 Rohit Agarwal
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 10+ messages in thread
From: Rohit Agarwal @ 2022-05-02  8:37 UTC (permalink / raw)
  To: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	ulf.hansson, agross, bjorn.andersson, adrian.hunter,
	bhupesh.sharma
  Cc: linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm, Rohit Agarwal

The SDHCI controller on SDX65 is based on MSM SDHCI v5 IP. Hence,
document the compatible with "qcom,sdhci-msm-v5" as the fallback.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
index da42a88..e423633 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
@@ -33,6 +33,7 @@ properties:
               - qcom,sdm630-sdhci
               - qcom,sdm845-sdhci
               - qcom,sdx55-sdhci
+              - qcom,sdx65-sdhci
               - qcom,sm6125-sdhci
               - qcom,sm6350-sdhci
               - qcom,sm8150-sdhci
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/4] mmc: host/sdhci-msm: Add compatible string check for sdx65
  2022-05-02  8:37 [PATCH 0/4] SDHCI and SMEM updates for sdx65 Rohit Agarwal
  2022-05-02  8:37 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
@ 2022-05-02  8:37 ` Rohit Agarwal
  2022-05-04 10:37   ` Ulf Hansson
  2022-05-02  8:37 ` [PATCH 3/4] dt-bindings: arm-smmu: Add binding for SDX65 SMMU Rohit Agarwal
  2022-05-02  8:37 ` [PATCH 4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support Rohit Agarwal
  3 siblings, 1 reply; 10+ messages in thread
From: Rohit Agarwal @ 2022-05-02  8:37 UTC (permalink / raw)
  To: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	ulf.hansson, agross, bjorn.andersson, adrian.hunter,
	bhupesh.sharma
  Cc: linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm, Rohit Agarwal

Add sdx65 SoC specific compatible string check inside qcom
'sdhci-msm' controller driver.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 drivers/mmc/host/sdhci-msm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index fd8b4a9..65661ad 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -2453,6 +2453,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {
 	 */
 	{.compatible = "qcom,qcs404-sdhci", .data = &sdhci_msm_v5_var},
 	{.compatible = "qcom,sdx55-sdhci",  .data = &sdhci_msm_v5_var},
+	{.compatible = "qcom,sdx65-sdhci",  .data = &sdhci_msm_v5_var},
 	{.compatible = "qcom,sdm630-sdhci", .data = &sdhci_msm_v5_var},
 	{.compatible = "qcom,sm6125-sdhci", .data = &sdhci_msm_v5_var},
 	{.compatible = "qcom,sm6350-sdhci", .data = &sdhci_msm_v5_var},
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/4] dt-bindings: arm-smmu: Add binding for SDX65 SMMU
  2022-05-02  8:37 [PATCH 0/4] SDHCI and SMEM updates for sdx65 Rohit Agarwal
  2022-05-02  8:37 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
  2022-05-02  8:37 ` [PATCH 2/4] mmc: host/sdhci-msm: Add compatible string check for sdx65 Rohit Agarwal
@ 2022-05-02  8:37 ` Rohit Agarwal
  2022-05-03 12:25   ` Krzysztof Kozlowski
  2022-05-02  8:37 ` [PATCH 4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support Rohit Agarwal
  3 siblings, 1 reply; 10+ messages in thread
From: Rohit Agarwal @ 2022-05-02  8:37 UTC (permalink / raw)
  To: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	ulf.hansson, agross, bjorn.andersson, adrian.hunter,
	bhupesh.sharma
  Cc: linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm, Rohit Agarwal

Add devicetree binding for Qualcomm SDX65 SMMU.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index da5381c..1f99bff 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -39,6 +39,7 @@ properties:
               - qcom,sc8180x-smmu-500
               - qcom,sdm845-smmu-500
               - qcom,sdx55-smmu-500
+              - qcom,sdx65-smmu-500
               - qcom,sm6350-smmu-500
               - qcom,sm8150-smmu-500
               - qcom,sm8250-smmu-500
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support
  2022-05-02  8:37 [PATCH 0/4] SDHCI and SMEM updates for sdx65 Rohit Agarwal
                   ` (2 preceding siblings ...)
  2022-05-02  8:37 ` [PATCH 3/4] dt-bindings: arm-smmu: Add binding for SDX65 SMMU Rohit Agarwal
@ 2022-05-02  8:37 ` Rohit Agarwal
  2022-06-28 20:19   ` (subset) " Bjorn Andersson
  3 siblings, 1 reply; 10+ messages in thread
From: Rohit Agarwal @ 2022-05-02  8:37 UTC (permalink / raw)
  To: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	ulf.hansson, agross, bjorn.andersson, adrian.hunter,
	bhupesh.sharma
  Cc: linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm, Rohit Agarwal

Add smem node to support shared memory manager on SDX65 platform.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm/boot/dts/qcom-sdx65.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
index 210e55c..57bda62 100644
--- a/arch/arm/boot/dts/qcom-sdx65.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
@@ -87,8 +87,10 @@
 		};
 
 		smem_mem: memory@8fe20000 {
-			no-map;
+			compatible = "qcom,smem";
 			reg = <0x8fe20000 0xc0000>;
+			hwlocks = <&tcsr_mutex 3>;
+			no-map;
 		};
 
 		cmd_db: reserved-memory@8fee0000 {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible
  2022-05-02  8:37 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
@ 2022-05-02 17:04   ` Rob Herring
  2022-05-04 10:37   ` Ulf Hansson
  1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2022-05-02 17:04 UTC (permalink / raw)
  To: Rohit Agarwal
  Cc: krzysztof.kozlowski+dt, ulf.hansson, linux-kernel, robin.murphy,
	robh+dt, agross, bhupesh.sharma, adrian.hunter, linux-arm-kernel,
	devicetree, linux-mmc, bjorn.andersson, linux-arm-msm, joro,
	will, iommu

On Mon, 02 May 2022 14:07:42 +0530, Rohit Agarwal wrote:
> The SDHCI controller on SDX65 is based on MSM SDHCI v5 IP. Hence,
> document the compatible with "qcom,sdhci-msm-v5" as the fallback.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] dt-bindings: arm-smmu: Add binding for SDX65 SMMU
  2022-05-02  8:37 ` [PATCH 3/4] dt-bindings: arm-smmu: Add binding for SDX65 SMMU Rohit Agarwal
@ 2022-05-03 12:25   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-03 12:25 UTC (permalink / raw)
  To: Rohit Agarwal, will, robin.murphy, joro, robh+dt,
	krzysztof.kozlowski+dt, ulf.hansson, agross, bjorn.andersson,
	adrian.hunter, bhupesh.sharma
  Cc: linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm

On 02/05/2022 10:37, Rohit Agarwal wrote:
> Add devicetree binding for Qualcomm SDX65 SMMU.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible
  2022-05-02  8:37 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
  2022-05-02 17:04   ` Rob Herring
@ 2022-05-04 10:37   ` Ulf Hansson
  1 sibling, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2022-05-04 10:37 UTC (permalink / raw)
  To: Rohit Agarwal
  Cc: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	agross, bjorn.andersson, adrian.hunter, bhupesh.sharma,
	linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm

On Mon, 2 May 2022 at 10:38, Rohit Agarwal <quic_rohiagar@quicinc.com> wrote:
>
> The SDHCI controller on SDX65 is based on MSM SDHCI v5 IP. Hence,
> document the compatible with "qcom,sdhci-msm-v5" as the fallback.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index da42a88..e423633 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -33,6 +33,7 @@ properties:
>                - qcom,sdm630-sdhci
>                - qcom,sdm845-sdhci
>                - qcom,sdx55-sdhci
> +              - qcom,sdx65-sdhci
>                - qcom,sm6125-sdhci
>                - qcom,sm6350-sdhci
>                - qcom,sm8150-sdhci
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/4] mmc: host/sdhci-msm: Add compatible string check for sdx65
  2022-05-02  8:37 ` [PATCH 2/4] mmc: host/sdhci-msm: Add compatible string check for sdx65 Rohit Agarwal
@ 2022-05-04 10:37   ` Ulf Hansson
  0 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2022-05-04 10:37 UTC (permalink / raw)
  To: Rohit Agarwal
  Cc: will, robin.murphy, joro, robh+dt, krzysztof.kozlowski+dt,
	agross, bjorn.andersson, adrian.hunter, bhupesh.sharma,
	linux-arm-kernel, iommu, devicetree, linux-kernel, linux-mmc,
	linux-arm-msm

On Mon, 2 May 2022 at 10:38, Rohit Agarwal <quic_rohiagar@quicinc.com> wrote:
>
> Add sdx65 SoC specific compatible string check inside qcom
> 'sdhci-msm' controller driver.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-msm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index fd8b4a9..65661ad 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -2453,6 +2453,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {
>          */
>         {.compatible = "qcom,qcs404-sdhci", .data = &sdhci_msm_v5_var},
>         {.compatible = "qcom,sdx55-sdhci",  .data = &sdhci_msm_v5_var},
> +       {.compatible = "qcom,sdx65-sdhci",  .data = &sdhci_msm_v5_var},
>         {.compatible = "qcom,sdm630-sdhci", .data = &sdhci_msm_v5_var},
>         {.compatible = "qcom,sm6125-sdhci", .data = &sdhci_msm_v5_var},
>         {.compatible = "qcom,sm6350-sdhci", .data = &sdhci_msm_v5_var},
> --
> 2.7.4
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: (subset) [PATCH 4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support
  2022-05-02  8:37 ` [PATCH 4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support Rohit Agarwal
@ 2022-06-28 20:19   ` Bjorn Andersson
  0 siblings, 0 replies; 10+ messages in thread
From: Bjorn Andersson @ 2022-06-28 20:19 UTC (permalink / raw)
  To: will, Rohit Agarwal, robh+dt, adrian.hunter, bhupesh.sharma,
	joro, ulf.hansson, krzysztof.kozlowski+dt, robin.murphy, agross
  Cc: linux-kernel, devicetree, linux-arm-kernel, linux-arm-msm,
	linux-mmc, iommu

On Mon, 2 May 2022 14:07:45 +0530, Rohit Agarwal wrote:
> Add smem node to support shared memory manager on SDX65 platform.
> 
> 

Applied, thanks!

[4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support
      commit: e378b965330d99e8622eb369021d0dac01591046

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-06-28 20:23 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02  8:37 [PATCH 0/4] SDHCI and SMEM updates for sdx65 Rohit Agarwal
2022-05-02  8:37 ` [PATCH 1/4] dt-bindings: mmc: sdhci-msm: Document the SDX65 compatible Rohit Agarwal
2022-05-02 17:04   ` Rob Herring
2022-05-04 10:37   ` Ulf Hansson
2022-05-02  8:37 ` [PATCH 2/4] mmc: host/sdhci-msm: Add compatible string check for sdx65 Rohit Agarwal
2022-05-04 10:37   ` Ulf Hansson
2022-05-02  8:37 ` [PATCH 3/4] dt-bindings: arm-smmu: Add binding for SDX65 SMMU Rohit Agarwal
2022-05-03 12:25   ` Krzysztof Kozlowski
2022-05-02  8:37 ` [PATCH 4/4] ARM: dts: qcom: sdx65: Add Shared memory manager support Rohit Agarwal
2022-06-28 20:19   ` (subset) " Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).