* [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements
@ 2020-03-29 18:57 Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 1/5] staging: rtl8712: fix checkpatch long-line warning Aiman Najjar
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-03-29 18:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel
Cc: Aiman Najjar, Joe Perches
Make several improvements to code style of rtl871x_xmit.c and rtl871x_xmit.h.
v1 -> v2: changes
* Break up single pach into patchset of small patches
v2 -> v3 changes:
* [PATCH 4/5]: Applied suggestions by Joe to improve overall code quality (thanks Joe!)
Aiman Najjar (5):
staging: rtl8712: fix checkpatch long-line warning
staging: rtl8712: fix long-line checkpatch warning
staging: rtl8712: fix checkpatch warnings
staging:rtl8712: code improvements to make_wlanhdr
staging: rtl8712:fix multiline derefernce warnings
drivers/staging/rtl8712/rtl871x_xmit.c | 158 ++++++++++++-------------
drivers/staging/rtl8712/rtl871x_xmit.h | 2 +-
2 files changed, 77 insertions(+), 83 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/5] staging: rtl8712: fix checkpatch long-line warning
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
@ 2020-03-29 18:57 ` Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 2/5] staging: rtl8712: fix long-line checkpatch warning Aiman Najjar
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-03-29 18:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel
Cc: Aiman Najjar, Joe Perches
This patch fixes these two long-line checkpatch warnings
in rtl871x_xmit.c:
WARNING: line over 80 characters
\#74: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:74:
+ * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME,
WARNING: line over 80 characters
\#79: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:79:
+ kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4, GFP_ATOMIC);
Signed-off-by: Aiman Najjar <aiman.najjar@hurranet.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index f0b85338b567..628e4bad1547 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -71,12 +71,13 @@ int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
_init_queue(&pxmitpriv->apsd_queue);
_init_queue(&pxmitpriv->free_xmit_queue);
/*
- * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME,
+ * Please allocate memory with sz = (struct xmit_frame) * NR_XMITFRAME,
* and initialize free_xmit_frame below.
* Please also apply free_txobj to link_up all the xmit_frames...
*/
pxmitpriv->pallocated_frame_buf =
- kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4, GFP_ATOMIC);
+ kmalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4,
+ GFP_ATOMIC);
if (!pxmitpriv->pallocated_frame_buf) {
pxmitpriv->pxmit_frame_buf = NULL;
return -ENOMEM;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v3 2/5] staging: rtl8712: fix long-line checkpatch warning
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 1/5] staging: rtl8712: fix checkpatch long-line warning Aiman Najjar
@ 2020-03-29 18:57 ` Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 3/5] staging: rtl8712: fix checkpatch warnings Aiman Najjar
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-03-29 18:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel
Cc: Aiman Najjar, Joe Perches
This patch fixes the following warning in rtl871x_xmit.c:
WARNING: line over 80 characters
130: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:130:
+ pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ,
Signed-off-by: Aiman Najjar <aiman.najjar@hurranet.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index 628e4bad1547..454c26f83406 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -127,8 +127,8 @@ int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,
pxmitbuf = (struct xmit_buf *)pxmitpriv->pxmitbuf;
for (i = 0; i < NR_XMITBUFF; i++) {
INIT_LIST_HEAD(&pxmitbuf->list);
- pxmitbuf->pallocated_buf = kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ,
- GFP_ATOMIC);
+ pxmitbuf->pallocated_buf =
+ kmalloc(MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, GFP_ATOMIC);
if (!pxmitbuf->pallocated_buf)
return -ENOMEM;
pxmitbuf->pbuf = pxmitbuf->pallocated_buf + XMITBUF_ALIGN_SZ -
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v3 3/5] staging: rtl8712: fix checkpatch warnings
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 1/5] staging: rtl8712: fix checkpatch long-line warning Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 2/5] staging: rtl8712: fix long-line checkpatch warning Aiman Najjar
@ 2020-03-29 18:57 ` Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 4/5] staging:rtl8712: code improvements to make_wlanhdr Aiman Najjar
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-03-29 18:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel
Cc: Aiman Najjar, Joe Perches
This patch fixes multiline dereference warnings in
rtl871x_xmit.c:
WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrptxmickey'
379: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:379:
+ psecuritypriv->
+ XGrptxmickey[psecuritypriv->
WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid'
380: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:380:
+ XGrptxmickey[psecuritypriv->
+ XGrpKeyid].skey);
Signed-off-by: Aiman Najjar <aiman.najjar@hurranet.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index 454c26f83406..0f789c821552 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -351,7 +351,7 @@ static int xmitframe_addmic(struct _adapter *padapter,
struct sta_info *stainfo;
struct qos_priv *pqospriv = &(padapter->mlmepriv.qospriv);
struct pkt_attrib *pattrib = &pxmitframe->attrib;
- struct security_priv *psecuritypriv = &padapter->securitypriv;
+ struct security_priv *psecpriv = &padapter->securitypriv;
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
u8 priority[4] = {0x0, 0x0, 0x0, 0x0};
bool bmcst = is_multicast_ether_addr(pattrib->ra);
@@ -369,15 +369,14 @@ static int xmitframe_addmic(struct _adapter *padapter,
0x0, 0x0};
pframe = pxmitframe->buf_addr + TXDESC_OFFSET;
if (bmcst) {
- if (!memcmp(psecuritypriv->XGrptxmickey
- [psecuritypriv->XGrpKeyid].skey,
+ if (!memcmp(psecpriv->XGrptxmickey
+ [psecpriv->XGrpKeyid].skey,
null_key, 16))
return -ENOMEM;
/*start to calculate the mic code*/
r8712_secmicsetkey(&micdata,
- psecuritypriv->
- XGrptxmickey[psecuritypriv->
- XGrpKeyid].skey);
+ psecpriv->XGrptxmickey
+ [psecpriv->XGrpKeyid].skey);
} else {
if (!memcmp(&stainfo->tkiptxmickey.skey[0],
null_key, 16))
@@ -417,7 +416,7 @@ static int xmitframe_addmic(struct _adapter *padapter,
length = pattrib->last_txcmdsz -
pattrib->hdrlen -
pattrib->iv_len -
- ((psecuritypriv->sw_encrypt)
+ ((psecpriv->sw_encrypt)
? pattrib->icv_len : 0);
r8712_secmicappend(&micdata, payload,
length);
@@ -425,7 +424,7 @@ static int xmitframe_addmic(struct _adapter *padapter,
} else {
length = pxmitpriv->frag_len -
pattrib->hdrlen - pattrib->iv_len -
- ((psecuritypriv->sw_encrypt) ?
+ ((psecpriv->sw_encrypt) ?
pattrib->icv_len : 0);
r8712_secmicappend(&micdata, payload,
length);
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v3 4/5] staging:rtl8712: code improvements to make_wlanhdr
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
` (2 preceding siblings ...)
2020-03-29 18:57 ` [PATCH v3 3/5] staging: rtl8712: fix checkpatch warnings Aiman Najjar
@ 2020-03-29 18:57 ` Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 5/5] staging: rtl8712:fix multiline derefernce warnings Aiman Najjar
2020-04-02 10:29 ` [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements Dan Carpenter
5 siblings, 0 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-03-29 18:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel
Cc: Aiman Najjar, Joe Perches
1. Refactor make_wlanhdr to improve code style.
2. Use ether_addr_copy instead of memcpy to copy addresses.
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Aiman Najjar <aiman.najjar@hurranet.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 123 ++++++++++++-------------
drivers/staging/rtl8712/rtl871x_xmit.h | 2 +-
2 files changed, 61 insertions(+), 64 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index 0f789c821552..21026297413c 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -477,75 +477,72 @@ static int make_wlanhdr(struct _adapter *padapter, u8 *hdr,
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct qos_priv *pqospriv = &pmlmepriv->qospriv;
__le16 *fctrl = &pwlanhdr->frame_ctl;
+ u8 *bssid;
memset(hdr, 0, WLANHDR_OFFSET);
SetFrameSubType(fctrl, pattrib->subtype);
- if (pattrib->subtype & WIFI_DATA_TYPE) {
- if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
- /* to_ds = 1, fr_ds = 0; */
- SetToDs(fctrl);
- memcpy(pwlanhdr->addr1, get_bssid(pmlmepriv),
- ETH_ALEN);
- memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN);
- memcpy(pwlanhdr->addr3, pattrib->dst, ETH_ALEN);
- } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
- /* to_ds = 0, fr_ds = 1; */
- SetFrDs(fctrl);
- memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN);
- memcpy(pwlanhdr->addr2, get_bssid(pmlmepriv),
- ETH_ALEN);
- memcpy(pwlanhdr->addr3, pattrib->src, ETH_ALEN);
- } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) ||
- check_fwstate(pmlmepriv,
- WIFI_ADHOC_MASTER_STATE)) {
- memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN);
- memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN);
- memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv),
- ETH_ALEN);
- } else if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) {
- memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN);
- memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN);
- memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv),
- ETH_ALEN);
- } else {
- return -EINVAL;
- }
+ if (!(pattrib->subtype & WIFI_DATA_TYPE))
+ return 0;
- if (pattrib->encrypt)
- SetPrivacy(fctrl);
- if (pqospriv->qos_option) {
- qc = (unsigned short *)(hdr + pattrib->hdrlen - 2);
- if (pattrib->priority)
- SetPriority(qc, pattrib->priority);
- SetAckpolicy(qc, pattrib->ack_policy);
- }
- /* TODO: fill HT Control Field */
- /* Update Seq Num will be handled by f/w */
- {
- struct sta_info *psta;
- bool bmcst = is_multicast_ether_addr(pattrib->ra);
-
- if (pattrib->psta) {
- psta = pattrib->psta;
- } else {
- if (bmcst)
- psta = r8712_get_bcmc_stainfo(padapter);
- else
- psta =
- r8712_get_stainfo(&padapter->stapriv,
- pattrib->ra);
- }
- if (psta) {
- psta->sta_xmitpriv.txseq_tid
- [pattrib->priority]++;
- psta->sta_xmitpriv.txseq_tid[pattrib->priority]
- &= 0xFFF;
- pattrib->seqnum = psta->sta_xmitpriv.
- txseq_tid[pattrib->priority];
- SetSeqNum(hdr, pattrib->seqnum);
- }
+ bssid = get_bssid(pmlmepriv);
+
+ if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) {
+ /* to_ds = 1, fr_ds = 0; */
+ SetToDs(fctrl);
+ ether_addr_copy(pwlanhdr->addr1, bssid);
+ ether_addr_copy(pwlanhdr->addr2, pattrib->src);
+ ether_addr_copy(pwlanhdr->addr3, pattrib->dst);
+ } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
+ /* to_ds = 0, fr_ds = 1; */
+ SetFrDs(fctrl);
+ ether_addr_copy(pwlanhdr->addr1, pattrib->dst);
+ ether_addr_copy(pwlanhdr->addr2, bssid);
+ ether_addr_copy(pwlanhdr->addr3, pattrib->src);
+ } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) ||
+ check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) {
+ ether_addr_copy(pwlanhdr->addr1, pattrib->dst);
+ ether_addr_copy(pwlanhdr->addr2, pattrib->src);
+ ether_addr_copy(pwlanhdr->addr3, bssid);
+ } else if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) {
+ ether_addr_copy(pwlanhdr->addr1, pattrib->dst);
+ ether_addr_copy(pwlanhdr->addr2, pattrib->src);
+ ether_addr_copy(pwlanhdr->addr3, bssid);
+ } else {
+ return -EINVAL;
+ }
+
+ if (pattrib->encrypt)
+ SetPrivacy(fctrl);
+ if (pqospriv->qos_option) {
+ qc = (unsigned short *)(hdr + pattrib->hdrlen - 2);
+ if (pattrib->priority)
+ SetPriority(qc, pattrib->priority);
+ SetAckpolicy(qc, pattrib->ack_policy);
+ }
+ /* TODO: fill HT Control Field */
+ /* Update Seq Num will be handled by f/w */
+ {
+ struct sta_info *psta;
+ bool bmcst = is_multicast_ether_addr(pattrib->ra);
+
+ if (pattrib->psta)
+ psta = pattrib->psta;
+ else if (bmcst)
+ psta = r8712_get_bcmc_stainfo(padapter);
+ else
+ psta = r8712_get_stainfo(&padapter->stapriv,
+ pattrib->ra);
+
+ if (psta) {
+ u16 *txtid = psta->sta_xmitpriv.txseq_tid;
+
+ txtid[pattrib->priority]++;
+ txtid[pattrib->priority] &= 0xFFF;
+ pattrib->seqnum = txtid[pattrib->priority];
+ SetSeqNum(hdr, pattrib->seqnum);
}
}
+
return 0;
}
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.h b/drivers/staging/rtl8712/rtl871x_xmit.h
index f227828094bf..c0c0c781fe17 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.h
+++ b/drivers/staging/rtl8712/rtl871x_xmit.h
@@ -115,7 +115,7 @@ struct pkt_attrib {
u8 icv_len;
unsigned char iv[8];
unsigned char icv[8];
- u8 dst[ETH_ALEN];
+ u8 dst[ETH_ALEN] __aligned(2); /* for ether_addr_copy */
u8 src[ETH_ALEN];
u8 ta[ETH_ALEN];
u8 ra[ETH_ALEN];
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v3 5/5] staging: rtl8712:fix multiline derefernce warnings
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
` (3 preceding siblings ...)
2020-03-29 18:57 ` [PATCH v3 4/5] staging:rtl8712: code improvements to make_wlanhdr Aiman Najjar
@ 2020-03-29 18:57 ` Aiman Najjar
2020-04-02 10:29 ` [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements Dan Carpenter
5 siblings, 0 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-03-29 18:57 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel
Cc: Aiman Najjar, Joe Perches
This patch fixes remaining checkpatch warnings
in rtl871x_xmit.c:
WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->PrivacyKeyIndex'
636: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:636:
+ (u8)psecuritypriv->
+ PrivacyKeyIndex);
WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid'
643: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:643:
+ (u8)psecuritypriv->
+ XGrpKeyid);
WARNING: Avoid multiple line dereference - prefer 'psecuritypriv->XGrpKeyid'
652: FILE: drivers/staging//rtl8712/rtl871x_xmit.c:652:
+ (u8)psecuritypriv->
+ XGrpKeyid);
Signed-off-by: Aiman Najjar <aiman.najjar@hurranet.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index 21026297413c..2f0d0ffa6fae 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -586,7 +586,7 @@ sint r8712_xmitframe_coalesce(struct _adapter *padapter, _pkt *pkt,
addr_t addr;
u8 *pframe, *mem_start, *ptxdesc;
struct sta_info *psta;
- struct security_priv *psecuritypriv = &padapter->securitypriv;
+ struct security_priv *psecpriv = &padapter->securitypriv;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
struct pkt_attrib *pattrib = &pxmitframe->attrib;
@@ -629,15 +629,13 @@ sint r8712_xmitframe_coalesce(struct _adapter *padapter, _pkt *pkt,
case _WEP40_:
case _WEP104_:
WEP_IV(pattrib->iv, psta->txpn,
- (u8)psecuritypriv->
- PrivacyKeyIndex);
+ (u8)psecpriv->PrivacyKeyIndex);
break;
case _TKIP_:
if (bmcst)
TKIP_IV(pattrib->iv,
psta->txpn,
- (u8)psecuritypriv->
- XGrpKeyid);
+ (u8)psecpriv->XGrpKeyid);
else
TKIP_IV(pattrib->iv, psta->txpn,
0);
@@ -645,8 +643,7 @@ sint r8712_xmitframe_coalesce(struct _adapter *padapter, _pkt *pkt,
case _AES_:
if (bmcst)
AES_IV(pattrib->iv, psta->txpn,
- (u8)psecuritypriv->
- XGrpKeyid);
+ (u8)psecpriv->XGrpKeyid);
else
AES_IV(pattrib->iv, psta->txpn,
0);
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
` (4 preceding siblings ...)
2020-03-29 18:57 ` [PATCH v3 5/5] staging: rtl8712:fix multiline derefernce warnings Aiman Najjar
@ 2020-04-02 10:29 ` Dan Carpenter
2020-04-03 1:41 ` Aiman Najjar
5 siblings, 1 reply; 8+ messages in thread
From: Dan Carpenter @ 2020-04-02 10:29 UTC (permalink / raw)
To: Aiman Najjar
Cc: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel, Joe Perches
Looks good. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements
2020-04-02 10:29 ` [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements Dan Carpenter
@ 2020-04-03 1:41 ` Aiman Najjar
0 siblings, 0 replies; 8+ messages in thread
From: Aiman Najjar @ 2020-04-03 1:41 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel, devel,
linux-kernel, Joe Perches
Thanks Dan for your review!!
On Thu, Apr 02, 2020 at 01:29:06PM +0300, Dan Carpenter wrote:
> Looks good. Thanks!
>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-03 1:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-29 18:57 [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c,h} code style improvements Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 1/5] staging: rtl8712: fix checkpatch long-line warning Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 2/5] staging: rtl8712: fix long-line checkpatch warning Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 3/5] staging: rtl8712: fix checkpatch warnings Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 4/5] staging:rtl8712: code improvements to make_wlanhdr Aiman Najjar
2020-03-29 18:57 ` [PATCH v3 5/5] staging: rtl8712:fix multiline derefernce warnings Aiman Najjar
2020-04-02 10:29 ` [PATCH v3 0/5] staging: rtl8712: rtl871x_xmit.{c, h} code style improvements Dan Carpenter
2020-04-03 1:41 ` Aiman Najjar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).