linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Thayer <michael.thayer@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses
Date: Wed, 31 Oct 2018 16:32:08 +0100	[thread overview]
Message-ID: <989f41f2-8b65-421a-7af3-69c35e7d2594@redhat.com> (raw)
In-Reply-To: <20181031150326.yikoivqgwfurtrg4@smtp.gmail.com>

Hi,

On 31-10-18 16:03, Shayenne da Luz Moura wrote:
> Remove unneeded parentheses around the arguments of ||. This reduces
> clutter and code behave in the same way.
> Change suggested by checkpatch.pl.
> 
> vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
> crtc->x'
> 
> Signed-off-by: Shayenne da Luz Moura <shayenneluzmoura@gmail.com>

Thank you.

Still looks good to me:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
> Changes in v2:
>    - Make the commit message more clearer.
> 
> Changes in v3:
>    - Update to apply patch to the latest kernel tree
> 
>   drivers/staging/vboxvideo/vbox_main.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
> index 7466c1103ff6..ad0e0b62bd1e 100644
> --- a/drivers/staging/vboxvideo/vbox_main.c
> +++ b/drivers/staging/vboxvideo/vbox_main.c
> @@ -122,10 +122,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,
>   			struct vbva_cmd_hdr cmd_hdr;
>   			unsigned int crtc_id = to_vbox_crtc(crtc)->crtc_id;
>   
> -			if ((rects[i].x1 > crtc_x + mode->hdisplay) ||
> -			    (rects[i].y1 > crtc_y + mode->vdisplay) ||
> -			    (rects[i].x2 < crtc_x) ||
> -			    (rects[i].y2 < crtc_y))
> +			if (rects[i].x1 > crtc_x + mode->hdisplay ||
> +			    rects[i].y1 > crtc_y + mode->vdisplay ||
> +			    rects[i].x2 < crtc_x ||
> +			    rects[i].y2 < crtc_y)
>   				continue;
>   
>   			cmd_hdr.x = (s16)rects[i].x1;
> 

      reply	other threads:[~2018-10-31 15:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 15:03 [PATCH v3] staging: vboxvideo: Remove unnecessary parentheses Shayenne da Luz Moura
2018-10-31 15:32 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=989f41f2-8b65-421a-7af3-69c35e7d2594@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shayenneluzmoura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).