From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751606AbdEATZ0 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 1 May 2017 15:25:26 -0400
Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:57314 "EHLO
        resqmta-po-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751472AbdEATYA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 1 May 2017 15:24:00 -0400
Reply-To: shuah@kernel.org
Subject: Re: [PATCH v1] selftests: Make test_harness.h more generally
 available
References: <20170430122619.31407-1-mic@digikod.net>
 <CAGXu5j+ShwrMObKSfQZbNgqqaniPTjmbXGLMOzGO2M_Twfp=1Q@mail.gmail.com>
 <CAAFS_9F_oYuDBGoG_db3i3EOVWnzSsm9uvirExMKUqYLAbBH6g@mail.gmail.com>
To: Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>
Cc: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@amacapital.net>, linux-kselftest@vger.kernel.org,
        Shuah Khan <shuahkh@osg.samsung.com>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <98f52134-e3b8-3eba-1f72-edefa3115647@kernel.org>
Date: Mon, 1 May 2017 13:23:58 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAAFS_9F_oYuDBGoG_db3i3EOVWnzSsm9uvirExMKUqYLAbBH6g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-CMAE-Envelope: MS4wfK5Kv7pmI4fl48gC8hHmUnJofGDQ/MKMGBrdi9IpxaZgJ5kY1RB7PdLcOlT26DQNeu2SrHoluJZxBYG47rD2wi17ulsEjffseYCoM50YcHz7dhtLV9O/
 1o4UNIvPzkZB1F5eN/Vw5ysNTyOvAZCXXTMai97FI0SfL+OaXht2GecRyxyVCpcMFhEfWRWc5a6UL1R/0/fKSvQJ0P7St6N2Pm4NhrfzH/ldLO6rIo1C8Df8
 sAHHZ0wkujzujMzhV3BnCpPaZ8e4ASI29QEDRgqnIDJr0VXLtB3ujvZQ2lzmab2pqJSK6GYaIh4BMFz1piScLAaQ1l9J0QFIBcSznMDZL7JugoJruOEQOU8m
 7f1w9kcODoBkhygsQitdP16XeXlMag==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/30/2017 12:22 PM, Will Drewry wrote:
> On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>> On Sun, Apr 30, 2017 at 5:26 AM, Mickaël Salaün <mic@digikod.net> wrote:
>>> The seccomp/test_harness.h file contains useful helpers to build tests.
>>> Moving it to the selftest directory should benefit to other test
>>> components.
>>
>> Unless Shuah thinks this should live in a new include/ directory, this
>> looks fine to me.
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Same here!
> 
> Acked-by: Will Drewry <wad@chromium.org>
> 
>>

I think the location fine. It will be a good idea to write
documentation on how to use this harness. I would recommend
rename the file to kselftest_harness.h and a doc file
kselftest_harness.txt which will go into Documentation directory.

thanks,
- Shuah