From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>,
Jisheng Zhang <jszhang@kernel.org>
Cc: shawnguo@kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org,
linux@armlinux.org.uk, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, hayashi.kunihiko@socionext.com,
mhiramat@kernel.org, nobuhiro1.iwamatsu@toshiba.co.jp,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node
Date: Fri, 7 Jan 2022 13:47:03 +0100 [thread overview]
Message-ID: <99115cc4-32f6-d217-68be-33256a6993a8@canonical.com> (raw)
In-Reply-To: <d3cb7b8439ee3d06@bloch.sibelius.xs4all.nl>
On 29/12/2021 17:50, Mark Kettenis wrote:
>> From: Jisheng Zhang <jszhang@kernel.org>
>> Date: Thu, 30 Dec 2021 00:02:38 +0800
>>
>> After commit 281f1f99cf3a("PCI: dwc: Detect number of iATU windows"),
>> the number of iATU windows is detected at runtime, what's more,
>> the 'num-viewport' property parsing has been removed, so remove the
>> unused num-viewport from pcie node(s).
>>
>> It's too late for linux-5.17-rc1, I will rebase and send out v2 if
>> necessary when 5.17-rc1 is released.
>
> Please no. This only makes the device trees unnecessarily
> incompatible with older kernels
Anyone who is running a new DTB with older kernel is doomed anyway, not
only because of this change but hundreds of other similar cleanups, e.g.
making DTS conforming to dtschema. Are you sure there are such use cases
of using new DTB with old kernel? I cannot imagine making a stable
product with such scenario...
> and other OSes that do rely on the
> "num-viewport" property.
Right. We should have move the DTS out of the kernel when it was still
small. :)
> It really doesn't hurt to keep this property
> even if future Linux kernels no longer look at it.
For Exynos PCIe, the property is still required by bindings, so
definitely it cannot be removed from DTS. I did not check the other
bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-01-07 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 16:02 [PATCH 0/7] arm/arm64: dts: Remove unused num-viewport from pcie node Jisheng Zhang
2021-12-29 16:02 ` [PATCH 1/7] ARM: dts: ls1021a: remove unused num-viewport from pcie nodes Jisheng Zhang
2021-12-29 16:02 ` [PATCH 2/7] arm64: dts: visconti: Remove unused num-viewport from pcie node Jisheng Zhang
2021-12-29 16:02 ` [PATCH 3/7] arm64: dts: uniphier: " Jisheng Zhang
2021-12-29 16:02 ` [PATCH 4/7] arm64: tegra: " Jisheng Zhang
2021-12-29 16:02 ` [PATCH 5/7] arm64: dts: marvell: " Jisheng Zhang
2021-12-29 16:02 ` [PATCH 6/7] arm64: dts: freescale: " Jisheng Zhang
2021-12-29 16:02 ` [PATCH 7/7] arm64: dts: exynos: " Jisheng Zhang
2021-12-29 16:50 ` [PATCH 0/7] arm/arm64: dts: " Mark Kettenis
2022-01-07 12:47 ` Krzysztof Kozlowski [this message]
2022-01-07 19:39 ` Mark Kettenis
2022-01-10 9:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99115cc4-32f6-d217-68be-33256a6993a8@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=jonathanh@nvidia.com \
--cc=jszhang@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.kettenis@xs4all.nl \
--cc=mhiramat@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).