From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: nick.hawkins@hpe.com
Cc: broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, verdun@hpe.com,
linux@armlinux.org.uk, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
joel@jms.id.au
Subject: Re: [PATCH v1 2/5] spi: dt-bindings: add documentation for hpe,gxp-spifi
Date: Thu, 21 Jul 2022 17:03:06 +0200 [thread overview]
Message-ID: <991334b7-0073-c647-b762-3681b79d6171@linaro.org> (raw)
In-Reply-To: <20220720201158.78068-3-nick.hawkins@hpe.com>
On 20/07/2022 22:11, nick.hawkins@hpe.com wrote:
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> Create documentation for the hpe,gxp-spifi binding to support access to
> the SPI parts
>
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
> .../bindings/spi/hpe,gxp-spifi.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml
>
> diff --git a/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml b/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml
> new file mode 100644
> index 000000000000..015130ecf971
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/hpe,gxp-spifi.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/hpe,gxp-spifi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP spi controller flash interface
> +
> +maintainers:
> + - Nick Hawkins <nick.hawkins@hpe.com>
> + - Jean-Marie Verdun <verdun@hpe.com>
> +
> +allOf:
> + - $ref: "spi-controller.yaml#"
> +
> +properties:
> + compatible:
> + const: hpe,gxp-spifi
> +
> + reg:
> + items:
> + - description: cfg registers
> + - description: data registers
> + - description: mapped memory
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> +
> + spi@200 {
> + compatible = "hpe,gxp-spifi";
> + reg = <0x200 0x80>, <0xc000 0x100>, <0x38000000 0x800000>;
> + interrupts = <20>;
> + interrupt-parrent = <&vic0>;
Wrong property.
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + flash@0 {
> + reg = < 0 >;
Wrong indentation, no spaces for <.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-21 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 20:11 [PATCH v1 0/5] Add SPI Driver to HPE GXP Architecture nick.hawkins
2022-07-20 20:11 ` [PATCH v1 1/5] spi: spi-gxp: Add support for HPE GXP SoCs nick.hawkins
2022-07-21 14:53 ` Krzysztof Kozlowski
2022-07-21 16:04 ` Christophe JAILLET
2022-07-20 20:11 ` [PATCH v1 2/5] spi: dt-bindings: add documentation for hpe,gxp-spifi nick.hawkins
2022-07-21 14:39 ` Rob Herring
2022-07-21 15:03 ` Krzysztof Kozlowski [this message]
2022-07-20 20:11 ` [PATCH v1 3/5] ARM: dts: hpe: Add spi driver node nick.hawkins
2022-07-20 20:11 ` [PATCH v1 4/5] ARM: configs: multi_v7_defconfig: Enable HPE GXP SPI driver nick.hawkins
2022-07-21 15:06 ` Krzysztof Kozlowski
2022-07-20 20:11 ` [PATCH v1 5/5] MAINTAINERS: add spi support to GXP nick.hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991334b7-0073-c647-b762-3681b79d6171@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).