From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945C8C47404 for ; Thu, 10 Oct 2019 00:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AFF2206C0 for ; Thu, 10 Oct 2019 00:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732475AbfJJALA (ORCPT ); Wed, 9 Oct 2019 20:11:00 -0400 Received: from gate.crashing.org ([63.228.1.57]:56020 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731145AbfJJAK7 (ORCPT ); Wed, 9 Oct 2019 20:10:59 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x9A0AioC023487; Wed, 9 Oct 2019 19:10:45 -0500 Message-ID: <991382b92be6b78e596b089d2c3677358afa52fc.camel@kernel.crashing.org> Subject: Re: [PATCH 1/3] dt-bindings: net: ftgmac100: Document AST2600 compatible From: Benjamin Herrenschmidt To: Andrew Jeffery , netdev Cc: David Miller , Rob Herring , mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Stanley Date: Thu, 10 Oct 2019 11:10:44 +1100 In-Reply-To: <4998960d-6125-4402-9905-869653a84e52@www.fastmail.com> References: <20191008115143.14149-1-andrew@aj.id.au> <20191008115143.14149-2-andrew@aj.id.au> <75d915aec936be64ea5ebd63402efd90bb1c29d9.camel@kernel.crashing.org> <6f70580a-4b4b-45e0-8899-8a74f9587002@www.fastmail.com> <4998960d-6125-4402-9905-869653a84e52@www.fastmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-10-09 at 15:25 +1030, Andrew Jeffery wrote: > > On Wed, 9 Oct 2019, at 15:19, Andrew Jeffery wrote: > > > > > > On Wed, 9 Oct 2019, at 15:08, Benjamin Herrenschmidt wrote: > > > On Tue, 2019-10-08 at 22:21 +1030, Andrew Jeffery wrote: > > > > The AST2600 contains an FTGMAC100-compatible MAC, although it > > > > no- > > > > longer > > > > contains an MDIO controller. > > > > > > How do you talk to the PHY then ? > > > > There are still MDIO controllers, they're just not in the MAC IP on > > the 2600. > > Sorry, on reflection that description is a little ambiguous in its > use of 'it'. I'll > fix that in v2 as well. Does this read better? > > "The AST2600 contains an FTGMAC100-compatible MAC, although the MAC > no-longer contains an MDIO controller." That's fine. Or to be pendantic, say the MDIO controller has been moved of the MAC unit into its own separate block or something along those lines so people like me don't get anxious :) Cheers, Ben.