From: David Howells <dhowells@redhat.com>
To: chengang@emindsoft.com.cn
Cc: dhowells@redhat.com, trivial@kernel.org,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
nicolas.iooss_linux@m4x.org, linux-kernel@vger.kernel.org,
Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH v2 trivial] include/linux/dcache.h: Cleanup code and comments
Date: Mon, 11 Jan 2016 09:57:17 +0000 [thread overview]
Message-ID: <9916.1452506237@warthog.procyon.org.uk> (raw)
In-Reply-To: <1452381100-3187-1-git-send-email-chengang@emindsoft.com.cn>
chengang@emindsoft.com.cn wrote:
> -#define DCACHE_MISS_TYPE 0x00000000 /* Negative dentry (maybe fallthru to nowhere) */
> -#define DCACHE_WHITEOUT_TYPE 0x00100000 /* Whiteout dentry (stop pathwalk) */
> -#define DCACHE_DIRECTORY_TYPE 0x00200000 /* Normal directory */
> -#define DCACHE_AUTODIR_TYPE 0x00300000 /* Lookupless directory (presumed automount) */
> -#define DCACHE_REGULAR_TYPE 0x00400000 /* Regular file type (or fallthru to such) */
> -#define DCACHE_SPECIAL_TYPE 0x00500000 /* Other file type (or fallthru to such) */
> -#define DCACHE_SYMLINK_TYPE 0x00600000 /* Symlink (or fallthru to such) */
> +/* Negative dentry (maybe fallthru to nowhere) */
> +#define DCACHE_MISS_TYPE 0x00000000
> +/* Whiteout dentry (stop pathwalk) */
> +#define DCACHE_WHITEOUT_TYPE 0x00100000
> +/* Normal directory */
> +#define DCACHE_DIRECTORY_TYPE 0x00200000
> +/* Lookupless directory (presumed automount) */
> +#define DCACHE_AUTODIR_TYPE 0x00300000
> +/* Regular file type (or fallthru to such) */
> +#define DCACHE_REGULAR_TYPE 0x00400000
> +/* Other file type (or fallthru to such) */
> +#define DCACHE_SPECIAL_TYPE 0x00500000
> +/* Symlink (or fallthru to such) */
> +#define DCACHE_SYMLINK_TYPE 0x00600000
Please leave things like this as they were.
> - * d_really_is_negative - Determine if a dentry is really negative (ignoring fallthroughs)
> + * d_really_is_negative - Determine if a dentry is really negative (ignoring
> + * fallthroughs)
Does that break doc generation?
Is fudging the comments actually worth breaking git blame?
> -static inline int simple_positive(struct dentry *dentry)
> +static inline bool simple_positive(struct dentry *dentry)
This is worth doing - gcc actually produces better code sometimes with the int
-> bool switch. This should be a separate patch.
David
next prev parent reply other threads:[~2016-01-11 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 23:11 [PATCH v2 trivial] include/linux/dcache.h: Cleanup code and comments chengang
2016-01-11 9:57 ` David Howells [this message]
2016-01-11 14:58 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9916.1452506237@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=chengang@emindsoft.com.cn \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=trivial@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).