From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8061C43461 for ; Fri, 11 Sep 2020 04:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D9EA2075A for ; Fri, 11 Sep 2020 04:53:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725766AbgIKExP (ORCPT ); Fri, 11 Sep 2020 00:53:15 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:58878 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725446AbgIKExO (ORCPT ); Fri, 11 Sep 2020 00:53:14 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 5A091C46C49DB6911600; Fri, 11 Sep 2020 12:53:11 +0800 (CST) Received: from [127.0.0.1] (10.174.179.108) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Fri, 11 Sep 2020 12:53:09 +0800 Subject: Re: [PATCH -next] media: marvell-ccic: Fix -Wunused-function warnings To: Lubomir Rintel References: <20200910080933.40684-1-yuehaibing@huawei.com> <20200910082221.GA1115782@demiurge.local> <20200910145702.GA1118779@demiurge.local> CC: , , , , From: Yuehaibing Message-ID: <9925ae09-cc5f-8399-fe2f-a4e728a483d6@huawei.com> Date: Fri, 11 Sep 2020 12:53:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20200910145702.GA1118779@demiurge.local> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/10 22:57, Lubomir Rintel wrote: > On Thu, Sep 10, 2020 at 05:18:15PM +0800, Yuehaibing wrote: >> On 2020/9/10 16:22, Lubomir Rintel wrote: >>> On Thu, Sep 10, 2020 at 04:09:33PM +0800, YueHaibing wrote: >>>> If CONFIG_PM is n, gcc warns: >>>> >>>> drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: ‘mmpcam_resume’ defined but not used [-Wunused-function] >>>> static int mmpcam_resume(struct device *dev) >>>> ^~~~~~~~~~~~~ >>>> drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: ‘mmpcam_suspend’ defined but not used [-Wunused-function] >>>> static int mmpcam_suspend(struct device *dev) >>>> ^~~~~~~~~~~~~~ >>>> drivers/media/platform/marvell-ccic/mmp-driver.c:324:12: warning: ‘mmpcam_runtime_suspend’ defined but not used [-Wunused-function] >>>> static int mmpcam_runtime_suspend(struct device *dev) >>>> ^~~~~~~~~~~~~~~~~~~~~~ >>>> drivers/media/platform/marvell-ccic/mmp-driver.c:310:12: warning: ‘mmpcam_runtime_resume’ defined but not used [-Wunused-function] >>>> static int mmpcam_runtime_resume(struct device *dev) >>>> ^~~~~~~~~~~~~~~~~~~~~ >>>> >>>> Mark them as __maybe_unused to fix this. >>>> >>>> Reported-by: Hulk Robot >>>> Signed-off-by: YueHaibing >>> >>> Your colleague seems to sent out an equivalent patch: >>> https://lore.kernel.org/lkml/20200910080933.40684-1-yuehaibing@huawei.com/ >> >> This is my patch, paste an wrong link? > > Indeed, sorry for the confusion. > > The original mail only went to linux-media, not lkml, which is why I > picked the wrong one from the archive. Here's the patch: > > https://lore.kernel.org/linux-media/20200909112921.5116-1-weiyongjun1@huawei.com/ mmpcam_runtime_suspend/mmpcam_runtime_resume also should be cared, I'll adjust my patch based on it. > > Take care > Lubo > >> >>> >>> Cheers >>> Lubo >>> >>>> --- >>>> drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++---- >>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c >>>> index c4b28a00a3a2..032fdddbbecc 100644 >>>> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c >>>> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c >>>> @@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev) >>>> * Suspend/resume support. >>>> */ >>>> >>>> -static int mmpcam_runtime_resume(struct device *dev) >>>> +static int __maybe_unused mmpcam_runtime_resume(struct device *dev) >>>> { >>>> struct mmp_camera *cam = dev_get_drvdata(dev); >>>> struct mcam_camera *mcam = &cam->mcam; >>>> @@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev) >>>> return 0; >>>> } >>>> >>>> -static int mmpcam_runtime_suspend(struct device *dev) >>>> +static int __maybe_unused mmpcam_runtime_suspend(struct device *dev) >>>> { >>>> struct mmp_camera *cam = dev_get_drvdata(dev); >>>> struct mcam_camera *mcam = &cam->mcam; >>>> @@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev) >>>> return 0; >>>> } >>>> >>>> -static int mmpcam_suspend(struct device *dev) >>>> +static int __maybe_unused mmpcam_suspend(struct device *dev) >>>> { >>>> struct mmp_camera *cam = dev_get_drvdata(dev); >>>> >>>> @@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev) >>>> return 0; >>>> } >>>> >>>> -static int mmpcam_resume(struct device *dev) >>>> +static int __maybe_unused mmpcam_resume(struct device *dev) >>>> { >>>> struct mmp_camera *cam = dev_get_drvdata(dev); >>>> >>>> -- >>>> 2.17.1 >>>> >>>> >>> >>> . >>> >> > > . >