From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ryan.Wanner@microchip.com, linus.walleij@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com, ludovic.desroches@microchip.com
Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: at91: dt: adding new macros
Date: Fri, 17 Feb 2023 09:47:20 +0100 [thread overview]
Message-ID: <994c3edd-040c-5050-9c99-1e8326459d54@linaro.org> (raw)
In-Reply-To: <20230216222524.3107759-3-Ryan.Wanner@microchip.com>
On 16/02/2023 23:25, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Adding macros for sama7g drive strength.
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Nothing improved here.
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> changes from v1:
> - Fix ABI break.
> - Add some small comments to describe drive strength macros.
>
> include/dt-bindings/pinctrl/at91.h | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h
> index e8e117306b1b..12f3edf2a9c4 100644
> --- a/include/dt-bindings/pinctrl/at91.h
> +++ b/include/dt-bindings/pinctrl/at91.h
> @@ -42,8 +42,16 @@
> #define AT91_PERIPH_C 3
> #define AT91_PERIPH_D 4
>
> -#define ATMEL_PIO_DRVSTR_LO 1
> +/*These macros are for all other at91 pinctrl drivers*/
> +#define ATMEL_PIO_DRVSTR_LO 0
> +#define ATMEL_PIO_DRVSTR_LO_1 1
> #define ATMEL_PIO_DRVSTR_ME 2
> #define ATMEL_PIO_DRVSTR_HI 3
>
> +/* These macros are for the sama7g5 pinctrl driver*/
What I mean, is the explanation of the constants. What is LO_D?
> +#define ATMEL_PIO_DRVSTR_LO_D 0
Also looks like wrong indentation between define and value.
> +#define ATMEL_PIO_DRVSTR_HI_A 1
> +#define ATMEL_PIO_DRVSTR_LO_C 2
> +#define ATMEL_PIO_DRVSTR_LO_B 3
> +
> #endif /* __DT_BINDINGS_AT91_PINCTRL_H__ */
Best regards,
Krzysztof
prev parent reply other threads:[~2023-02-17 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 22:25 [PATCH v2 0/2] pinctrl: Sama7g5 drive strength options updated Ryan.Wanner
2023-02-16 22:25 ` [PATCH v2 1/2] pinctrl: at91-pio4: Implement the correct drive values for sama7g5 Ryan.Wanner
2023-02-17 11:24 ` Claudiu.Beznea
2023-02-16 22:25 ` [PATCH v2 2/2] ARM: at91: dt: adding new macros Ryan.Wanner
2023-02-17 8:47 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994c3edd-040c-5050-9c99-1e8326459d54@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Ryan.Wanner@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).